-
-
Notifications
You must be signed in to change notification settings - Fork 656
add error-handling exercise #2732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
010e4ec
69a0b95
0c70883
42df9e1
272f673
8c070a5
1c87531
92a7c22
1e5d829
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Instructions | ||
|
|
||
| Implement various kinds of error handling and resource management. | ||
|
|
||
| An important point of programming is how to handle errors and close resources even if errors occur. | ||
|
|
||
| This exercise requires you to handle various errors. | ||
| Because error handling is rather programming language specific you'll have to refer to the tests for your track to see what's exactly required. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Error Handling | ||
|
|
||
| In this exercise, you will implement a function called `processString` that processes a given input string with proper error handling. | ||
|
|
||
| You will learn how to: | ||
|
|
||
| - Check input types and throw errors for invalid inputs. | ||
| - Throw errors for specific cases (e.g., empty strings). | ||
| - Return the uppercase version of the string if it is valid. | ||
| - Handle and catch errors using a try..catch block | ||
|
|
||
|
|
||
| Implement the processString function using a `try…catch` block. | ||
|
|
||
| Inside the `try` block: | ||
|
|
||
| - If the input is not a string, throw a `TypeError`. | ||
|
|
||
| - If the input is an empty string, throw a generic `Error`. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. how about on empty string, instead of throwing, it returns we can also explicitly forbid the generic |
||
|
|
||
| - Otherwise, return the input in `uppercase`. | ||
|
|
||
| Inside the `catch` block: | ||
| - console log the `error` message | ||
| - `throw` the `error` so it can be tested for its type. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| /node_modules | ||
| /bin/configlet | ||
| /bin/configlet.exe | ||
| /package-lock.json | ||
| /yarn.lock |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "authors": [ | ||
| "A-O-Emmanuel" | ||
| ], | ||
| "files": { | ||
| "solution": [ | ||
| "error-handling.js" | ||
| ], | ||
| "test": [ | ||
| "error-handling.spec.js" | ||
| ], | ||
| "example": [ | ||
| ".meta/proof.ci.js" | ||
| ] | ||
| }, | ||
| "blurb": "Implement various kinds of error handling and resource management." | ||
| } |
A-O-Emmanuel marked this conversation as resolved.
Show resolved
Hide resolved
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| export const processString = (input) => { | ||
| try { | ||
| if (typeof input !== 'string') { | ||
| throw new TypeError('Input must be a string'); | ||
| } | ||
| if (input === '') { | ||
| throw new Error('Input cannot be empty'); | ||
| } | ||
| return input.toUpperCase(); | ||
| } catch (error) { | ||
| console.log(error.message); | ||
| throw error; | ||
| } | ||
| }; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| audit=false |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| MIT License | ||
|
|
||
| Copyright (c) 2021 Exercism | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included in all | ||
| copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| SOFTWARE. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| module.exports = { | ||
| presets: [['@exercism/babel-preset-javascript', { corejs: '3.40' }]], | ||
| plugins: [], | ||
| }; |
A-O-Emmanuel marked this conversation as resolved.
Show resolved
Hide resolved
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| // | ||
| // This is only a SKELETON file for the 'Error handling' exercise. It's been provided as a | ||
| // convenience to get you started writing code faster. | ||
| // | ||
|
|
||
| export const processString = (input) => { | ||
| throw new Error('Remove this line and implement the function'); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the way this currently is, it'll pass one of the tests by default, without the student changing anything. |
||
| }; | ||
A-O-Emmanuel marked this conversation as resolved.
Show resolved
Hide resolved
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import { describe, expect, test, xtest } from '@jest/globals'; | ||
| import { processString } from './error-handling'; | ||
|
|
||
| describe('Error Handling', () => { | ||
| test('throws TypeError if input is not a string', () => { | ||
| expect(() => processString(42)).toThrow(TypeError); | ||
| }); | ||
|
|
||
| xtest('throws Error message if string is empty', () => { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Idk if i'm vibing with this test specifically, maybe we need to add some handling for the empty string case, instead of throwing error. In any case, more tests are needed, like for example do we want the tests to pass with any generic |
||
| expect(() => processString('')).toThrow(Error); | ||
| }); | ||
|
|
||
| xtest('returns uppercase string if input is valid', () => { | ||
| expect(processString('hello')).toBe('HELLO'); | ||
| }); | ||
| }); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| // @ts-check | ||
|
|
||
| import config from '@exercism/eslint-config-javascript'; | ||
| import maintainersConfig from '@exercism/eslint-config-javascript/maintainers.mjs'; | ||
|
|
||
| import globals from 'globals'; | ||
|
|
||
| export default [ | ||
| ...config, | ||
| ...maintainersConfig, | ||
| { | ||
| files: maintainersConfig[1].files, | ||
| rules: { | ||
| 'jest/expect-expect': ['warn', { assertFunctionNames: ['expect*'] }], | ||
| }, | ||
| }, | ||
| { | ||
| files: ['scripts/**/*.mjs'], | ||
| languageOptions: { | ||
| globals: { | ||
| ...globals.node, | ||
| }, | ||
| }, | ||
| }, | ||
| // <<inject-rules-here>> | ||
| { | ||
| ignores: [ | ||
| // # Protected or generated | ||
| '/.appends/**/*', | ||
| '/.github/**/*', | ||
| '/.vscode/**/*', | ||
|
|
||
| // # Binaries | ||
| '/bin/*', | ||
|
|
||
| // # Configuration | ||
| '/config', | ||
| '/babel.config.js', | ||
|
|
||
| // # Typings | ||
| '/exercises/**/global.d.ts', | ||
| '/exercises/**/env.d.ts', | ||
| ], | ||
| }, | ||
| ]; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| module.exports = { | ||
| verbose: true, | ||
| projects: ['<rootDir>'], | ||
| testMatch: [ | ||
| '**/__tests__/**/*.[jt]s?(x)', | ||
| '**/test/**/*.[jt]s?(x)', | ||
| '**/?(*.)+(spec|test).[jt]s?(x)', | ||
| ], | ||
| testPathIgnorePatterns: [ | ||
| '/(?:production_)?node_modules/', | ||
| '.d.ts$', | ||
| '<rootDir>/test/fixtures', | ||
| '<rootDir>/test/helpers', | ||
| '__mocks__', | ||
| ], | ||
| transform: { | ||
| '^.+\\.[jt]sx?$': 'babel-jest', | ||
| }, | ||
| moduleNameMapper: { | ||
| '^(\\.\\/.+)\\.js$': '$1', | ||
| }, | ||
| }; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "name": "@exercism/javascript-practice-error-handling", | ||
| "description": "Exercism practice exercise on error-handling", | ||
| "author": "Katrina Owen", | ||
| "contributors": [ | ||
| "Derk-Jan Karrenbeld <derk-jan+git@karrenbeld.info> (https://derk-jan.com)", | ||
| "Tejas Bubane (https://tejasbubane.github.io/)" | ||
| ], | ||
| "private": true, | ||
| "license": "MIT", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/exercism/javascript", | ||
| "directory": "exercises/practice/error-handling" | ||
| }, | ||
| "devDependencies": { | ||
| "@exercism/babel-preset-javascript": "^0.5.1", | ||
| "@exercism/eslint-config-javascript": "^0.8.1", | ||
| "@jest/globals": "^29.7.0", | ||
| "@types/node": "^22.15.29", | ||
| "@types/shelljs": "^0.8.17", | ||
| "babel-jest": "^29.7.0", | ||
| "core-js": "~3.42.0", | ||
| "diff": "^8.0.2", | ||
| "eslint": "^9.28.0", | ||
| "expect": "^29.7.0", | ||
| "globals": "^16.2.0", | ||
| "jest": "^29.7.0" | ||
| }, | ||
| "dependencies": {}, | ||
| "scripts": { | ||
| "lint": "corepack pnpm eslint .", | ||
| "test": "corepack pnpm jest", | ||
| "watch": "corepack pnpm jest --watch", | ||
| "format": "corepack pnpm prettier -w ." | ||
| }, | ||
| "packageManager": "pnpm@9.15.2" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line probably needs to be removed, or at least changed because it's generic from the
problem-specrepo