🐛 FIX: cli.parse: return 0 for non-error (#124)

Co-authored-by: Taneli Hukkinen <hukkinj1@users.noreply.github.com>
Co-authored-by: Wes Turner <wes@wrd.nu>
Co-authored-by: Wes Turner <50891+westurner@users.noreply.github.com>
Co-authored-by: Chris Sewell <chrisj_sewell@hotmail.com>

Author: 3 people

markdown_it/cli/parse.py

@@ -15,13 +15,13 @@
 version_str = "markdown-it-py [version {}]".format(__version__)
 
 
-def main(args: Optional[Sequence[str]] = None) -> bool:
+def main(args: Optional[Sequence[str]] = None) -> int:
     namespace = parse_args(args)
     if namespace.filenames:
         convert(namespace.filenames)
     else:
         interactive()
-    return True
+    return 0
 
 
 def convert(filenames: Iterable[str]) -> None:
@@ -38,7 +38,8 @@ def convert_file(filename: str) -> None:
             rendered = MarkdownIt().render(fin.read())
             print(rendered, end="")
     except OSError:
-        sys.exit('Cannot open file "{}".'.format(filename))
+        sys.stderr.write(f'Cannot open file "{filename}".\n')
+        sys.exit(1)
 
 
 def interactive() -> None:
@@ -103,4 +104,5 @@ def print_heading() -> None:
 
 
 if __name__ == "__main__":
-    main(sys.argv[1:])
+    exit_code = main(sys.argv[1:])
+    sys.exit(exit_code)

tests/test_cli.py

@@ -2,14 +2,22 @@
 import tempfile
 from unittest.mock import patch
 
+import pytest
+
 from markdown_it.cli import parse
 
 
 def test_parse():
     with tempfile.TemporaryDirectory() as tempdir:
         path = pathlib.Path(tempdir).joinpath("test.md")
         path.write_text("a b c")
-        assert parse.main([str(path)])
+        assert parse.main([str(path)]) == 0
+
+
+def test_parse_fail():
+    with pytest.raises(SystemExit) as exc_info:
+        parse.main(["/tmp/nonexistant_path/for_cli_test.md"])
+    assert exc_info.value.code == 1
 
 
 def test_print_heading():