Some changes to reduce string allocations

Author: niemyjski

src/Exceptionless/Extensions/DataDictionaryExtensions.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using Exceptionless.Dependency;
@@ -105,16 +105,16 @@ public static void AddObject(this IData data, ExtendedDataInfo info, Exceptionle
                 : client.Configuration.DataExclusions.ToArray();
 
             string name = !String.IsNullOrWhiteSpace(info.Name) ? info.Name.Trim() : null;
+            Type dataType = info.Data.GetType();
             if (String.IsNullOrEmpty(name)) {
-                name = info.Data.GetType().Name;
+                name = dataType.Name;
                 int index = 1;
                 while (data.Data.ContainsKey(name))
-                    name = info.Data.GetType().Name + index++;
+                    name = dataType.Name + index++;
             } else if (name.AnyWildcardMatches(exclusions, true)) {
                 return;
             }
 
-            Type dataType = info.Data.GetType();
             if (dataType == typeof(bool) || dataType == typeof(string) || dataType.IsNumeric()) {
                 if (data.Data.ContainsKey(name))
                     data.Data[name] = info.Data;

src/Exceptionless/Extensions/StringExtensions.cs

@@ -26,9 +26,6 @@ public static bool AnyWildcardMatches(this string value, IEnumerable<string> pat
             if (patternsToMatch == null || value == null)
                 return false;
 
-            if (ignoreCase)
-                value = value.ToLower();
-
             return patternsToMatch.Any(pattern => IsPatternMatch(value, pattern, ignoreCase));
         }
 
@@ -49,33 +46,18 @@ public static bool IsPatternMatch(this string value, string pattern, bool ignore
             bool endsWithWildcard = pattern.EndsWith("*");
             if (endsWithWildcard)
                 pattern = pattern.Substring(0, pattern.Length - 1);
-
-            if (ignoreCase) {
-                value = value.ToLower();
-                pattern = pattern.ToLower();
-            }
-
+            
+            var comparison = ignoreCase ? StringComparison.InvariantCultureIgnoreCase : StringComparison.InvariantCulture;
             if (startsWithWildcard && endsWithWildcard)
-                return value.Contains(pattern);
+                return value.IndexOf(pattern ?? "", comparison) >= 0;
 
             if (startsWithWildcard)
-                return value.EndsWith(pattern);
+                return value.EndsWith(pattern, comparison);
 
             if (endsWithWildcard)
-                return value.StartsWith(pattern);
-
-            return String.Equals(value, pattern);
-        }
-
-        public static string[] SplitAndTrim(this string input, params char[] separator) {
-            if (String.IsNullOrEmpty(input))
-                return new string[0];
-
-            var result = input.Split(separator, StringSplitOptions.RemoveEmptyEntries);
-            for (int i = 0; i < result.Length; i++)
-                result[i] = result[i].Trim();
+                return value.StartsWith(pattern, comparison);
 
-            return result;
+            return String.Equals(value, pattern, comparison);
         }
 
         public static bool ToBoolean(this string input, bool @default = false) {