#Fix 260, Add minimum log fixes for Microsoft.Extensions.Logging, Log4net

I also fixed the case for set default min log level on NLog when using the default client.

Author: niemyjski

src/Platforms/Exceptionless.Extensions.Logging/ExceptionlessLoggerExtensions.cs

@@ -89,7 +89,7 @@ public static ILoggingBuilder AddExceptionless(this ILoggingBuilder builder, Act
         /// <param name="factory">The <see cref="ILoggerFactory"/>.</param>
         /// <param name="client">If a client is not specified then the <see cref="ExceptionlessClient.Default"/> will be used.</param>
         /// <returns>The <see cref="ILoggerFactory"/>.</returns>
-        [Obsolete("Use ExceptionlessLoggerExtensions.AddExceptionless(ILoggingBuilder,ExceptionlessClient) instead.")]
+        [Obsolete("Use ExceptionlessLoggerExtensions.AddExceptionless(ILoggingBuilder, ExceptionlessClient) instead.")]
         public static ILoggerFactory AddExceptionless(this ILoggerFactory factory, ExceptionlessClient client = null) {
             factory.AddProvider(new ExceptionlessLoggerProvider(client ?? ExceptionlessClient.Default));
             return factory;
@@ -102,7 +102,7 @@ public static ILoggerFactory AddExceptionless(this ILoggerFactory factory, Excep
         /// <param name="apiKey">The project api key.</param>
         /// <param name="serverUrl">The Server Url</param>
         /// <returns>The <see cref="ILoggerFactory"/>.</returns>
-        [Obsolete("Use ExceptionlessLoggerExtensions.AddExceptionless(ILoggingBuilder,string,string) instead.")]
+        [Obsolete("Use ExceptionlessLoggerExtensions.AddExceptionless(ILoggingBuilder, string, string) instead.")]
         public static ILoggerFactory AddExceptionless(this ILoggerFactory factory, string apiKey, string serverUrl = null) {
             if (String.IsNullOrEmpty(apiKey) && String.IsNullOrEmpty(serverUrl))
                 return factory.AddExceptionless();
@@ -125,7 +125,7 @@ public static ILoggerFactory AddExceptionless(this ILoggerFactory factory, strin
         /// <param name="factory">The <see cref="ILoggerFactory"/>.</param>
         /// <param name="configure">An <see cref="Action{ExceptionlessConfiguration}"/> that applies additional settings and plugins. The project api key must be specified.</param>
         /// <returns>The <see cref="ILoggerFactory"/>.</returns>
-        [Obsolete("Use ExceptionlessLoggerExtensions.AddExceptionless(ILoggingBuilder,Action<ExceptionlessConfiguration>) instead.")]
+        [Obsolete("Use ExceptionlessLoggerExtensions.AddExceptionless(ILoggingBuilder, Action<ExceptionlessConfiguration>) instead.")]
         public static ILoggerFactory AddExceptionless(this ILoggerFactory factory, Action<ExceptionlessConfiguration> configure) {
             factory.AddProvider(new ExceptionlessLoggerProvider(configure));
             return factory;

src/Platforms/Exceptionless.Extensions.Logging/ExceptionlessLoggerProvider.cs

@@ -11,15 +11,22 @@ public class ExceptionlessLoggerProvider : ILoggerProvider {
         /// </summary>
         public ExceptionlessLoggerProvider(ExceptionlessClient client) {
             _client = client ?? throw new ArgumentNullException(nameof(client));
+
+            // Rely on Logging Rules
+            _client.Configuration.SetDefaultMinLogLevel(Exceptionless.Logging.LogLevel.Trace);
         }
 
         /// <summary>
         /// Initializes a new instance of the <see cref="ExceptionlessLoggerProvider"/> class.
         /// </summary>
         /// <param name="configure">An <see cref="Action{ExceptionlessConfiguration}"/> which will be used to configure created loggers.</param>
         public ExceptionlessLoggerProvider(Action<ExceptionlessConfiguration> configure) {
-            configure?.Invoke(ExceptionlessClient.Default.Configuration);
             _client = ExceptionlessClient.Default;
+
+            // Rely on Logging Rules
+            _client.Configuration.SetDefaultMinLogLevel(Exceptionless.Logging.LogLevel.Trace);
+            
+            configure?.Invoke(_client.Configuration);
             _shouldDispose = true;
         }
 

src/Platforms/Exceptionless.Log4net/BufferingExceptionlessAppender.cs

@@ -25,7 +25,11 @@ public override void ActivateOptions() {
                     config.ApiKey = ApiKey;
                 if (!String.IsNullOrEmpty(ServerUrl))
                     config.ServerUrl = ServerUrl;
+
                 config.UseInMemoryStorage();
+
+                // Rely on Logging Rules
+                config.SetDefaultMinLogLevel(Logging.LogLevel.Trace);
             });
         }
 

src/Platforms/Exceptionless.Log4net/ExceptionlessAppender.cs

@@ -18,7 +18,11 @@ public override void ActivateOptions() {
                     config.ApiKey = ApiKey;
                 if (!String.IsNullOrEmpty(ServerUrl))
                     config.ServerUrl = ServerUrl;
+
                 config.UseInMemoryStorage();
+
+                // Rely on Logging Rules
+                config.SetDefaultMinLogLevel(Logging.LogLevel.Trace);
             });
         }
 

src/Platforms/Exceptionless.Log4net/ExceptionlessClientExtensions.cs

@@ -20,7 +20,7 @@ public static EventBuilder CreateFromLogEvent(this ExceptionlessClient client, L
                 builder.SetSource(ev.LoggerName);
 
             var props = ev.GetProperties();
-            foreach (var key in props.GetKeys().Where(key => !_ignoredEventProperties.Contains(key, StringComparer.OrdinalIgnoreCase))) {
+            foreach (string key in props.GetKeys().Where(key => !_ignoredEventProperties.Contains(key, StringComparer.OrdinalIgnoreCase))) {
                 string propName = key;
                 if (propName.StartsWith("log4net:"))
                     propName = propName.Substring(8);

src/Platforms/Exceptionless.NLog/ExceptionlessTarget.cs

@@ -28,21 +28,26 @@ public ExceptionlessTarget() {
         protected override void InitializeTarget() {
             base.InitializeTarget();
 
-            var apiKey = RenderLogEvent(ApiKey, LogEventInfo.CreateNullEvent());
-            var serverUrl = RenderLogEvent(ServerUrl, LogEventInfo.CreateNullEvent());
+            string apiKey = RenderLogEvent(ApiKey, LogEventInfo.CreateNullEvent());
+            string serverUrl = RenderLogEvent(ServerUrl, LogEventInfo.CreateNullEvent());
 
             if (!String.IsNullOrEmpty(apiKey) || !String.IsNullOrEmpty(serverUrl)) {
                 _client = new ExceptionlessClient(config => {
                     if (!String.IsNullOrEmpty(apiKey) && apiKey != "API_KEY_HERE")
                         config.ApiKey = apiKey;
                     if (!String.IsNullOrEmpty(serverUrl))
                         config.ServerUrl = serverUrl;
+
                     config.UseLogger(new NLogInternalLoggger());
                     config.UseInMemoryStorage();
-                    config.SetDefaultMinLogLevel(Logging.LogLevel.Trace);   // Rely on NLog Logging Rules
+
+                    // Rely on Logging Rules
+                    config.SetDefaultMinLogLevel(Logging.LogLevel.Trace);
                 });
-            }
-            else {
+            } else {
+                // Rely on Logging Rules
+                _client.Configuration.SetDefaultMinLogLevel(Logging.LogLevel.Trace);
+
                 if (_client.Configuration.Resolver.HasDefaultRegistration<Logging.IExceptionlessLog, Logging.NullExceptionlessLog>()) {
                     _client.Configuration.UseLogger(new NLogInternalLoggger());
                 }