Listed all the things

I made the default parseInt radix be 10. Hopefully this won’t cause any
issues.

Author: niemyjski

gulpfile.js

@@ -5,6 +5,7 @@ var karma = require('gulp-karma');
 var package = require('./package.json');
 var replace = require('gulp-replace');
 var sourcemaps = require('gulp-sourcemaps');
+var tslint = require('gulp-tslint');
 var tsProject = require('tsproject');
 var uglify = require('gulp-uglify');
 var umd = require('gulp-wrap-umd');
@@ -88,7 +89,13 @@ gulp.task('watch', ['build'], function() {
   gulp.watch('src/**/*.ts', ['build']);
 });
 
-gulp.task('build', ['clean', 'exceptionless', 'exceptionless.node']);
+gulp.task('lint', function() {
+  return gulp.src(['src/**/*.ts', '!src/typings/**/*.ts'])
+    .pipe(tslint())
+    .pipe(tslint.report('verbose'));
+});
+
+gulp.task('build', ['clean', 'lint', 'exceptionless', 'exceptionless.node']);
 
 gulp.task('typescript.test', function() {
   return tsProject.src('src/tsconfig.test.json').pipe(gulp.dest('dist/temp'));

package.json

@@ -31,6 +31,7 @@
     "gulp-karma": "0.0.5",
     "gulp-replace": "0.5.4",
     "gulp-sourcemaps": "1.6.0",
+    "gulp-tslint": "^3.3.1",
     "gulp-uglify": "1.4.2",
     "gulp-wrap-umd": "0.2.1",
     "jasmine-core": "2.3.4",

src/EventBuilder.ts

@@ -1,4 +1,3 @@
-import { Configuration } from './configuration/Configuration';
 import { ExceptionlessClient } from './ExceptionlessClient';
 import { IEvent } from './models/IEvent';
 import { IUserInfo } from './models/IUserInfo';
@@ -7,12 +6,12 @@ import { EventPluginContext } from './plugins/EventPluginContext';
 import { Utils } from './Utils';
 
 export class EventBuilder {
-  private _validIdentifierErrorMessage:string = "must contain between 8 and 100 alphanumeric or '-' characters."; // optimization for minifier.
-
   public target:IEvent;
   public client:ExceptionlessClient;
   public pluginContextData:ContextData;
 
+  private _validIdentifierErrorMessage:string = 'must contain between 8 and 100 alphanumeric or \'-\' characters.'; // optimization for minifier.
+
   constructor(event:IEvent, client:ExceptionlessClient, pluginContextData?:ContextData) {
     this.target = event;
     this.client = client;
@@ -62,10 +61,13 @@ export class EventBuilder {
   }
 
   public setGeo(latitude: number, longitude: number): EventBuilder {
-    if (latitude < -90.0 || latitude > 90.0)
+    if (latitude < -90.0 || latitude > 90.0) {
       throw new Error('Must be a valid latitude value between -90.0 and 90.0.');
-    if (longitude < -180.0 || longitude > 180.0)
+    }
+
+    if (longitude < -180.0 || longitude > 180.0) {
       throw new Error('Must be a valid longitude value between -180.0 and 180.0.');
+    }
 
     this.target.geo = `${latitude},${longitude}`;
     return this;
@@ -75,7 +77,7 @@ export class EventBuilder {
   public setUserIdentity(identity:string): EventBuilder;
   public setUserIdentity(identity:string, name:string): EventBuilder;
   public setUserIdentity(userInfoOrIdentity:IUserInfo|string, name?:string): EventBuilder {
-    var userInfo = typeof userInfoOrIdentity !== 'string' ? userInfoOrIdentity : { identity: userInfoOrIdentity, name: name };
+    let userInfo = typeof userInfoOrIdentity !== 'string' ? userInfoOrIdentity : { identity: userInfoOrIdentity, name: name };
     if (!userInfo || (!userInfo.identity && !userInfo.name)) {
       return this;
     }
@@ -140,10 +142,10 @@ export class EventBuilder {
     }
 
     for (var index = 0; index < value.length; index++) {
-      var code = value.charCodeAt(index);
-      var isDigit = (code >= 48) && (code <= 57);
-      var isLetter = ((code >= 65) && (code <= 90)) || ((code >= 97) && (code <= 122));
-      var isMinus = code === 45;
+      let code = value.charCodeAt(index);
+      let isDigit = (code >= 48) && (code <= 57);
+      let isLetter = ((code >= 65) && (code <= 90)) || ((code >= 97) && (code <= 122));
+      let isMinus = code === 45;
 
       if (!(isDigit || isLetter) && !isMinus) {
         return false;

src/ExceptionlessClient-spec.ts

@@ -3,15 +3,15 @@ import { EventPluginContext } from './plugins/EventPluginContext';
 
 describe('ExceptionlessClient', () => {
   it('should use event reference ids', (done) => {
-    var error = new Error('From Unit Test');
+    let error = new Error('From Unit Test');
 
-    var client = new ExceptionlessClient('LhhP1C9gijpSKCslHHCvwdSIz298twx271n1l6xw', 'http://localhost:50000');
+    let client = new ExceptionlessClient('LhhP1C9gijpSKCslHHCvwdSIz298twx271n1l6xw', 'http://localhost:50000');
     expect(client.config.lastReferenceIdManager.getLast()).toBe(null);
     client.submitException(error, (context:EventPluginContext) => {
       expect(client.config.lastReferenceIdManager.getLast()).toBe(null);
     });
 
-    var numberOfPlugins = client.config.plugins.length;
+    let numberOfPlugins = client.config.plugins.length;
     client.config.useReferenceIds();
     expect(client.config.plugins.length).toBe(numberOfPlugins + 1);
 
@@ -27,26 +27,26 @@ describe('ExceptionlessClient', () => {
   }, 5000);
 
   it('should accept null source', () => {
-    var client = new ExceptionlessClient('LhhP1C9gijpSKCslHHCvwdSIz298twx271n1l6xw', 'http://localhost:50000');
-    var builder = client.createLog(null, 'Unit Test message', 'Trace');
+    let client = new ExceptionlessClient('LhhP1C9gijpSKCslHHCvwdSIz298twx271n1l6xw', 'http://localhost:50000');
+    let builder = client.createLog(null, 'Unit Test message', 'Trace');
 
     expect(builder.target.source).toBeUndefined();
     expect(builder.target.message).toBe('Unit Test message');
     expect(builder.target.data['@level']).toBe('Trace');
   });
 
   it('should accept source and message', () => {
-    var client = new ExceptionlessClient('LhhP1C9gijpSKCslHHCvwdSIz298twx271n1l6xw', 'http://localhost:50000');
-    var builder = client.createLog('ExceptionlessClient', 'Unit Test message');
+    let client = new ExceptionlessClient('LhhP1C9gijpSKCslHHCvwdSIz298twx271n1l6xw', 'http://localhost:50000');
+    let builder = client.createLog('ExceptionlessClient', 'Unit Test message');
 
     expect(builder.target.source).toBe('ExceptionlessClient');
     expect(builder.target.message).toBe('Unit Test message');
     expect(builder.target.data).toBeUndefined();
   });
 
   it('should accept source and message', () => {
-    var client = new ExceptionlessClient('LhhP1C9gijpSKCslHHCvwdSIz298twx271n1l6xw', 'http://localhost:50000');
-    var builder = client.createLog('Unit Test message');
+    let client = new ExceptionlessClient('LhhP1C9gijpSKCslHHCvwdSIz298twx271n1l6xw', 'http://localhost:50000');
+    let builder = client.createLog('Unit Test message');
 
     expect(builder.target.source).toBeUndefined();
     expect(builder.target.message).toBe('Unit Test message');

src/Utils-spec.ts

@@ -1,9 +1,8 @@
-import { IEvent } from './models/IEvent';
 import { Utils } from './Utils';
 
 describe('Utils', () => {
   it('should add range', () => {
-    var target:string[];
+    let target:string[];
     expect(Utils.addRange(target)).toEqual([]);
     expect(target).toBeUndefined();
 
@@ -16,15 +15,15 @@ describe('Utils', () => {
   });
 
   it('should stringify circular reference', () => {
-    var afoo:any = {a: 'foo'};
+    let afoo:any = {a: 'foo'};
     afoo.b = afoo;
 
     expect(Utils.stringify(afoo)).toBe('{"a":"foo"}');
     expect(Utils.stringify([{one: afoo, two: afoo}])).toBe('[{"one":{"a":"foo"}}]');
   });
 
   describe('stringify', () => {
-    var user:any = {
+    let user:any = {
       id:1,
       name: 'Blake',
       password: '123456',
@@ -61,36 +60,36 @@ describe('Utils', () => {
   });
 
   it('should stringify array', () => {
-    var error = {
-      "type": "error",
-      "data": {
-        "@error": {
-          "type": "Error",
-          "message": "string error message",
-          "stack_trace": [
+    let error = {
+      'type': 'error',
+      'data': {
+        '@error': {
+          'type': 'Error',
+          'message': 'string error message',
+          'stack_trace': [
             {
-              "name": "throwStringErrorImpl",
-              "parameters": [],
-              "file_name": "http://localhost/index.js",
-              "line_number": 22,
-              "column": 9
+              'name': 'throwStringErrorImpl',
+              'parameters': [],
+              'file_name': 'http://localhost/index.js',
+              'line_number': 22,
+              'column': 9
             },
             {
-              "name": "throwStringError",
-              "parameters": [],
-              "file_name": "http://localhost/index.js",
-              "line_number": 10,
-              "column": 10
+              'name': 'throwStringError',
+              'parameters': [],
+              'file_name': 'http://localhost/index.js',
+              'line_number': 10,
+              'column': 10
             }, {
-              "name": "HTMLButtonElement.onclick",
-              "parameters": [],
-              "file_name": "http://localhost/",
-              "line_number": 22,
-              "column": 10
+              'name': 'HTMLButtonElement.onclick',
+              'parameters': [],
+              'file_name': 'http://localhost/',
+              'line_number': 22,
+              'column': 10
             }]
-        }, "@submission_method": "onerror"
+        }, '@submission_method': 'onerror'
       },
-      "tags": []
+      'tags': []
     };
 
     expect(Utils.stringify(error)).toBe(JSON.stringify(error));

src/Utils.ts

@@ -1,5 +1,3 @@
-import { IStackFrame } from './models/IStackFrame';
-
 export class Utils {
   public static addRange<T>(target:T[], ...values:T[]) {
     if (!target) {
@@ -10,7 +8,7 @@ export class Utils {
       return target;
     }
 
-    for (var index = 0; index < values.length; index++) {
+    for (let index = 0; index < values.length; index++) {
       if (values[index] && target.indexOf(values[index]) < 0) {
         target.push(values[index]);
       }
@@ -24,9 +22,9 @@ export class Utils {
       return null;
     }
 
-    var hash:number = 0;
-    for (var index = 0; index < source.length; index++) {
-      var character   = source.charCodeAt(index);
+    let hash:number = 0;
+    for (let index = 0; index < source.length; index++) {
+      let character   = source.charCodeAt(index);
       hash  = ((hash << 5) - hash) + character;
       hash |= 0;
     }
@@ -35,11 +33,11 @@ export class Utils {
   }
 
   public static getCookies(cookies:string): Object {
-    var result:Object = {};
+    let result:Object = {};
 
-    var parts:string[] = (cookies || '').split('; ');
-    for (var index = 0; index < parts.length; index++) {
-      var cookie:string[] = parts[index].split('=');
+    let parts:string[] = (cookies || '').split('; ');
+    for (let index = 0; index < parts.length; index++) {
+      let cookie:string[] = parts[index].split('=');
       result[cookie[0]] = cookie[1];
     }
 
@@ -55,15 +53,15 @@ export class Utils {
   }
 
   public static merge(defaultValues:Object, values:Object) {
-    var result:Object = {};
+    let result:Object = {};
 
-    for (var key in defaultValues || {}) {
+    for (let key in defaultValues || {}) {
       if (!!defaultValues[key]) {
         result[key] = defaultValues[key];
       }
     }
 
-    for (var key in values || {}) {
+    for (let key in values || {}) {
       if (!!values[key]) {
         result[key] = values[key];
       }
@@ -77,8 +75,8 @@ export class Utils {
       return null;
     }
 
-    var versionRegex = /(v?((\d+)\.(\d+)(\.(\d+))?)(?:-([\dA-Za-z\-]+(?:\.[\dA-Za-z\-]+)*))?(?:\+([\dA-Za-z\-]+(?:\.[\dA-Za-z\-]+)*))?)/;
-    var matches = versionRegex.exec(source);
+    let versionRegex = /(v?((\d+)\.(\d+)(\.(\d+))?)(?:-([\dA-Za-z\-]+(?:\.[\dA-Za-z\-]+)*))?(?:\+([\dA-Za-z\-]+(?:\.[\dA-Za-z\-]+)*))?)/;
+    let matches = versionRegex.exec(source);
     if (matches && matches.length > 0) {
       return matches[0];
     }
@@ -91,14 +89,14 @@ export class Utils {
       return null;
     }
 
-    var pairs:string[] = query.split('&');
+    let pairs:string[] = query.split('&');
     if (pairs.length === 0) {
       return null;
     }
 
-    var result:Object = {};
-    for (var index = 0; index < pairs.length; index++) {
-      var pair = pairs[index].split('=');
+    let result:Object = {};
+    for (let index = 0; index < pairs.length; index++) {
+      let pair = pairs[index].split('=');
       result[decodeURIComponent(pair[0])] = decodeURIComponent(pair[1]);
     }
 
@@ -115,41 +113,44 @@ export class Utils {
         return false;
       }
 
-      var trim = /^[\s\uFEFF\xA0]+|[\s\uFEFF\xA0]+$/g;
+      let trim = /^[\s\uFEFF\xA0]+|[\s\uFEFF\xA0]+$/g;
       pattern = pattern.toLowerCase().replace(trim, '');
       value = value.toLowerCase().replace(trim, '');
 
       if (pattern.length <= 0) {
         return false;
       }
 
-      var startsWithWildcard:boolean = pattern[0] === '*';
+      let startsWithWildcard:boolean = pattern[0] === '*';
       if (startsWithWildcard) {
         pattern = pattern.slice(1);
       }
 
-      var endsWithWildcard:boolean = pattern[pattern.length - 1] === '*';
+      let endsWithWildcard:boolean = pattern[pattern.length - 1] === '*';
       if (endsWithWildcard) {
         pattern = pattern.substring(0, pattern.length - 1);
       }
 
-      if (startsWithWildcard && endsWithWildcard)
+      if (startsWithWildcard && endsWithWildcard) {
         return value.indexOf(pattern) !== -1;
+      }
 
-      if (startsWithWildcard)
+      if (startsWithWildcard) {
         return value.lastIndexOf(pattern) === (value.length - pattern.length);
+      }
 
-      if (endsWithWildcard)
+      if (endsWithWildcard) {
         return value.indexOf(pattern) === 0;
+      }
 
       return value === pattern;
     }
 
-    function stringifyImpl(data:any, exclusions:string[]): string {
-      var cache:string[] = [];
-      return JSON.stringify(data, function(key:string, value:any) {
-        for (var index = 0; index < (exclusions || []).length; index++) {
-          if (checkForMatch(exclusions[index], key)){
+    function stringifyImpl(obj:any, excludedKeys:string[]): string {
+      let cache:string[] = [];
+      return JSON.stringify(obj, function(key:string, value:any) {
+        for (let index = 0; index < (excludedKeys || []).length; index++) {
+          if (checkForMatch(excludedKeys[index], key)) {
             return;
           }
         }
@@ -168,8 +169,8 @@ export class Utils {
     }
 
     if (({}).toString.call(data) === '[object Array]') {
-      var result = [];
-      for (var index = 0; index < data.length; index++) {
+      let result = [];
+      for (let index = 0; index < data.length; index++) {
         result[index] = JSON.parse(stringifyImpl(data[index], exclusions || []));
       }