Turned on more linting rules + fixes

Author: niemyjski

.eslintrc.js

@@ -38,21 +38,11 @@ module.exports = {
     "example"
   ],
   rules: {
-    // TODO: Fix rule errors.
-    "@typescript-eslint/explicit-module-boundary-types": "off",
-    "@typescript-eslint/no-empty-function": "off",
-    "@typescript-eslint/no-explicit-any": "off",
-    "@typescript-eslint/no-for-in-array": "off",
     "@typescript-eslint/no-inferrable-types": "off",
-    "@typescript-eslint/no-unused-vars": "off",
     "@typescript-eslint/no-unsafe-assignment": "off",
     "@typescript-eslint/no-unsafe-call": "off",
     "@typescript-eslint/no-unsafe-member-access": "off",
     "@typescript-eslint/no-unsafe-return": "off",
-    "@typescript-eslint/no-var-requires": "off",
     "@typescript-eslint/restrict-plus-operands": "off",
-    "@typescript-eslint/restrict-template-expressions": "off",
-    "no-undef": "off",
-    "no-var": "off"
   }
 };

packages/browser/src/plugins/BrowserGlobalHandlerPlugin.ts

@@ -4,7 +4,7 @@ import {
   PluginContext
 } from "@exceptionless/core";
 
-declare let $: (document: Document) => { (): any; new(): any; ajaxError: { (document: (event: Event, xhr: { responseText: string; status: number; }, settings: { data: unknown; url: string; }, error: string) => void): void; new(): any; }; };
+declare let $: (document: Document) => { ajaxError: { (document: (event: Event, xhr: { responseText: string; status: number; }, settings: { data: unknown; url: string; }, error: string) => void): void; }; };
 
 export class BrowserGlobalHandlerPlugin implements IEventPlugin {
   public priority: number = 100;
@@ -28,7 +28,7 @@ export class BrowserGlobalHandlerPlugin implements IEventPlugin {
       let error = event.reason;
       try {
         // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
-        const reason = (<any>event).detail?.reason;
+        const reason = (<{ detail?: { reason: string} }>event).detail?.reason;
         if (reason) {
           error = reason;
         }
@@ -62,7 +62,7 @@ export class BrowserGlobalHandlerPlugin implements IEventPlugin {
   private getError(event: ErrorEvent): Error {
     const { error, message, filename, lineno, colno } = event;
     if (typeof error === "object") {
-      return error;
+      return error as Error;
     }
 
     let name: string = "Error";
@@ -71,7 +71,7 @@ export class BrowserGlobalHandlerPlugin implements IEventPlugin {
       const errorNameRegex: RegExp = /^(?:[Uu]ncaught (?:exception: )?)?(?:((?:Aggregate|Eval|Internal|Range|Reference|Syntax|Type|URI|)Error): )?(.*)$/i;
       const regexResult = errorNameRegex.exec(msg);
       if (regexResult) {
-        const [_, errorName, errorMessage] = regexResult;
+        const [, errorName, errorMessage] = regexResult;
         if (errorName) {
           name = errorName;
         }
@@ -83,7 +83,7 @@ export class BrowserGlobalHandlerPlugin implements IEventPlugin {
 
     const ex = new Error(msg || "Script error.");
     ex.name = name;
-    ex.stack = `at ${filename || ""}:${!isNaN(lineno) ? lineno : 0}${!isNaN(colno) ? ":" + colno : ""}`;
+    ex.stack = `at ${filename || ""}:${!isNaN(lineno) ? lineno : 0}${!isNaN(colno) ? `:${colno}` : ""}`;
     return ex;
   }
 }

packages/core/src/plugins/default/EventExclusionPlugin.ts

@@ -95,8 +95,7 @@ export class EventExclusionPlugin implements IEventPlugin {
     const sortedKeys = Object.keys(configSettings).sort((a, b) =>
       b.length - a.length || a.localeCompare(b)
     );
-    for (const index in sortedKeys) {
-      const key: string = sortedKeys[index];
+    for (const key of sortedKeys) {
       if (!startsWith(key.toLowerCase(), sourcePrefix)) {
         continue;
       }

packages/core/src/storage/InMemoryStorage.ts

@@ -3,8 +3,6 @@ import { IStorage } from "./IStorage.js";
 export class InMemoryStorage implements IStorage {
   private items = new Map<string, string>();
 
-  constructor() { }
-
   public length(): Promise<number> {
     return Promise.resolve(this.items.size);
   }

packages/core/src/submission/DefaultSubmissionClient.ts

@@ -48,7 +48,7 @@ export class DefaultSubmissionClient implements ISubmissionClient {
   }
 
   public async submitHeartbeat(sessionIdOrUserId: string, closeSession: boolean): Promise<Response<void>> {
-    const url = `${this.config.heartbeatServerUrl}/api/v2/events/session/heartbeat?id=${sessionIdOrUserId}&close=${closeSession}`;
+    const url = `${this.config.heartbeatServerUrl}/api/v2/events/session/heartbeat?id=${sessionIdOrUserId}&close=${closeSession + ""}`;
     return await this.apiFetch<void>(url, {
       method: "GET",
     });

packages/core/test/Utils.test.ts

@@ -61,17 +61,17 @@ describe("Utils", () => {
     });
 
     test("circular reference", () => {
-      const aFoo: any = { a: "foo" };
+      const aFoo: { a: string, b?: unknown } = { a: "foo" };
       aFoo.b = aFoo;
 
       expect(stringify(aFoo)).toBe("{\"a\":\"foo\"}");
       expect(stringify([{ one: aFoo, two: aFoo }])).toBe("[{\"one\":{\"a\":\"foo\"}}]");
     });
 
     test.skip("deep circular reference", () => {
-      const a: any = {};
-      const b: any = {};
-      const c: any = { d: "test" };
+      const a: { b?: unknown } = {};
+      const b: { c?: unknown } = {};
+      const c: { a?: unknown, d: string } = { d: "test" };
 
       a.b = b;
       b.c = c;
@@ -84,7 +84,7 @@ describe("Utils", () => {
     });
 
     describe("should behave like JSON.stringify", () => {
-      [new Date(), 1, true, null, undefined, () => { }, user].forEach((value) => {
+      [new Date(), 1, true, null, undefined, () => { return undefined; }, user].forEach((value) => {
         test("for " + typeof (value), () => {
           expect(stringify(value)).toBe(JSON.stringify(value));
         });

packages/core/test/storage/StorageTestBase.ts

@@ -5,7 +5,7 @@ export function describeStorage(
   storageFactory: () => IStorage,
   afterEachCallback?: () => void,
   beforeEachCallback?: () => void
-) {
+): void {
   describe(name, () => {
     if (beforeEachCallback) {
       beforeEach(beforeEachCallback);

packages/core/test/submission/TestSubmissionClient.ts

@@ -1,11 +1,10 @@
 import { Response } from "../../src/submission/Response.js";
 import {
-  FetchOptions,
   DefaultSubmissionClient
 } from "../../src/submission/DefaultSubmissionClient.js";
 
 export class TestSubmissionClient extends DefaultSubmissionClient {
-  public apiFetch<T>(_url: string, _options: FetchOptions): Promise<Response<T>> {
+  public apiFetch<T>(): Promise<Response<T>> {
     throw new Error("Missing mock");
   }
 }

packages/node/src/plugins/NodeGlobalHandlerPlugin.ts

@@ -22,7 +22,7 @@ export class NodeGlobalHandlerPlugin implements IEventPlugin {
       void this._client?.submitUnhandledException(error, "uncaughtException");
     });
 
-    process.addListener("unhandledRejection", (reason: unknown | null | undefined, _: Promise<any>) => {
+    process.addListener("unhandledRejection", (reason: unknown | null | undefined) => {
       void this._client?.submitUnhandledException(<Error>reason, "unhandledRejection");
     });