Fixes #67: Preserve event type if event has error

Author: niemyjski

example/browser/index.html

@@ -23,6 +23,7 @@ <h1>Log Submission</h1>
     <button class="submit-log" data-level="info">Submit info log event</button>
     <button class="submit-log" data-level="warn">Submit warn log event</button>
     <button class="submit-log" data-level="error">Submit error log event</button>
+    <button id="submit-error-log-with-error">Submit error log event with real error</button>
 
     <h1>Diagnostics</h1>
     <button id="config-settings-log">Log Client Configuration Settings (settings sent from server)</button>

example/browser/index.js

@@ -45,6 +45,14 @@ document.addEventListener("DOMContentLoaded", () => {
     });
   }
 
+  document
+    .querySelector("#submit-error-log-with-error")
+    .addEventListener("click", async () => {
+      const builder = Exceptionless.createLog("Button Click", "Error Log with Error");
+      builder.context.setException(new Error("test"));
+      await builder.submit();
+    });
+
   document
     .querySelector("#throw-custom-error")
     .addEventListener("click", () => {

packages/browser/src/plugins/BrowserErrorPlugin.ts

@@ -22,7 +22,9 @@ export class BrowserErrorPlugin implements IEventPlugin {
   public async run(context: EventPluginContext): Promise<void> {
     const exception = context.eventContext.getException();
     if (exception) {
-      context.event.type = "error";
+      if (!context.event.type) {
+        context.event.type = "error";
+      }
 
       if (context.event.data && !context.event.data[KnownEventDataKeys.Error]) {
         const result = await this.parse(exception);

packages/core/src/plugins/default/SimpleErrorPlugin.ts

@@ -31,7 +31,9 @@ export class SimpleErrorPlugin implements IEventPlugin {
   public async run(context: EventPluginContext): Promise<void> {
     const exception = context.eventContext.getException();
     if (exception) {
-      context.event.type = "error";
+      if (!context.event.type) {
+        context.event.type = "error";
+      }
 
       if (context.event.data && !context.event.data[KnownEventDataKeys.SimpleError]) {
         const error = <SimpleError>{

packages/node/src/plugins/NodeErrorPlugin.ts

@@ -18,7 +18,9 @@ export class NodeErrorPlugin implements IEventPlugin {
   public async run(context: EventPluginContext): Promise<void> {
     const exception = context.eventContext.getException();
     if (exception) {
-      context.event.type = "error";
+      if (!context.event.type) {
+        context.event.type = "error";
+      }
 
       if (context.event.data && !context.event.data[KnownEventDataKeys.Error]) {
         const result = await this.parse(exception);