Fixed issue with two error plugins getting registered for browser target.

Author: niemyjski

example/vue/src/main.js

@@ -25,7 +25,7 @@ Exceptionless.startup((c) => {
     },
   };
 
-  c.defaultTags.push("Example", "JavaScript");
+  c.defaultTags.push("Example", "JavaScript", "Vue");
 });
 
 const app = createApp(App);

packages/browser/src/BrowserExceptionlessClient.ts

@@ -17,11 +17,9 @@ export class BrowserExceptionlessClient extends ExceptionlessClient {
       config.addPlugin(new BrowserModuleInfoPlugin());
       config.addPlugin(new BrowserRequestInfoPlugin());
       config.addPlugin(new BrowserErrorPlugin());
+      config.removePlugin(new SimpleErrorPlugin());
     }
 
     await super.startup(configurationOrApiKey);
-    if (configurationOrApiKey && !this._initialized) {
-      config.removePlugin(new SimpleErrorPlugin());
-    }
   }
 }

packages/core/src/ExceptionlessClient.ts

@@ -19,7 +19,6 @@ export class ExceptionlessClient {
   public async startup(configurationOrApiKey?: (config: Configuration) => void | string): Promise<void> {
     if (configurationOrApiKey && !this._initialized) {
       this._initialized = true;
-      EventPluginManager.addDefaultPlugins(this.config);
 
       if (typeof configurationOrApiKey === "string") {
         this.config.apiKey = configurationOrApiKey;

packages/core/src/configuration/Configuration.ts

@@ -6,6 +6,7 @@ import { NullLog } from "../logging/NullLog.js";
 import { UserInfo } from "../models/data/UserInfo.js";
 import { HeartbeatPlugin } from "../plugins/default/HeartbeatPlugin.js";
 import { EventPluginContext } from "../plugins/EventPluginContext.js";
+import { EventPluginManager } from "../plugins/EventPluginManager.js";
 import { IEventPlugin } from "../plugins/IEventPlugin.js";
 import { DefaultEventQueue } from "../queue/DefaultEventQueue.js";
 import { IEventQueue } from "../queue/IEventQueue.js";
@@ -27,6 +28,8 @@ export class Configuration {
       queue: new DefaultEventQueue(this),
       submissionClient: new DefaultSubmissionClient(this),
     };
+
+    EventPluginManager.addDefaultPlugins(this);
   }
 
   /**

packages/core/test/ExceptionlessClient.test.ts

@@ -12,16 +12,20 @@ describe("ExceptionlessClient", () => {
     const client = new ExceptionlessClient();
     client.config.apiKey = "UNIT_TEST_API_KEY";
 
+    expect(client.config.plugins).not.toBeNull();
+    while (client.config.plugins.length > 0) {
+      client.config.removePlugin(client.config.plugins[0]);
+    }
+
     const { lastReferenceIdManager } = client.config.services;
     expect(lastReferenceIdManager.getLast()).toBeNull();
 
     let context = await client.submitException(error);
     expect(context.event.reference_id).toBeUndefined();
     expect(lastReferenceIdManager.getLast()).toBeNull();
 
-    const numberOfPlugins = client.config.plugins.length;
     client.config.addPlugin(new ReferenceIdPlugin());
-    expect(client.config.plugins.length).toBe(numberOfPlugins + 1);
+    expect(client.config.plugins.length).toBe(1);
 
     context = await client.submitException(error);
     expect(context.event.reference_id).not.toBeUndefined();

packages/node/src/NodeExceptionlessClient.ts

@@ -37,12 +37,9 @@ export class NodeExceptionlessClient extends ExceptionlessClient {
       config.addPlugin(new NodeRequestInfoPlugin());
       config.addPlugin(new NodeWrapFunctions());
       config.addPlugin(new NodeErrorPlugin());
+      config.removePlugin(new SimpleErrorPlugin());
     }
 
     await super.startup(configurationOrApiKey);
-
-    if (configurationOrApiKey && !this._initialized) {
-      config.removePlugin(new SimpleErrorPlugin());
-    }
   }
 }