Skip to content

Commit c016504

Browse files
authored
#54: Remove dependencies from JAR (#55)
1 parent 7f53cc7 commit c016504

File tree

11 files changed

+131
-129
lines changed

11 files changed

+131
-129
lines changed

.gitattributes

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
*.sh text eol=lf
22

33
.github/workflows/release_droid_upload_github_release_assets.yml linguist-generated=true
4-
.github/workflows/release_droid_prepare_original_checksum.yml linguist-generated=true
5-
.github/workflows/release_droid_print_quick_checksum.yml linguist-generated=true
6-
.github/workflows/ci-build-next-java.yml linguist-generated=true
7-
.github/workflows/broken_links_checker.yml linguist-generated=true
8-
.github/workflows/dependencies_check.yml linguist-generated=true
9-
.settings/org.eclipse.jdt.core.prefs linguist-generated=true
10-
dependencies.md linguist-generated=true
11-
pk_generated_parent.pom linguist-generated=true
12-
doc/changes/changelog.md linguist-generated=true
4+
.github/workflows/release_droid_prepare_original_checksum.yml linguist-generated=true
5+
.github/workflows/release_droid_print_quick_checksum.yml linguist-generated=true
6+
.github/workflows/ci-build.yml linguist-generated=true
7+
.github/workflows/ci-build-next-java.yml linguist-generated=true
8+
.github/workflows/broken_links_checker.yml linguist-generated=true
9+
.github/workflows/dependencies_check.yml linguist-generated=true
10+
.settings/org.eclipse.jdt.core.prefs linguist-generated=true
11+
dependencies.md linguist-generated=true
12+
pk_generated_parent.pom linguist-generated=true
13+
doc/changes/changelog.md linguist-generated=true
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
name: CI Build Scala Linter
2+
on:
3+
push:
4+
branches:
5+
- main
6+
pull_request:
7+
8+
jobs:
9+
scala-linter:
10+
runs-on: ubuntu-latest
11+
concurrency:
12+
group: ${{ github.workflow }}-${{ github.ref }}
13+
cancel-in-progress: true
14+
steps:
15+
- name: Checkout the repository
16+
uses: actions/checkout@v4
17+
with:
18+
fetch-depth: 0
19+
- name: Set up JDK 11
20+
uses: actions/setup-java@v4
21+
with:
22+
distribution: "temurin"
23+
java-version: 11
24+
cache: "maven"
25+
- name: Run scalafix linting
26+
run: |
27+
mvn --batch-mode clean compile test scalafix:scalafix \
28+
-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn \
29+
-DtrimStackTrace=false

.github/workflows/ci-build.yml

Lines changed: 18 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/release_droid_release_on_maven_central.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,15 @@ jobs:
88
runs-on: ubuntu-latest
99
steps:
1010
- name: Checkout the repository
11-
uses: actions/checkout@v3
11+
uses: actions/checkout@v4
1212
with:
1313
fetch-depth: 0
1414
- name: Set up Maven Central Repository
15-
uses: actions/setup-java@v3
15+
uses: actions/setup-java@v4
1616
with:
17-
distribution: 'temurin'
17+
distribution: "temurin"
1818
java-version: 11
19-
cache: 'maven'
19+
cache: "maven"
2020
server-id: ossrh
2121
server-username: MAVEN_USERNAME
2222
server-password: MAVEN_PASSWORD
@@ -33,4 +33,4 @@ jobs:
3333
MAVEN_PASSWORD: ${{ secrets.OSSRH_PASSWORD }}
3434
MAVEN_GPG_PASSPHRASE: ${{ secrets.OSSRH_GPG_SECRET_KEY_PASSWORD }}
3535
- name: Remove release pom file
36-
run: rm -rf release-pom.xml
36+
run: rm -rf release-pom.xml

.project-keeper.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,9 @@ sources:
44
modules:
55
- maven_central
66
linkReplacements:
7-
- "LICENSE-exasol-script-api.txt|https://mit-license.org/"
87
- "https://github.com/google/guava/guava|https://github.com/google/guava"
98
- "http://wiki.fasterxml.com/JacksonModuleScala|https://github.com/FasterXML/jackson-module-scala"
109
- "http://nexus.sonatype.org/oss-repository-hosting.html|https://www.scalatest.org/user_guide/using_the_scalatest_maven_plugin"
1110
- "http://nexus.sonatype.org/oss-repository-hosting.html/scalatest-maven-plugin|https://www.scalatest.org/user_guide/using_the_scalatest_maven_plugin"
1211
excludes:
13-
- "E-PK-CORE-18: Outdated content: '.github/workflows/ci-build.yml'"
1412
- "E-PK-CORE-18: Outdated content: '.github/workflows/release_droid_release_on_maven_central.yml'"

dependencies.md

Lines changed: 44 additions & 46 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

doc/changes/changelog.md

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

doc/changes/changes_2.0.0.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# Import Export UDF Common Scala 2.0.0, released 2023-12-06
2+
3+
Code name: Remove dependencies from JAR
4+
5+
## Summary
6+
7+
Previous releases of this project contained all dependencies in the published JAR file (i.e. fat JAR). This project is a library that is used in other projects and should not contain dependencies in the JAR, so we removed them.
8+
9+
## Bugfixes
10+
11+
* #54: Removed dependencies from published JAR
12+
13+
## Dependency Updates
14+
15+
### Plugin Dependency Updates
16+
17+
* Updated `com.exasol:project-keeper-maven-plugin:2.9.16` to `2.9.17`
18+
* Removed `org.apache.maven.plugins:maven-assembly-plugin:3.5.0`
19+
* Updated `org.codehaus.mojo:versions-maven-plugin:2.16.1` to `2.16.2`

pk_generated_parent.pom

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pom.xml

Lines changed: 3 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@
22
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
33
<modelVersion>4.0.0</modelVersion>
44
<artifactId>import-export-udf-common-scala</artifactId>
5-
<version>1.1.2</version>
5+
<version>2.0.0</version>
66
<name>Import Export UDF Common Scala</name>
77
<description>Common import export libraries used in Exasol user defined functions</description>
88
<url>https://github.com/exasol/import-export-udf-common-scala/</url>
99
<parent>
1010
<artifactId>import-export-udf-common-scala-generated-parent</artifactId>
1111
<groupId>com.exasol</groupId>
12-
<version>1.1.2</version>
12+
<version>2.0.0</version>
1313
<relativePath>pk_generated_parent.pom</relativePath>
1414
</parent>
1515
<properties>
@@ -229,31 +229,6 @@
229229
</execution>
230230
</executions>
231231
</plugin>
232-
<plugin>
233-
<groupId>org.apache.maven.plugins</groupId>
234-
<artifactId>maven-assembly-plugin</artifactId>
235-
<version>3.5.0</version>
236-
<configuration>
237-
<descriptors>
238-
<descriptor>src/assembly/all-dependencies.xml</descriptor>
239-
</descriptors>
240-
<appendAssemblyId>false</appendAssemblyId>
241-
<archive>
242-
<manifest>
243-
<addClasspath>true</addClasspath>
244-
</manifest>
245-
</archive>
246-
</configuration>
247-
<executions>
248-
<execution>
249-
<id>make-assembly</id>
250-
<phase>package</phase>
251-
<goals>
252-
<goal>single</goal>
253-
</goals>
254-
</execution>
255-
</executions>
256-
</plugin>
257232
<plugin>
258233
<groupId>org.itsallcode</groupId>
259234
<artifactId>openfasttrace-maven-plugin</artifactId>
@@ -275,7 +250,7 @@
275250
<plugin>
276251
<groupId>com.exasol</groupId>
277252
<artifactId>project-keeper-maven-plugin</artifactId>
278-
<version>2.9.16</version>
253+
<version>2.9.17</version>
279254
<executions>
280255
<execution>
281256
<goals>

0 commit comments

Comments
 (0)