Drop Python 3.4 support (#518)

* Update gitignore

* Drop Python 3.4 support

* Update change log

* Fix typo in changelog

Author: rmk135

.github/workflows/tests-and-linters.yml

@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-18.04
     strategy:
       matrix:
-        python-version: [2.7, 3.4, 3.5, 3.6, 3.7, 3.8, 3.9, pypy2, pypy3]
+        python-version: [2.7, 3.5, 3.6, 3.7, 3.8, 3.9, pypy2, pypy3]
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-python@v2

.gitignore

@@ -36,6 +36,7 @@ reports/
 .cache
 nosetests.xml
 coverage.xml
+.hypothesis/
 
 # Translations
 *.mo
@@ -54,7 +55,7 @@ target/
 .idea/
 
 # Virtualenv
-venv/
+venv*/
 
 # SQLite
 *.db

docs/main/changelog.rst

@@ -13,6 +13,8 @@ Develop
   ``container.wire(modules=["yourapp.module1"])``.
 - Add container wiring configuration ``wiring_config = containers.WiringConfiguration()``.
 - Add support of ``with`` statement for ``container.override_providers()`` method.
+- Drop support of Python 3.4. There are no immediate breaking changes, but Dependency Injector
+  will no longer be tested on Python 3.4 and any bugs will not be fixed.
 - Update documentation and fix typos.
 
 4.36.2

setup.py

@@ -96,7 +96,6 @@
           "Programming Language :: Python :: 2",
           "Programming Language :: Python :: 2.7",
           "Programming Language :: Python :: 3",
-          "Programming Language :: Python :: 3.4",
           "Programming Language :: Python :: 3.5",
           "Programming Language :: Python :: 3.6",
           "Programming Language :: Python :: 3.7",

src/dependency_injector/providers.c

@@ -4743,32 +4743,23 @@ def traverse(*providers, types=None):
 
 
 def isawaitable(obj):
-    """Check if object is a coroutine function.
-
-    Return False for any object in Python 3.4 or below.
-    """
+    """Check if object is a coroutine function."""
     try:
         return inspect.isawaitable(obj)
     except AttributeError:
         return False
 
 
 def iscoroutinefunction(obj):
-    """Check if object is a coroutine function.
-
-    Return False for any object in Python 3.4 or below.
-    """
+    """Check if object is a coroutine function."""
     try:
         return inspect.iscoroutinefunction(obj)
     except AttributeError:
         return False
 
 
 def isasyncgenfunction(obj):
-    """Check if object is an asynchronous generator function.
-
-    Return False for any object in Python 3.4 or below.
-    """
+    """Check if object is an asynchronous generator function."""
     try:
         return inspect.isasyncgenfunction(obj)
     except AttributeError:

src/dependency_injector/providers.pyx

@@ -795,7 +795,6 @@ def tearDown(self):
         os.unlink(self.config_file_1)
         os.unlink(self.config_file_2)
 
-    @unittest.skipIf(sys.version_info[:2] == (3, 4), "PyYAML does not support Python 3.4")
     def test(self):
         self.config.from_yaml(self.config_file_1)
 
@@ -805,7 +804,6 @@ def test(self):
         self.assertEqual(self.config.section2(), {"value2": 2})
         self.assertEqual(self.config.section2.value2(), 2)
 
-    @unittest.skipIf(sys.version_info[:2] == (3, 4), "PyYAML does not support Python 3.4")
     def test_merge(self):
         self.config.from_yaml(self.config_file_1)
         self.config.from_yaml(self.config_file_2)
@@ -833,45 +831,37 @@ def test_merge(self):
         self.assertEqual(self.config.section3(), {"value3": 3})
         self.assertEqual(self.config.section3.value3(), 3)
 
-    @unittest.skipIf(sys.version_info[:2] == (3, 4), "PyYAML does not support Python 3.4")
     def test_file_does_not_exist(self):
         self.config.from_yaml("./does_not_exist.yml")
         self.assertEqual(self.config(), {})
 
-    @unittest.skipIf(sys.version_info[:2] == (3, 4), "PyYAML does not support Python 3.4")
     def test_file_does_not_exist_strict_mode(self):
         self.config = providers.Configuration(strict=True)
         with self.assertRaises(IOError):
             self.config.from_yaml("./does_not_exist.yml")
 
-    @unittest.skipIf(sys.version_info[:2] == (3, 4), "PyYAML does not support Python 3.4")
     def test_option_file_does_not_exist(self):
         self.config.option.from_yaml("./does_not_exist.yml")
         self.assertIsNone(self.config.option())
 
-    @unittest.skipIf(sys.version_info[:2] == (3, 4), "PyYAML does not support Python 3.4")
     def test_option_file_does_not_exist_strict_mode(self):
         self.config = providers.Configuration(strict=True)
         with self.assertRaises(IOError):
             self.config.option.from_yaml("./does_not_exist.yml")
 
-    @unittest.skipIf(sys.version_info[:2] == (3, 4), "PyYAML does not support Python 3.4")
     def test_required_file_does_not_exist(self):
         with self.assertRaises(IOError):
             self.config.from_yaml("./does_not_exist.yml", required=True)
 
-    @unittest.skipIf(sys.version_info[:2] == (3, 4), "PyYAML does not support Python 3.4")
     def test_required_option_file_does_not_exist(self):
         with self.assertRaises(IOError):
             self.config.option.from_yaml("./does_not_exist.yml", required=True)
 
-    @unittest.skipIf(sys.version_info[:2] == (3, 4), "PyYAML does not support Python 3.4")
     def test_not_required_file_does_not_exist_strict_mode(self):
         self.config = providers.Configuration(strict=True)
         self.config.from_yaml("./does_not_exist.yml", required=False)
         self.assertEqual(self.config(), {})
 
-    @unittest.skipIf(sys.version_info[:2] == (3, 4), "PyYAML does not support Python 3.4")
     def test_not_required_option_file_does_not_exist_strict_mode(self):
         self.config = providers.Configuration(strict=True)
         self.config.option.from_yaml("./does_not_exist.yml", required=False)
@@ -943,7 +933,6 @@ def tearDown(self):
         os.environ.pop("CONFIG_TEST_PATH", None)
         os.unlink(self.config_file)
 
-    @unittest.skipIf(sys.version_info[:2] == (3, 4), "PyYAML does not support Python 3.4")
     def test_env_variable_interpolation(self):
         self.config.from_yaml(self.config_file)
 
@@ -966,7 +955,6 @@ def test_env_variable_interpolation(self):
         self.assertEqual(self.config.section1.value1(), "test-value")
         self.assertEqual(self.config.section1.value2(), "test-path/path")
 
-    @unittest.skipIf(sys.version_info[:2] == (3, 4), "PyYAML does not support Python 3.4")
     def test_missing_envs_not_required(self):
         del os.environ["CONFIG_TEST_ENV"]
         del os.environ["CONFIG_TEST_PATH"]
@@ -992,7 +980,6 @@ def test_missing_envs_not_required(self):
         self.assertIsNone(self.config.section1.value1())
         self.assertEqual(self.config.section1.value2(), "/path")
 
-    @unittest.skipIf(sys.version_info[:2] == (3, 4), "PyYAML does not support Python 3.4")
     def test_missing_envs_required(self):
         with open(self.config_file, "w") as config_file:
             config_file.write(
@@ -1008,7 +995,6 @@ def test_missing_envs_required(self):
             "Missing required environment variable \"UNDEFINED\"",
         )
 
-    @unittest.skipIf(sys.version_info[:2] == (3, 4), "PyYAML does not support Python 3.4")
     def test_missing_envs_strict_mode(self):
         with open(self.config_file, "w") as config_file:
             config_file.write(
@@ -1025,7 +1011,6 @@ def test_missing_envs_strict_mode(self):
             "Missing required environment variable \"UNDEFINED\"",
         )
 
-    @unittest.skipIf(sys.version_info[:2] == (3, 4), "PyYAML does not support Python 3.4")
     def test_option_missing_envs_not_required(self):
         del os.environ["CONFIG_TEST_ENV"]
         del os.environ["CONFIG_TEST_PATH"]
@@ -1051,7 +1036,6 @@ def test_option_missing_envs_not_required(self):
         self.assertIsNone(self.config.option.section1.value1())
         self.assertEqual(self.config.option.section1.value2(), "/path")
 
-    @unittest.skipIf(sys.version_info[:2] == (3, 4), "PyYAML does not support Python 3.4")
     def test_option_missing_envs_required(self):
         with open(self.config_file, "w") as config_file:
             config_file.write(
@@ -1067,7 +1051,6 @@ def test_option_missing_envs_required(self):
             "Missing required environment variable \"UNDEFINED\"",
         )
 
-    @unittest.skipIf(sys.version_info[:2] == (3, 4), "PyYAML does not support Python 3.4")
     def test_option_missing_envs_strict_mode(self):
         with open(self.config_file, "w") as config_file:
             config_file.write(
@@ -1084,7 +1067,6 @@ def test_option_missing_envs_strict_mode(self):
             "Missing required environment variable \"UNDEFINED\"",
         )
 
-    @unittest.skipIf(sys.version_info[:2] == (3, 4), "PyYAML does not support Python 3.4")
     def test_default_values(self):
         os.environ["DEFINED"] = "defined"
         self.addCleanup(os.environ.pop, "DEFINED")
@@ -1108,7 +1090,6 @@ def test_default_values(self):
             },
         )
 
-    @unittest.skipIf(sys.version_info[:2] == (3, 4), "PyYAML does not support Python 3.4")
     def test_option_env_variable_interpolation(self):
         self.config.option.from_yaml(self.config_file)
 
@@ -1131,7 +1112,6 @@ def test_option_env_variable_interpolation(self):
         self.assertEqual(self.config.option.section1.value1(), "test-value")
         self.assertEqual(self.config.option.section1.value2(), "test-path/path")
 
-    @unittest.skipIf(sys.version_info[:2] == (3, 4), "PyYAML does not support Python 3.4")
     def test_env_variable_interpolation_custom_loader(self):
         self.config.from_yaml(self.config_file, loader=yaml.UnsafeLoader)
 
@@ -1145,7 +1125,6 @@ def test_env_variable_interpolation_custom_loader(self):
         self.assertEqual(self.config.section1.value1(), "test-value")
         self.assertEqual(self.config.section1.value2(), "test-path/path")
 
-    @unittest.skipIf(sys.version_info[:2] == (3, 4), "PyYAML does not support Python 3.4")
     def test_option_env_variable_interpolation_custom_loader(self):
         self.config.option.from_yaml(self.config_file, loader=yaml.UnsafeLoader)
 

tests/unit/providers/test_configuration_py2_py3.py

@@ -1,6 +1,6 @@
 [tox]
 envlist=
-    coveralls, pylint, flake8, pydocstyle, 2.7, 3.4, 3.5, 3.6, 3.7, 3.8, 3.9, pypy2, pypy3
+    coveralls, pylint, flake8, pydocstyle, 2.7, 3.5, 3.6, 3.7, 3.8, 3.9, pypy2, pypy3
 
 [testenv]
 deps=
@@ -43,14 +43,6 @@ extras=
 commands=
     python -m unittest discover -s tests/unit -p test_*_py2_py3.py
 
-[testenv:3.4]
-deps=
-    contextvars
-extras=
-    flask
-commands=
-    python -m unittest discover -s tests/unit -p test_*_py3.py
-
 [testenv:3.5]
 deps=
     contextvars