fix: type propogation through provided (#733)

philipbjorge · GonzaGonza · web-flow · commit 00326e9a22b1 · 2025-01-08T13:31:00.000+02:00
Co-authored-by: Gonzalo Martinez &lt;gonzarmv@gmail.com&gt;
diff --git a/src/dependency_injector/providers.pyi b/src/dependency_injector/providers.pyi
@@ -69,7 +69,7 @@ class Provider(Generic[T]):
     @property
     def provider(self) -> Provider: ...
     @property
-    def provided(self) -> ProvidedInstance: ...
+    def provided(self) -> ProvidedInstance[T]: ...
     def enable_async_mode(self) -> None: ...
     def disable_async_mode(self) -> None: ...
     def reset_async_mode(self) -> None: ...
diff --git a/tests/typing/callable.py b/tests/typing/callable.py
@@ -34,7 +34,7 @@ def create(cls) -> Animal:
 
 # Test 5: to check the provided instance interface
 provider5 = providers.Callable(Animal)
-provided5: providers.ProvidedInstance = provider5.provided
+provided5: Animal = provider5.provided()
 attr_getter5: providers.AttributeGetter = provider5.provided.attr
 item_getter5: providers.ItemGetter = provider5.provided["item"]
 method_caller: providers.MethodCaller = provider5.provided.method.call(123, arg=324)
diff --git a/tests/typing/dict.py b/tests/typing/dict.py
@@ -34,7 +34,7 @@
     a1=providers.Factory(object),
     a2=providers.Factory(object),
 )
-provided5: providers.ProvidedInstance = provider5.provided
+provided5: dict[Any, Any] = provider5.provided()
 
 
 # Test 6: to check the return type with await
diff --git a/tests/typing/factory.py b/tests/typing/factory.py
@@ -37,7 +37,7 @@ def create(cls) -> Animal:
 
 # Test 5: to check the provided instance interface
 provider5 = providers.Factory(Animal)
-provided5: providers.ProvidedInstance = provider5.provided
+provided5: Animal = provider5.provided()
 attr_getter5: providers.AttributeGetter = provider5.provided.attr
 item_getter5: providers.ItemGetter = provider5.provided["item"]
 method_caller5: providers.MethodCaller = provider5.provided.method.call(123, arg=324)
diff --git a/tests/typing/list.py b/tests/typing/list.py
@@ -23,7 +23,7 @@
     providers.Factory(object),
     providers.Factory(object),
 )
-provided3: providers.ProvidedInstance = provider3.provided
+provided3: List[Any] = provider3.provided()
 attr_getter3: providers.AttributeGetter = provider3.provided.attr
 item_getter3: providers.ItemGetter = provider3.provided["item"]
 method_caller3: providers.MethodCaller = provider3.provided.method.call(123, arg=324)
diff --git a/tests/typing/object.py b/tests/typing/object.py
@@ -9,7 +9,7 @@
 
 # Test 2: to check the provided instance interface
 provider2 = providers.Object(int)
-provided2: providers.ProvidedInstance = provider2.provided
+provided2: Type[int] = provider2.provided()
 attr_getter2: providers.AttributeGetter = provider2.provided.attr
 item_getter2: providers.ItemGetter = provider2.provided["item"]
 method_caller2: providers.MethodCaller = provider2.provided.method.call(123, arg=324)
diff --git a/tests/typing/provider.py b/tests/typing/provider.py
@@ -3,7 +3,7 @@
 
 # Test 1: to check .provided attribute
 provider1: providers.Provider[int] = providers.Object(1)
-provided: providers.ProvidedInstance = provider1.provided
+provided: int = provider1.provided()
 
 # Test 2: to check async mode API
 provider2: providers.Provider = providers.Provider()
diff --git a/tests/typing/singleton.py b/tests/typing/singleton.py
@@ -37,7 +37,7 @@ def create(cls) -> Animal:
 
 # Test 5: to check the provided instance interface
 provider5 = providers.Singleton(Animal)
-provided5: providers.ProvidedInstance = provider5.provided
+provided5: Animal = provider5.provided()
 attr_getter5: providers.AttributeGetter = provider5.provided.attr
 item_getter5: providers.ItemGetter = provider5.provided["item"]
 method_caller5: providers.MethodCaller = provider5.provided.method.call(123, arg=324)

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@`
`34`	`34`	`a1=providers.Factory(object),`
`35`	`35`	`a2=providers.Factory(object),`
`36`	`36`	`)`
`37`		`-provided5: providers.ProvidedInstance = provider5.provided`
	`37`	`+provided5: dict[Any, Any] = provider5.provided()`
`38`	`38`
`39`	`39`
`40`	`40`	`# Test 6: to check the return type with await`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@`
`23`	`23`	`providers.Factory(object),`
`24`	`24`	`providers.Factory(object),`
`25`	`25`	`)`
`26`		`-provided3: providers.ProvidedInstance = provider3.provided`
	`26`	`+provided3: List[Any] = provider3.provided()`
`27`	`27`	`attr_getter3: providers.AttributeGetter = provider3.provided.attr`
`28`	`28`	`item_getter3: providers.ItemGetter = provider3.provided["item"]`
`29`	`29`	`method_caller3: providers.MethodCaller = provider3.provided.method.call(123, arg=324)`