PR feedback

Author: hwwhww

eth/beacon/state_machines/base.py

@@ -385,6 +385,11 @@ def compute_cycle_transitions(
                 block,
             )
 
+            # TODO: it's a STUB before we implement compute_per_cycle_transition
+            crystallized_state = crystallized_state.copy(
+                last_state_recalc=crystallized_state.last_state_recalc + cls.config.CYCLE_LENGTH
+            )
+
             if cls.ready_for_dynasty_transition(crystallized_state, block):
                 crystallized_state = cls.compute_dynasty_transition(
                     crystallized_state,
@@ -409,10 +414,10 @@ def compute_per_cycle_transition(
     # Crosslinks
     #
     @classmethod
-    def compute_crosslinks(cls,
-                           crystallized_state: CrystallizedState,
-                           active_state: ActiveState,
-                           block: BaseBeaconBlock) -> Tuple['CrosslinkRecord', ...]:
+    def update_crosslinks(cls,
+                          crystallized_state: CrystallizedState,
+                          active_state: ActiveState,
+                          block: BaseBeaconBlock) -> Tuple['CrosslinkRecord', ...]:
         # TODO
         return ()
 

tests/beacon/state_machines/test_state_machines.py

@@ -95,3 +95,46 @@ def test_import_block_one(fixture_sm_class,
         [ZERO_HASH32] * (sm.config.CYCLE_LENGTH * 2 - 1) + [genesis_block.hash]
     )
     assert active_state.recent_block_hashes == expect
+
+
+@pytest.mark.parametrize(
+    (
+        'num_validators,cycle_length,min_committee_size,shard_count,'
+        'block_slot,'
+        'prev_last_state_recalculation_slot,'
+        'post_last_state_recalculation_slot'
+    ),
+    [
+        (1000, 20, 10, 100, 1, 0, 0),  # no cycle transition
+        (1000, 20, 10, 100, 20, 0, 20),  # transition: 0 + cycle_length
+        (1000, 20, 10, 100, 60, 5, 45),  # transition: 5 + 2 * cycle_length
+        (1000, 20, 10, 100, 61, 45, 45),  # no cycle transition
+    ]
+)
+def test_compute_cycle_transitions(fixture_sm_class,
+                                   initial_chaindb,
+                                   genesis_block,
+                                   genesis_crystallized_state,
+                                   genesis_active_state,
+                                   block_slot,
+                                   prev_last_state_recalculation_slot,
+                                   post_last_state_recalculation_slot):
+    chaindb = initial_chaindb
+
+    block_1_shell = genesis_block.copy(
+        parent_hash=genesis_block.hash,
+        slot_number=genesis_block.slot_number + 1,
+    )
+
+    sm = fixture_sm_class(chaindb, block_1_shell)
+
+    post_crystallized_state, _ = sm.compute_cycle_transitions(
+        genesis_crystallized_state.copy(
+            last_state_recalc=prev_last_state_recalculation_slot,
+        ),
+        genesis_active_state,
+        genesis_block.copy(
+            slot_number=block_slot,
+        )
+    )
+    assert post_crystallized_state.last_state_recalc == post_last_state_recalculation_slot