[WIP] Implement subroutine opcodes

Author: Peppece

eth/vm/logic/flow.py

@@ -72,7 +72,9 @@ def jumpsub(computation: BaseComputation) -> None:
 
     if sub_loc >= code_range_length:
         raise InvalidJumpDestination(
-            "Error: at pc={}, op=JUMPSUB: invalid jump destination".format(computation.code.program_counter))
+            "Error: at pc={}, op=JUMPSUB: invalid jump destination".format(
+                computation.code.program_counter)
+        )
 
     if computation.code.is_valid_opcode(sub_loc):
 
@@ -89,6 +91,8 @@ def returnsub(computation: BaseComputation) -> None:
         ret_loc = computation.rstack_pop1_int()
     except InsufficientStack:
         raise InsufficientStack(
-            "Error: at pc={}, op=RETURNSUB: invalid retsub".format(computation.code.program_counter))
+            "Error: at pc={}, op=RETURNSUB: invalid retsub".format(
+                computation.code.program_counter)
+        )
 
     computation.code.program_counter = ret_loc

eth/vm/rstack.py

@@ -18,10 +18,10 @@
 
 """
 This module simply implements for the return stack the exact same design used for the data stack.
-As this stack must simply push_int or pop1_int any time a subroutine is accessed or left, only those two functions are 
-provided.
-For the same reason, the class RStack doesn't inherit from the abc StackAPI, as it would require to implement all the
-abstract methods defined.
+As this stack must simply push_int or pop1_int any time a subroutine is accessed or left, only
+those two functions are provided.
+For the same reason, the class RStack doesn't inherit from the abc StackAPI, as it would require
+to implement all the abstract methods defined.
 """
 
 

tests/core/opcodes/test_opcodes.py

@@ -1159,7 +1159,7 @@ def test_jumpsub(vm_class, code, expect_gas_used):
     assert comp.get_gas_used() == expect_gas_used
 
 
-@pytest.mark.xfail(reason="invalid subroutines")
+@pytest.mark.xfail(reason="invalid subroutines") # noqa: F811
 @pytest.mark.parametrize(
     'vm_class, code',
     (

tests/core/precompiles/test_bls.py

@@ -1,5 +1,6 @@
 from py_ecc.optimized_bls12_381.optimized_curve import G1, G2, neg, FQ12
-from eth.precompiles.bls import _pairing, _serialize_g2, _serialize_g1
+from eth.precompiles.bls import _pairing, _serialize_g2, _serialize_g1  # noqa: F401
+
 
 def test_pairing_precompile():
     # assert pairing(G1, G2) * pairing(neg(G1), G2) == FQ12.one()
@@ -8,3 +9,5 @@ def test_pairing_precompile():
     serialized_neg_G1 = _serialize_g1(neg(G1))
     input_data = serialized_G1 + serialized_G2 + serialized_neg_G1 + serialized_G2
     assert _pairing(input_data)
+
+# remove "noqa" comment when import starts to be used