chore: refactor code quality issues (#1995)

Author: akshgpt7

.deepsource.toml

@@ -0,0 +1,12 @@
+version = 1
+
+test_patterns = ["tests/**"]
+
+exclude_patterns = ["fixtures/**"]
+
+[[analyzers]]
+name = "python"
+enabled = true
+
+  [analyzers.meta]
+  runtime_version = "3.x.x"

eth/_utils/blake2/coders.py

@@ -55,6 +55,6 @@ def _get_64_bit_little_endian_words(compact_bytes: bytes) -> Iterable[int]:
             f"{len(remaining_bytes)}"
         )
 
-    while len(remaining_bytes):
+    while remaining_bytes:
         word, remaining_bytes = remaining_bytes[:8], remaining_bytes[8:]
         yield to_int(bytes(reversed(word)))

eth/_utils/transactions.py

@@ -37,10 +37,7 @@
 
 
 def is_eip_155_signed_transaction(transaction: BaseTransaction) -> bool:
-    if transaction.v >= EIP155_CHAIN_ID_OFFSET:
-        return True
-    else:
-        return False
+    return transaction.v >= EIP155_CHAIN_ID_OFFSET
 
 
 def extract_chain_id(v: int) -> int:

eth/consensus/clique/encoding.py

@@ -84,7 +84,7 @@ def encode_snapshot(snapshot: Snapshot) -> bytes:
     return rlp.encode(
         [
             snapshot.block_hash,
-            [signer for signer in snapshot.signers],
+            list(snapshot.signers),
             [encode_vote(vote) for vote in snapshot.votes],
             [
                 encode_address_tally_pair((address, tally))

eth/db/account.py

@@ -533,12 +533,12 @@ def _get_meta_witness(self) -> MetaWitness:
 
     def _validate_generated_root(self) -> None:
         db_diff = self._journaldb.diff()
-        if len(db_diff):
+        if db_diff:
             raise ValidationError(
                 f"AccountDB had a dirty db when it needed to be clean: {db_diff!r}"
             )
         trie_diff = self._journaltrie.diff()
-        if len(trie_diff):
+        if trie_diff:
             raise ValidationError(
                 f"AccountDB had a dirty trie when it needed to be clean: {trie_diff!r}"
             )

eth/db/header.py

@@ -358,7 +358,7 @@ def _persist_header_chain(
         try:
             first_header = first(headers_iterator)
         except StopIteration:
-            return tuple(), tuple()
+            return (), ()
 
         is_genesis = first_header.parent_hash == genesis_parent_hash
         if not is_genesis and not cls._header_exists(db, first_header.parent_hash):
@@ -410,7 +410,7 @@ def _persist_header_chain(
         if score > head_score:
             return cls._set_as_canonical_chain_head(db, curr_chain_head, genesis_parent_hash)
 
-        return tuple(), tuple()
+        return (), ()
 
     @classmethod
     def _handle_gap_change(cls,
@@ -473,10 +473,8 @@ def _canonicalize_header(
 
         # Reject if this would make a checkpoint non-canonical
         checkpoints = cls._get_checkpoints(db)
-        attempted_checkpoint_overrides = set(
-            old for old in old_canonical_headers
-            if old.hash in checkpoints
-        )
+        attempted_checkpoint_overrides = {old for old in old_canonical_headers
+                                          if old.hash in checkpoints}
         if len(attempted_checkpoint_overrides):
             raise CheckpointsMustBeCanonical(
                 f"Tried to switch chain away from checkpoint(s) {attempted_checkpoint_overrides!r}"

eth/tools/builder/chain/builders.py

@@ -147,7 +147,7 @@ class FrontierOnlyChain(MiningChain):
     if chain_class.vm_configuration is not None:
         base_configuration = chain_class.vm_configuration
     else:
-        base_configuration = tuple()
+        base_configuration = ()
 
     vm_configuration = base_configuration + ((BlockNumber(at_block), vm_class),)
     validate_vm_configuration(vm_configuration)

eth/tools/fixtures/generation.py

@@ -81,7 +81,7 @@ def generate_fixture_tests(metafunc: Any,
         else:
             all_fixtures = cached_fixture_data
 
-        if not len(all_fixtures):
+        if not all_fixtures:
             raise AssertionError(
                 f"Suspiciously found zero fixtures: {base_fixture_path}"
             )

eth/vm/computation.py

@@ -410,7 +410,7 @@ def register_account_for_deletion(self, beneficiary: Address) -> None:
 
     def get_accounts_for_deletion(self) -> Tuple[Tuple[Address, Address], ...]:
         if self.is_error:
-            return tuple()
+            return ()
         else:
             return tuple(dict(itertools.chain(
                 self.accounts_to_delete.items(),
@@ -555,14 +555,14 @@ def apply_computation(cls,
     @property
     def precompiles(self) -> Dict[Address, Callable[[ComputationAPI], Any]]:
         if self._precompiles is None:
-            return dict()
+            return {}
         else:
             return self._precompiles
 
     @classmethod
     def get_precompiles(cls) -> Dict[Address, Callable[[ComputationAPI], Any]]:
         if cls._precompiles is None:
-            return dict()
+            return {}
         else:
             return cls._precompiles
 

tests/core/chain-object/test_chain_get_ancestors.py

@@ -30,7 +30,7 @@ def test_chain_get_ancestors_from_genesis_block(chain, limit):
     assert header.block_number == 0
 
     ancestors = chain.get_ancestors(limit, header)
-    assert ancestors == tuple()
+    assert ancestors == ()
 
 
 def test_chain_get_ancestors_from_block_1(chain):
@@ -39,7 +39,7 @@ def test_chain_get_ancestors_from_block_1(chain):
     header = block_1.header
     assert header.block_number == 1
 
-    assert chain.get_ancestors(0, header) == tuple()
+    assert chain.get_ancestors(0, header) == ()
     assert chain.get_ancestors(1, header) == (genesis,)
     assert chain.get_ancestors(2, header) == (genesis,)
     assert chain.get_ancestors(5, header) == (genesis,)
@@ -58,7 +58,7 @@ def test_chain_get_ancestors_from_block_5(chain):
     header = block_5.header
     assert header.block_number == 5
 
-    assert chain.get_ancestors(0, header) == tuple()
+    assert chain.get_ancestors(0, header) == ()
     assert chain.get_ancestors(1, header) == (block_4,)
     assert chain.get_ancestors(2, header) == (block_4, block_3)
     assert chain.get_ancestors(3, header) == (block_4, block_3, block_2)
@@ -103,14 +103,14 @@ def test_chain_get_ancestors_for_fork_chains(chain, fork_chain):
     # import the fork blocks into the main chain (ensuring they don't cause a reorg)
     block_import_result = chain.import_block(f_block_4)
     new_chain = block_import_result.new_canonical_blocks
-    assert new_chain == tuple()
+    assert new_chain == ()
 
     block_import_result = chain.import_block(f_block_5)
     new_chain = block_import_result.new_canonical_blocks
-    assert new_chain == tuple()
+    assert new_chain == ()
 
     # check with a block that has been imported
-    assert chain.get_ancestors(0, f_block_5.header) == tuple()
+    assert chain.get_ancestors(0, f_block_5.header) == ()
     assert chain.get_ancestors(1, f_block_5.header) == (f_block_4,)
     assert chain.get_ancestors(2, f_block_5.header) == (f_block_4, block_3)
     assert chain.get_ancestors(3, f_block_5.header) == (f_block_4, block_3, block_2)
@@ -121,7 +121,7 @@ def test_chain_get_ancestors_for_fork_chains(chain, fork_chain):
     assert chain.get_ancestors(20, f_block_5.header) == (f_block_4, block_3, block_2, block_1, genesis)  # noqa: E501
 
     # check with a block that has NOT been imported
-    assert chain.get_ancestors(0, f_block_6.header) == tuple()
+    assert chain.get_ancestors(0, f_block_6.header) == ()
     assert chain.get_ancestors(1, f_block_6.header) == (f_block_5,)
     assert chain.get_ancestors(2, f_block_6.header) == (f_block_5, f_block_4)
     assert chain.get_ancestors(3, f_block_6.header) == (f_block_5, f_block_4, block_3)