-
Notifications
You must be signed in to change notification settings - Fork 8
Underlying unicode char types, updates to JSON reader #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
trueqbit
wants to merge
11
commits into
eteran:master
Choose a base branch
from
FireDaemon:fixes/underlying-unicode_char_types
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Underlying unicode char types, updates to JSON reader #18
trueqbit
wants to merge
11
commits into
eteran:master
from
FireDaemon:fixes/underlying-unicode_char_types
+80
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C++ unicode character types are defined as being equivalent to underlying types of at least N bits, so it's correct to use those, and improves platform-independency.
* replaced character-pointer logic with string_view functionality. * corrected non-compiling `reader::match_any()`. * simplified consumption loop.
Owner
|
Fantastic! I'll take a look at this in a little bit and try to get it merged quickly. |
eteran
requested changes
Nov 11, 2025
Owner
|
PR looks pretty fantastic, once you address the (very minor) stylistic nit picks, I'm happy to merge it in! |
In particular, some code analyzers flag functions that are declared with `noexcept` and call other functions that are not declared as such.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally i set out to correct a warning about
snprintf()requiring anunsigned intwhen passed achar32_t.So this PR fixes this warning and more:
char->unsigned char,char8_t->unsigned char,char16_t->std::uint_least16_t,char32_t->std::uint_least32_t.json::basic_reader<>::match()due to accessing the character array past-the-end.json::basic_reader<>::match_any().json::basic_reader<>with string_view functionality or iterator logic.noexceptspecifier to lambda functions passed tojson::basic_reader<>::consume_while().sizeofwithstd::size()when passing character buffer size.Additionally: