Correct less- and greater-than operators (#6521)

BrianRossmajer · web-flow · commit 6fe1c4c5d678 · 2022-04-04T14:44:32.000+03:00
Lets Manufacturer ranges in bluetooth address space be filtered correctly
diff --git a/libraries/BLE/src/BLEAddress.cpp b/libraries/BLE/src/BLEAddress.cpp
@@ -71,7 +71,7 @@ bool BLEAddress::operator!=(const BLEAddress& otherAddress) const {
 }
 
 bool BLEAddress::operator<(const BLEAddress& otherAddress) const {
-  return memcmp(otherAddress.m_address, m_address, ESP_BD_ADDR_LEN) < 0;
+  return memcmp(m_address, otherAddress.m_address, ESP_BD_ADDR_LEN) < 0;
 }
 
 bool BLEAddress::operator<=(const BLEAddress& otherAddress) const {
@@ -83,7 +83,7 @@ bool BLEAddress::operator>=(const BLEAddress& otherAddress) const {
 }
 
 bool BLEAddress::operator>(const BLEAddress& otherAddress) const {
-  return memcmp(otherAddress.m_address, m_address, ESP_BD_ADDR_LEN) > 0;
+  return memcmp(m_address, otherAddress.m_address, ESP_BD_ADDR_LEN) > 0;
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ bool BLEAddress::operator!=(const BLEAddress& otherAddress) const {`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`bool BLEAddress::operator<(const BLEAddress& otherAddress) const {`
`74`		`- return memcmp(otherAddress.m_address, m_address, ESP_BD_ADDR_LEN) < 0;`
	`74`	`+ return memcmp(m_address, otherAddress.m_address, ESP_BD_ADDR_LEN) < 0;`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`bool BLEAddress::operator<=(const BLEAddress& otherAddress) const {`
`@@ -83,7 +83,7 @@ bool BLEAddress::operator>=(const BLEAddress& otherAddress) const {`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`bool BLEAddress::operator>(const BLEAddress& otherAddress) const {`
`86`		`- return memcmp(otherAddress.m_address, m_address, ESP_BD_ADDR_LEN) > 0;`
	`86`	`+ return memcmp(m_address, otherAddress.m_address, ESP_BD_ADDR_LEN) > 0;`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`/**`