Skip to content

Fix redirect support in http client. #7039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2020
Merged

Fix redirect support in http client. #7039

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef44588
clear _canReuse in setUrl if its not a local redirect
liebman Jan 28, 2020
66e462c
Merge branch 'master' into fix-http-client-redirect
liebman Jan 28, 2020
e359c64
Merge branch 'master' into fix-http-client-redirect
earlephilhower Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libraries/ESP8266HTTPClient/src/ESP8266HTTPClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,8 @@ bool HTTPClient::setURL(const String& url)
DEBUG_HTTPCLIENT("[HTTP-Client][setURL] new URL not the same protocol, expected '%s', URL: '%s'\n", _protocol.c_str(), url.c_str());
return false;
}
// disconnect but preserve _client
// disconnect but preserve _client (clear _canReuse so disconnect will close the connection)
_canReuse = false;
disconnect(true);
return beginInternal(url, nullptr);
}
Expand Down