Expired check ALWAYS executes yield policy BEFORE checking expiration - that's wasted time.

dok-net · dok-net · commit da954514877c · 2023-07-01T12:07:39.000+02:00
Expired keeps executing yield policy on already expired oneShot - that's counter intuitive and wasted time.
diff --git a/cores/esp8266/PolledTimeout.h b/cores/esp8266/PolledTimeout.h
@@ -158,10 +158,9 @@ class timeoutTemplate
   IRAM_ATTR // fast
   bool expired()
   {
-    YieldPolicyT::execute(); //in case of DoNothing: gets optimized away
-    if(PeriodicT)           //in case of false: gets optimized away
-      return expiredRetrigger();
-    return expiredOneShot();
+    bool hasExpired = PeriodicT ? expiredRetrigger() : expiredOneShot();
+    if (!hasExpired) YieldPolicyT::execute(); //in case of DoNothing: gets optimized away
+    return hasExpired;
   }
 
   IRAM_ATTR // fast

Original file line number	Diff line number	Diff line change
`@@ -158,10 +158,9 @@ class timeoutTemplate`
`158`	`158`	`IRAM_ATTR // fast`
`159`	`159`	`bool expired()`
`160`	`160`	`{`
`161`		`- YieldPolicyT::execute(); //in case of DoNothing: gets optimized away`
`162`		`- if(PeriodicT) //in case of false: gets optimized away`
`163`		`- return expiredRetrigger();`
`164`		`- return expiredOneShot();`
	`161`	`+ bool hasExpired = PeriodicT ? expiredRetrigger() : expiredOneShot();`
	`162`	`+ if (!hasExpired) YieldPolicyT::execute(); //in case of DoNothing: gets optimized away`
	`163`	`+ return hasExpired;`
`165`	`164`	`}`
`166`	`165`
`167`	`166`	`IRAM_ATTR // fast`