remove parameter with default value

Michael Kluge · Michael Kluge · commit 244c2bb140b0 · 2021-01-25T20:40:08.000+01:00
diff --git a/cores/esp8266/Arduino.h b/cores/esp8266/Arduino.h
@@ -170,7 +170,8 @@ void digitalWrite(uint8_t pin, uint8_t val);
 int digitalRead(uint8_t pin);
 int analogRead(uint8_t pin);
 void analogReference(uint8_t mode);
-void analogWrite(uint8_t pin, int val, bool openDrain = false);
+void analogWrite(uint8_t pin, int val);
+void analogWriteMode(uint8_t pin, int val, bool openDrain);
 void analogWriteFreq(uint32_t freq);
 void analogWriteResolution(int res);
 void analogWriteRange(uint32_t range);
diff --git a/cores/esp8266/core_esp8266_wiring_pwm.cpp b/cores/esp8266/core_esp8266_wiring_pwm.cpp
@@ -43,7 +43,11 @@ extern void __analogWriteFreq(uint32_t freq) {
   _setPWMFreq(freq);
 }
 
-extern void __analogWrite(uint8_t pin, int val, bool openDrain) {
+extern void __analogWrite(uint8_t pin, int val) {
+  __analogWriteMode(pin, val, false);
+}
+
+extern void __analogWriteMode(uint8_t pin, int val, bool openDrain) {
   if (pin > 16) {
     return;
   }
@@ -91,7 +95,8 @@ extern void __analogWriteResolution(int res) {
   }
 }
 
-extern void analogWrite(uint8_t pin, int val, bool openDrain) __attribute__((weak, alias("__analogWrite")));
+extern void analogWrite(uint8_t pin, int val) __attribute__((weak, alias("__analogWrite")));
+extern void analogWriteMode(uint8_t pin, int val, bool openDrain) __attribute__((weak, alias("__analogWriteMode")));
 extern void analogWriteFreq(uint32_t freq) __attribute__((weak, alias("__analogWriteFreq")));
 extern void analogWriteRange(uint32_t range) __attribute__((weak, alias("__analogWriteRange")));
 extern void analogWriteResolution(int res) __attribute__((weak, alias("__analogWriteResolution")));

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,11 @@ extern void __analogWriteFreq(uint32_t freq) {`
`43`	`43`	`_setPWMFreq(freq);`
`44`	`44`	`}`
`45`	`45`
`46`		`-extern void __analogWrite(uint8_t pin, int val, bool openDrain) {`
	`46`	`+extern void __analogWrite(uint8_t pin, int val) {`
	`47`	`+ __analogWriteMode(pin, val, false);`
	`48`	`+}`
	`49`	`+`
	`50`	`+extern void __analogWriteMode(uint8_t pin, int val, bool openDrain) {`
`47`	`51`	`if (pin > 16) {`
`48`	`52`	`return;`
`49`	`53`	`}`
`@@ -91,7 +95,8 @@ extern void __analogWriteResolution(int res) {`
`91`	`95`	`}`
`92`	`96`	`}`
`93`	`97`
`94`		`-extern void analogWrite(uint8_t pin, int val, bool openDrain) __attribute__((weak, alias("__analogWrite")));`
	`98`	`+extern void analogWrite(uint8_t pin, int val) __attribute__((weak, alias("__analogWrite")));`
	`99`	`+extern void analogWriteMode(uint8_t pin, int val, bool openDrain) __attribute__((weak, alias("__analogWriteMode")));`
`95`	`100`	`extern void analogWriteFreq(uint32_t freq) __attribute__((weak, alias("__analogWriteFreq")));`
`96`	`101`	`extern void analogWriteRange(uint32_t range) __attribute__((weak, alias("__analogWriteRange")));`
`97`	`102`	`extern void analogWriteResolution(int res) __attribute__((weak, alias("__analogWriteResolution")));`