note about strlen in replace

mcspr · mcspr · commit 1b3b3f847cb3 · 2025-10-28T16:31:52.000+03:00
diff --git a/cores/esp8266/WString.cpp b/cores/esp8266/WString.cpp
@@ -904,7 +904,7 @@ void String::replaceImpl(internal_strstr_t impl, const char *find, unsigned int
             readFrom = foundAt + find_len;
 
             unsigned int currentLen = len();
-            remainingLen = currentLen - n - find_len + 1;
+            remainingLen = currentLen - n - find_len + 1; // avoid strlen(), ref. #5949
             setLen(currentLen + diff);
         }
         memmove_P(writeTo, readFrom, remainingLen);

Original file line number	Diff line number	Diff line change
`@@ -904,7 +904,7 @@ void String::replaceImpl(internal_strstr_t impl, const char *find, unsigned int`
`904`	`904`	`readFrom = foundAt + find_len;`
`905`	`905`
`906`	`906`	`unsigned int currentLen = len();`
`907`		`- remainingLen = currentLen - n - find_len + 1;`
	`907`	`+ remainingLen = currentLen - n - find_len + 1; // avoid strlen(), ref. #5949`
`908`	`908`	`setLen(currentLen + diff);`
`909`	`909`	`}`
`910`	`910`	`memmove_P(writeTo, readFrom, remainingLen);`