From 9acdfb35754a9ff68430ca1b729af300bc170c3b Mon Sep 17 00:00:00 2001 From: Concode0 Date: Sun, 30 Nov 2025 19:38:36 +0900 Subject: [PATCH 1/5] fix(bmi270): make burst write size configurable to prevent stack overflow --- components/bmi270/include/bmi270.hpp | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/components/bmi270/include/bmi270.hpp b/components/bmi270/include/bmi270.hpp index 1f629b8cc..b1c25fc5b 100644 --- a/components/bmi270/include/bmi270.hpp +++ b/components/bmi270/include/bmi270.hpp @@ -85,6 +85,11 @@ class Bmi270 : public espp::BasePeripheral({}, "Bmi270", config.log_level) , orientation_filter_(config.orientation_filter) - , imu_config_(config.imu_config) { + , imu_config_(config.imu_config) + , burst_write_size_(config.burst_write_size) { if constexpr (Interface == bmi270::Interface::I2C) { set_address(config.device_address); } @@ -567,7 +573,7 @@ class Bmi270 : public espp::BasePeripheral Date: Mon, 1 Dec 2025 08:33:16 +0900 Subject: [PATCH 2/5] fix: change default burst size to 0 --- components/bmi270/include/bmi270.hpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/components/bmi270/include/bmi270.hpp b/components/bmi270/include/bmi270.hpp index b1c25fc5b..c4d3e305b 100644 --- a/components/bmi270/include/bmi270.hpp +++ b/components/bmi270/include/bmi270.hpp @@ -89,7 +89,7 @@ class Bmi270 : public espp::BasePeripheral({}, "Bmi270", config.log_level) , orientation_filter_(config.orientation_filter) , imu_config_(config.imu_config) - , burst_write_size_(config.burst_write_size) { + , burst_write_size_(config.burst_write_size == 0 ? config_file_size : config.burst_write_size) { if constexpr (Interface == bmi270::Interface::I2C) { set_address(config.device_address); } @@ -712,7 +712,7 @@ class Bmi270 : public espp::BasePeripheral Date: Tue, 2 Dec 2025 08:24:34 -0600 Subject: [PATCH 3/5] Update components/bmi270/include/bmi270.hpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- components/bmi270/include/bmi270.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/bmi270/include/bmi270.hpp b/components/bmi270/include/bmi270.hpp index c4d3e305b..f14f22533 100644 --- a/components/bmi270/include/bmi270.hpp +++ b/components/bmi270/include/bmi270.hpp @@ -571,7 +571,7 @@ class Bmi270 : public espp::BasePeripheral Date: Tue, 2 Dec 2025 08:24:55 -0600 Subject: [PATCH 4/5] Update components/bmi270/include/bmi270.hpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- components/bmi270/include/bmi270.hpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/components/bmi270/include/bmi270.hpp b/components/bmi270/include/bmi270.hpp index f14f22533..8d93571ab 100644 --- a/components/bmi270/include/bmi270.hpp +++ b/components/bmi270/include/bmi270.hpp @@ -87,7 +87,8 @@ class Bmi270 : public espp::BasePeripheral Date: Tue, 2 Dec 2025 08:26:32 -0600 Subject: [PATCH 5/5] Apply suggestion from @finger563 --- components/bmi270/include/bmi270.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/components/bmi270/include/bmi270.hpp b/components/bmi270/include/bmi270.hpp index 8d93571ab..675991247 100644 --- a/components/bmi270/include/bmi270.hpp +++ b/components/bmi270/include/bmi270.hpp @@ -86,9 +86,9 @@ class Bmi270 : public espp::BasePeripheral