Fix: Remove start and end values from JSX tokens (fixes #341) (#351)

JamesHenry · web-flow · commit 840620946e23 · 2017-08-15T16:32:00.000+01:00
diff --git a/lib/node-utils.js b/lib/node-utils.js
@@ -627,8 +627,6 @@ function convertToken(token, ast) {
         newToken = {
             type: getTokenType(token),
             value,
-            start,
-            end,
             range: [start, end],
             loc: getLocFor(start, end, ast)
         };
diff --git a/package.json b/package.json
@@ -19,7 +19,7 @@
   "license": "BSD-2-Clause",
   "devDependencies": {
     "babel-code-frame": "^6.22.0",
-    "babylon": "^7.0.0-beta.16",
+    "babylon": "^7.0.0-beta.19",
     "eslint": "3.19.0",
     "eslint-config-eslint": "4.0.0",
     "eslint-plugin-node": "4.2.2",
diff --git a/tests/ast-alignment/parse.js b/tests/ast-alignment/parse.js
@@ -46,6 +46,8 @@ function parseWithTypeScriptESLintParser(text) { // eslint-disable-line
             range: true,
             tokens: false,
             comment: false,
+            useJSXTextNode: true,
+            errorOnUnknownASTType: true,
             ecmaFeatures: {
                 jsx: true
             }
diff --git a/tests/ast-alignment/spec.js b/tests/ast-alignment/spec.js
@@ -11,7 +11,8 @@ const fixturePatternsToTest = [
     "basics/instanceof.src.js",
     "basics/update-expression.src.js",
     "basics/new-without-parens.src.js",
-    "ecma-features/arrowFunctions/**/as*.src.js"
+    "ecma-features/arrowFunctions/**/as*.src.js",
+    "jsx/attributes.src.js"
 ];
 
 const fixturesToTest = [];
diff --git a/tests/fixtures/jsx/attributes.src.js b/tests/fixtures/jsx/attributes.src.js
@@ -1 +1 @@
-<foo bar="baz" qux={quz} spread={...rest}>test</foo>
+<foo bar="baz" qux={quz} {...rest}>test</foo>
diff --git a/tests/lib/__snapshots__/jsx.js.snap b/tests/lib/__snapshots__/jsx.js.snap

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,8 @@ function parseWithTypeScriptESLintParser(text) { // eslint-disable-line`
`46`	`46`	`range: true,`
`47`	`47`	`tokens: false,`
`48`	`48`	`comment: false,`
	`49`	`+ useJSXTextNode: true,`
	`50`	`+ errorOnUnknownASTType: true,`
`49`	`51`	`ecmaFeatures: {`
`50`	`52`	`jsx: true`
`51`	`53`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-<foo bar="baz" qux={quz} spread={...rest}>test</foo>`
	`1`	`+<foo bar="baz" qux={quz} {...rest}>test</foo>`