Fix: Ensure JSX tag names are JSXIdentifiers (fixes #315) (#318)

soda0289 · JamesHenry · commit 4938c2cf576a · 2017-06-09T14:15:06.000+01:00
diff --git a/lib/convert.js b/lib/convert.js
@@ -291,6 +291,7 @@ module.exports = function convert(config) {
             tagNameToken.object.type = (isNestedMemberExpression) ? AST_NODE_TYPES.JSXMemberExpression : AST_NODE_TYPES.JSXIdentifier;
             tagNameToken.property.type = AST_NODE_TYPES.JSXIdentifier;
         } else {
+            tagNameToken.type = AST_NODE_TYPES.JSXIdentifier;
             tagNameToken.name = tagNameToken.value;
         }
 
diff --git a/tests/fixtures/jsx/element-keyword-name.src.js b/tests/fixtures/jsx/element-keyword-name.src.js
@@ -0,0 +1,5 @@
+<div>
+    <object />
+    <abstract />
+    <module />
+</div>
diff --git a/tests/lib/__snapshots__/jsx.js.snap b/tests/lib/__snapshots__/jsx.js.snap

Original file line number	Diff line number	Diff line change
`@@ -291,6 +291,7 @@ module.exports = function convert(config) {`
`291`	`291`	`tagNameToken.object.type = (isNestedMemberExpression) ? AST_NODE_TYPES.JSXMemberExpression : AST_NODE_TYPES.JSXIdentifier;`
`292`	`292`	`tagNameToken.property.type = AST_NODE_TYPES.JSXIdentifier;`
`293`	`293`	`} else {`
	`294`	`+ tagNameToken.type = AST_NODE_TYPES.JSXIdentifier;`
`294`	`295`	`tagNameToken.name = tagNameToken.value;`
`295`	`296`	`}`
`296`	`297`