fix: prevent to report prefer-tacit in direct child of getter (#965)

Co-authored-by: Rebecca Stevens <rebecca.stevens@outlook.co.nz>

Author: baseballyama

src/rules/prefer-tacit.ts

@@ -118,6 +118,18 @@ function isCallerViolation(
     .some((signature) => signature.parameters.length === caller.arguments.length);
 }
 
+/**
+ * Is the given node a direct child of a getter.
+ */
+function isDirectChildOfGetter(node: TSESTree.Node): boolean {
+  const { parent } = node;
+  if (parent?.type !== TSESTree.AST_NODE_TYPES.Property) {
+    return false;
+  }
+
+  return parent.kind === "get";
+}
+
 /**
  * Get the fixes for a call to a reference violation.
  */
@@ -260,6 +272,13 @@ function checkFunction(
   context: Readonly<RuleContext<keyof typeof errorMessages, RawOptions>>,
   options: RawOptions,
 ): RuleResult<keyof typeof errorMessages, RawOptions> {
+  if (isDirectChildOfGetter(node)) {
+    return {
+      context,
+      descriptors: [],
+    };
+  }
+
   return {
     context,
     descriptors: [

tests/rules/prefer-tacit.test.ts

@@ -97,6 +97,23 @@ describe(name, () => {
       `);
     });
 
+    it("doesn't report getters", async () => {
+      await valid(dedent`
+        const foo = () => {
+          const getBar = () => 1;
+          const setBar = (value: number) => {};
+          return {
+            get baz() {
+              return getBar();
+            },
+            set baz(value) {
+              setBar(value);
+            },
+          };
+        };
+      `);
+    });
+
     describe("options", () => {
       describe("checkMemberExpressions", () => {
         it("doesn't report member expressions when disabled", async () => {