test: run js tests with @babel/eslint-parser (#569)

Author: RebeccaStevens

package.json

@@ -76,6 +76,8 @@
   },
   "devDependencies": {
     "@ava/typescript": "3.0.1",
+    "@babel/core": "^7.21.0",
+    "@babel/eslint-parser": "^7.19.1",
     "@commitlint/cli": "17.4.4",
     "@commitlint/config-conventional": "17.4.4",
     "@cspell/dict-cryptocurrencies": "3.0.1",

pnpm-lock.yaml

@@ -5,7 +5,7 @@ import type { Linter } from "eslint";
 export const filename = path.join(__dirname, "file.ts");
 
 const typescriptParser = "@typescript-eslint/parser";
-const babelParser = typescriptParser; // Switch to "babel-eslint" once https://github.com/babel/babel/issues/13712 is fixed;
+const babelParser = "@babel/eslint-parser";
 const espreeParser = "espree";
 
 export const configs = {
@@ -21,41 +21,71 @@ export const configs = {
     parser: require.resolve(babelParser),
     parserOptions: {
       ecmaVersion: 11,
+      requireConfigFile: false,
+      babelOptions: {
+        babelrc: false,
+        configFile: false,
+      },
     },
   } as Linter.Config,
 
   es10: {
     parser: require.resolve(babelParser),
     parserOptions: {
       ecmaVersion: 10,
+      requireConfigFile: false,
+      babelOptions: {
+        babelrc: false,
+        configFile: false,
+      },
     },
   } as Linter.Config,
 
   es9: {
     parser: require.resolve(babelParser),
     parserOptions: {
       ecmaVersion: 9,
+      requireConfigFile: false,
+      babelOptions: {
+        babelrc: false,
+        configFile: false,
+      },
     },
   } as Linter.Config,
 
   es8: {
     parser: require.resolve(babelParser),
     parserOptions: {
       ecmaVersion: 8,
+      requireConfigFile: false,
+      babelOptions: {
+        babelrc: false,
+        configFile: false,
+      },
     },
   } as Linter.Config,
 
   es7: {
     parser: require.resolve(babelParser),
     parserOptions: {
       ecmaVersion: 7,
+      requireConfigFile: false,
+      babelOptions: {
+        babelrc: false,
+        configFile: false,
+      },
     },
   } as Linter.Config,
 
   es6: {
     parser: require.resolve(babelParser),
     parserOptions: {
       ecmaVersion: 6,
+      requireConfigFile: false,
+      babelOptions: {
+        babelrc: false,
+        configFile: false,
+      },
     },
   } as Linter.Config,
 

tests/helpers/configs.ts

@@ -23,7 +23,6 @@ const tests: InvalidTestCase[] = [
     code: dedent`
       class Klass {
         bar = 1;
-        baz: string;
 
         constructor() {
           this.baz = "hello";
@@ -40,13 +39,13 @@ const tests: InvalidTestCase[] = [
       {
         messageId: "generic",
         type: "AssignmentExpression",
-        line: 10,
+        line: 9,
         column: 5,
       },
       {
         messageId: "generic",
         type: "AssignmentExpression",
-        line: 11,
+        line: 10,
         column: 5,
       },
     ],

tests/rules/immutable-data/es6/object/invalid.ts

@@ -8,7 +8,6 @@ const tests: ValidTestCase[] = [
     code: dedent`
       class Klass {
         bar = 1;
-        baz: string;
         constructor() {
           this.baz = "hello";
         }
@@ -35,7 +34,6 @@ const tests: ValidTestCase[] = [
   {
     code: dedent`
       class Klass {
-        baz: string;
         mutate() {
           this.baz = "hello";
         }

tests/rules/immutable-data/es6/object/valid.ts

@@ -3,7 +3,9 @@ import { testUsing } from "~/tests/helpers/testers";
 
 import es3Tests from "./es3";
 import es6Tests from "./es6";
+import tsTests from "./ts";
 
+testUsing.typescript(name, rule, tsTests);
 testUsing.typescript(name, rule, es6Tests);
 testUsing.typescript(name, rule, es3Tests);
 

tests/rules/immutable-data/index.test.ts

@@ -0,0 +1,6 @@
+import object from "./object";
+
+export default {
+  valid: [...object.valid],
+  invalid: [...object.invalid],
+};

tests/rules/immutable-data/ts/index.ts

@@ -0,0 +1,7 @@
+import invalid from "./invalid";
+import valid from "./valid";
+
+export default {
+  valid,
+  invalid,
+};

tests/rules/immutable-data/ts/object/index.ts

@@ -0,0 +1,40 @@
+import dedent from "dedent";
+
+import type { InvalidTestCase } from "~/tests/helpers/util";
+
+const tests: InvalidTestCase[] = [
+  {
+    code: dedent`
+      class Klass {
+        bar = 1;
+        baz: string;
+
+        constructor() {
+          this.baz = "hello";
+        }
+
+        zoo() {
+          this.bar = 2;
+          this.baz = 3;
+        }
+      }
+    `,
+    optionsSet: [[]],
+    errors: [
+      {
+        messageId: "generic",
+        type: "AssignmentExpression",
+        line: 10,
+        column: 5,
+      },
+      {
+        messageId: "generic",
+        type: "AssignmentExpression",
+        line: 11,
+        column: 5,
+      },
+    ],
+  },
+];
+
+export default tests;

tests/rules/immutable-data/ts/object/invalid.ts

@@ -0,0 +1,21 @@
+import dedent from "dedent";
+
+import type { ValidTestCase } from "~/tests/helpers/util";
+
+const tests: ValidTestCase[] = [
+  // Allow initialization of class members in constructor
+  {
+    code: dedent`
+      class Klass {
+        bar = 1;
+        baz: string;
+        constructor() {
+          this.baz = "hello";
+        }
+      }
+    `,
+    optionsSet: [[]],
+  },
+];
+
+export default tests;