fix: checking of types from ts's lib are now more strict (#862)

Author: RebeccaStevens

src/rules/immutable-data.ts

@@ -478,7 +478,7 @@ function isInChainCallAndFollowsNew(
   // Check for: new Array()
   if (
     isNewExpression(node) &&
-    isArrayConstructorType(getTypeOfNode(node.callee, context))
+    isArrayConstructorType(context, getTypeOfNode(node.callee, context))
   ) {
     return true;
   }
@@ -491,7 +491,10 @@ function isInChainCallAndFollowsNew(
     // Check for: Array.from(iterable)
     if (
       arrayConstructorFunctions.some(isExpected(node.callee.property.name)) &&
-      isArrayConstructorType(getTypeOfNode(node.callee.object, context))
+      isArrayConstructorType(
+        context,
+        getTypeOfNode(node.callee.object, context),
+      )
     ) {
       return true;
     }
@@ -508,7 +511,10 @@ function isInChainCallAndFollowsNew(
       objectConstructorNewObjectReturningMethods.some(
         isExpected(node.callee.property.name),
       ) &&
-      isObjectConstructorType(getTypeOfNode(node.callee.object, context))
+      isObjectConstructorType(
+        context,
+        getTypeOfNode(node.callee.object, context),
+      )
     ) {
       return true;
     }
@@ -582,7 +588,7 @@ function checkCallExpression(
     arrayMutatorMethods.has(node.callee.property.name) &&
     (!ignoreImmediateMutation ||
       !isInChainCallAndFollowsNew(node.callee, context)) &&
-    isArrayType(getTypeOfNode(node.callee.object, context))
+    isArrayType(context, getTypeOfNode(node.callee.object, context))
   ) {
     if (ignoreNonConstDeclarations === false) {
       return {
@@ -627,7 +633,7 @@ function checkCallExpression(
       ignoreIdentifierPattern,
       ignoreAccessorPattern,
     ) &&
-    isObjectConstructorType(getTypeOfNode(node.callee.object, context))
+    isObjectConstructorType(context, getTypeOfNode(node.callee.object, context))
   ) {
     if (ignoreNonConstDeclarations === false) {
       return {

src/rules/prefer-readonly-type.ts

@@ -495,7 +495,7 @@ function checkImplicitType(
       isIdentifier(declarator.id) &&
       declarator.id.typeAnnotation === undefined &&
       declarator.init !== null &&
-      isArrayType(getTypeOfNode(declarator.init, context)) &&
+      isArrayType(context, getTypeOfNode(declarator.init, context)) &&
       !ignoreCollections
         ? [
             {

src/utils/tree.ts

@@ -149,7 +149,7 @@ export function isInPromiseHandlerFunction<
   }
 
   const objectType = getTypeOfNode(functionNode.parent.callee.object, context);
-  return isPromiseType(objectType);
+  return isPromiseType(context, objectType);
 }
 
 /**

src/utils/type-guards.ts

@@ -3,10 +3,18 @@
  */
 
 import { AST_NODE_TYPES, type TSESTree } from "@typescript-eslint/utils";
-import type { Type, UnionType } from "typescript";
+import type { RuleContext } from "@typescript-eslint/utils/ts-eslint";
+import typeMatchesSpecifier, {
+  type TypeDeclarationSpecifier,
+} from "ts-declaration-location";
+import type { Program, Type, UnionType } from "typescript";
 
 import typescript from "#/conditional-imports/typescript";
 
+const libSpecifier = {
+  from: "lib",
+} satisfies TypeDeclarationSpecifier;
+
 /*
  * TS Types.
  */
@@ -429,41 +437,63 @@ export function isUnionType(type: Type): type is UnionType {
   return typescript !== undefined && type.flags === typescript.TypeFlags.Union;
 }
 
-export function isArrayType(type: Type | null): boolean {
-  return (
-    type !== null &&
-    (((type.symbol as unknown) !== undefined && type.symbol.name === "Array") ||
-      (isUnionType(type) && type.types.some(isArrayType)))
-  );
-}
-
-export function isArrayConstructorType(type: Type | null): boolean {
-  return (
-    type !== null &&
-    (((type.symbol as unknown) !== undefined &&
-      type.symbol.name === "ArrayConstructor") ||
-      (isUnionType(type) && type.types.some(isArrayConstructorType)))
-  );
-}
-
-export function isObjectConstructorType(type: Type | null): boolean {
-  return (
-    type !== null &&
-    (((type.symbol as unknown) !== undefined &&
-      type.symbol.name === "ObjectConstructor") ||
-      (isUnionType(type) && type.types.some(isObjectConstructorType)))
-  );
-}
-
 export function isFunctionLikeType(type: Type | null): boolean {
   return type !== null && type.getCallSignatures().length > 0;
 }
 
-export function isPromiseType(type: Type | null): boolean {
-  return (
-    type !== null &&
-    (((type.symbol as unknown) !== undefined &&
-      type.symbol.name === "Promise") ||
-      (isUnionType(type) && type.types.some(isPromiseType)))
-  );
+export function isArrayType(
+  context: RuleContext<string, ReadonlyArray<unknown>>,
+  type: Type | null,
+): boolean {
+  return typeMatches(context, "Array", type);
+}
+
+export function isArrayConstructorType(
+  context: RuleContext<string, ReadonlyArray<unknown>>,
+  type: Type | null,
+): boolean {
+  return typeMatches(context, "ArrayConstructor", type);
+}
+
+export function isObjectConstructorType(
+  context: RuleContext<string, ReadonlyArray<unknown>>,
+  type: Type | null,
+): boolean {
+  return typeMatches(context, "ObjectConstructor", type);
+}
+
+export function isPromiseType(
+  context: RuleContext<string, ReadonlyArray<unknown>>,
+  type: Type | null,
+): boolean {
+  return typeMatches(context, "Promise", type);
+}
+
+function typeMatches(
+  context: RuleContext<string, ReadonlyArray<unknown>>,
+  typeName: string,
+  type: Type | null,
+): boolean {
+  if (type === null) {
+    return false;
+  }
+  const program = context.sourceCode.parserServices?.program ?? undefined;
+  if (program === undefined) {
+    return false;
+  }
+  return typeMatchesHelper(program, typeName)(type);
+}
+
+function typeMatchesHelper(
+  program: Program,
+  typeName: string,
+): (type: Type) => boolean {
+  return function test(type: Type) {
+    return (
+      ((type.symbol as unknown) !== undefined &&
+        type.symbol.name === typeName &&
+        typeMatchesSpecifier(program, libSpecifier, type)) ||
+      (isUnionType(type) && type.types.some(test))
+    );
+  };
 }