chore: Enable global strict eslint rule (#191)

scagood · web-flow · commit 99fe38722d02 · 2024-02-28T14:05:11.000+08:00
* lint: Enable global strict eslint rule

* chore: Add missing "use strict" directives

* chore: Move strict check to everywhere
diff --git a/eslint.config.js b/eslint.config.js
@@ -28,7 +28,10 @@ module.exports = [
     eslintPluginConfig,
     prettierConfig,
     {
-        rules: { "eslint-plugin/require-meta-docs-description": "error" },
+        rules: {
+            strict: ["error", "global"],
+            "eslint-plugin/require-meta-docs-description": "error",
+        },
     },
     {
         // these messageIds were used outside
diff --git a/lib/unsupported-features/node-builtins-modules/assert.js b/lib/unsupported-features/node-builtins-modules/assert.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/async_hooks.js b/lib/unsupported-features/node-builtins-modules/async_hooks.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/buffer.js b/lib/unsupported-features/node-builtins-modules/buffer.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/child_process.js b/lib/unsupported-features/node-builtins-modules/child_process.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/cluster.js b/lib/unsupported-features/node-builtins-modules/cluster.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/console.js b/lib/unsupported-features/node-builtins-modules/console.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/crypto.js b/lib/unsupported-features/node-builtins-modules/crypto.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/dgram.js b/lib/unsupported-features/node-builtins-modules/dgram.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/diagnostics_channel.js b/lib/unsupported-features/node-builtins-modules/diagnostics_channel.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/dns.js b/lib/unsupported-features/node-builtins-modules/dns.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/domain.js b/lib/unsupported-features/node-builtins-modules/domain.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/events.js b/lib/unsupported-features/node-builtins-modules/events.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/fs.js b/lib/unsupported-features/node-builtins-modules/fs.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/http.js b/lib/unsupported-features/node-builtins-modules/http.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/http2.js b/lib/unsupported-features/node-builtins-modules/http2.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/https.js b/lib/unsupported-features/node-builtins-modules/https.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/inspector.js b/lib/unsupported-features/node-builtins-modules/inspector.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/module.js b/lib/unsupported-features/node-builtins-modules/module.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/net.js b/lib/unsupported-features/node-builtins-modules/net.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/os.js b/lib/unsupported-features/node-builtins-modules/os.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/path.js b/lib/unsupported-features/node-builtins-modules/path.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/perf_hooks.js b/lib/unsupported-features/node-builtins-modules/perf_hooks.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/process.js b/lib/unsupported-features/node-builtins-modules/process.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/punycode.js b/lib/unsupported-features/node-builtins-modules/punycode.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/querystring.js b/lib/unsupported-features/node-builtins-modules/querystring.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/readline.js b/lib/unsupported-features/node-builtins-modules/readline.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/stream.js b/lib/unsupported-features/node-builtins-modules/stream.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 // TODO: https://nodejs.org/docs/latest/api/webstreams.html
diff --git a/lib/unsupported-features/node-builtins-modules/string_decoder.js b/lib/unsupported-features/node-builtins-modules/string_decoder.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/test.js b/lib/unsupported-features/node-builtins-modules/test.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/timers.js b/lib/unsupported-features/node-builtins-modules/timers.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/tls.js b/lib/unsupported-features/node-builtins-modules/tls.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/trace_events.js b/lib/unsupported-features/node-builtins-modules/trace_events.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/tty.js b/lib/unsupported-features/node-builtins-modules/tty.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/url.js b/lib/unsupported-features/node-builtins-modules/url.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/util.js b/lib/unsupported-features/node-builtins-modules/util.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/v8.js b/lib/unsupported-features/node-builtins-modules/v8.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/vm.js b/lib/unsupported-features/node-builtins-modules/vm.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/wasi.js b/lib/unsupported-features/node-builtins-modules/wasi.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/worker_threads.js b/lib/unsupported-features/node-builtins-modules/worker_threads.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins-modules/zlib.js b/lib/unsupported-features/node-builtins-modules/zlib.js
@@ -1,3 +1,5 @@
+"use strict"
+
 const { READ } = require("@eslint-community/eslint-utils")
 
 /** @type {import('../types.js').SupportVersionTree} */
diff --git a/lib/unsupported-features/node-builtins.js b/lib/unsupported-features/node-builtins.js
@@ -1,3 +1,5 @@
+"use strict"
+
 /** @type {import('./types.js').SupportVersionTree} */
 const NodeBuiltinModules = {
     ...require("./node-builtins-modules/assert.js"),
diff --git a/lib/unsupported-features/types.js b/lib/unsupported-features/types.js
@@ -1,3 +1,5 @@
+"use strict"
+
 /**
  * @typedef {Object} SupportInfo
  * @property {string[]} experimental  The node versions in which experimental support was added

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,10 @@ module.exports = [`
`28`	`28`	`eslintPluginConfig,`
`29`	`29`	`prettierConfig,`
`30`	`30`	`{`
`31`		`- rules: { "eslint-plugin/require-meta-docs-description": "error" },`
	`31`	`+ rules: {`
	`32`	`+ strict: ["error", "global"],`
	`33`	`+ "eslint-plugin/require-meta-docs-description": "error",`
	`34`	`+ },`
`32`	`35`	`},`
`33`	`36`	`{`
`34`	`37`	`// these messageIds were used outside`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+"use strict"`
	`2`	`+`
`1`	`3`	`const { READ } = require("@eslint-community/eslint-utils")`
`2`	`4`
`3`	`5`	`/** @type {import('../types.js').SupportVersionTree} */`