Add tests for ElixirChecker

Author: Premwoik

test/examples/Elixir.CorrectSpec.beam

@@ -0,0 +1,6 @@
+defmodule SpecAfterSpec do
+  @spec convert(integer()) :: float()
+  @spec convert(atom()) :: binary()
+  def convert(int) when is_integer(int), do: int / 1
+  def convert(atom) when is_atom(atom), do: to_string(atom)
+end

test/examples/Elixir.SpecAfterSpec.beam

@@ -0,0 +1,6 @@
+defmodule CorrectSpec do
+  @spec convert(integer()) :: float()
+  def convert(int) when is_integer(int), do: int / 1
+  @spec convert(atom()) :: binary()
+  def convert(atom) when is_atom(atom), do: to_string(atom)
+end

test/examples/Elixir.SpecWrongName.beam

@@ -0,0 +1,15 @@
+defmodule SpecWrongName do
+  @spec convert(integer()) :: float()
+  def convert(int) when is_integer(int), do: int / 1
+
+  @spec convert(atom()) :: binary()
+  def last_two(list) do
+    [last, penultimate | _tail] = Enum.reverse(list)
+    [penultimate, last]
+  end
+
+  @spec last_two(atom()) :: atom()
+  def last_three(:ok) do
+    :ok
+  end
+end

test/examples/spec_after_spec.ex

@@ -0,0 +1,41 @@
+defmodule Gradient.ElixirCheckerTest do
+  use ExUnit.Case
+  doctest Gradient.ElixirChecker
+
+  alias Gradient.ElixirChecker
+
+  import Gradient.TestHelpers
+
+  test "checker options" do
+    ast = load("Elixir.SpecWrongName.beam")
+
+    assert [] = ElixirChecker.check(ast, ex_check: false)
+    assert [] != ElixirChecker.check(ast, ex_check: true)
+  end
+
+  test "all specs are correct" do
+    ast = load("Elixir.CorrectSpec.beam")
+
+    assert [] = ElixirChecker.check(ast, ex_check: true)
+  end
+
+  test "spec name doesn't match the function name" do
+    ast = load("Elixir.SpecWrongName.beam")
+
+    assert [
+             {_,
+              {:spec_error, :wrong_spec_name, 11, :last_two, 1}},
+             {_,
+              {:spec_error, :wrong_spec_name, 5, :convert, 1}}
+           ] = ElixirChecker.check(ast, [])
+  end
+
+  test "more than one spec per function clause is not allowed" do
+    ast = load("Elixir.SpecAfterSpec.beam")
+
+    assert [
+             {_,
+              {:spec_error, :spec_after_spec, 3, :convert_a, 1}}
+           ] = ElixirChecker.check(ast, [])
+  end
+end

test/examples/spec_correct.ex

@@ -3,6 +3,16 @@ defmodule Gradient.TestHelpers do
 
   @examples_path "test/examples/"
 
+  @spec load(String.t()) :: T.forms()
+  def load(beam_file) do
+    beam_file = String.to_charlist(@examples_path <> beam_file)
+
+    {:ok, {_, [abstract_code: {:raw_abstract_v1, ast}]}} =
+      :beam_lib.chunks(beam_file, [:abstract_code])
+
+    ast
+  end
+
   @spec load(String.t(), String.t()) :: {T.tokens(), T.forms()}
   def load(beam_file, ex_file) do
     beam_file = String.to_charlist(@examples_path <> beam_file)