From 6d44b23ec3de7ed35dbcde9fb4b7d11592275cc3 Mon Sep 17 00:00:00 2001 From: Igor Zubkov Date: Sun, 23 Mar 2025 14:24:42 +0100 Subject: [PATCH 01/16] Remove .travis.yml --- .travis.yml | 9 --------- 1 file changed, 9 deletions(-) delete mode 100644 .travis.yml diff --git a/.travis.yml b/.travis.yml deleted file mode 100644 index bfe7a09..0000000 --- a/.travis.yml +++ /dev/null @@ -1,9 +0,0 @@ -language: ruby -rvm: - - 2.1 - - 2.2 - - 2.3.0 -sudo: false -cache: bundler -script: - - bundle exec rspec From 47e1ba7a5cebd9be34c1fad28abc905193b4b7e2 Mon Sep 17 00:00:00 2001 From: Igor Zubkov Date: Sun, 23 Mar 2025 14:24:55 +0100 Subject: [PATCH 02/16] Remove travis ci badge --- README.md | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/README.md b/README.md index 1cb7efe..1b4b1d4 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,4 @@ -# Errbit Github Plugin [![TravisCI][travis-img-url]][travis-ci-url] - -[travis-img-url]: https://travis-ci.org/errbit/errbit_github_plugin.svg?branch=master -[travis-ci-url]: http://travis-ci.org/errbit/errbit_github_plugin +# Errbit GitHub Plugin This plugin provides GitHub issue tracker integration for Errbit and it is the only plugin included by default in Errbit. From 97be78b37c3ab577f075c40218b1b6b1d76ce1c6 Mon Sep 17 00:00:00 2001 From: Igor Zubkov Date: Sun, 23 Mar 2025 14:27:10 +0100 Subject: [PATCH 03/16] Add railties to gemspec --- errbit_github_plugin.gemspec | 1 + 1 file changed, 1 insertion(+) diff --git a/errbit_github_plugin.gemspec b/errbit_github_plugin.gemspec index 90d75c9..8fb7f17 100644 --- a/errbit_github_plugin.gemspec +++ b/errbit_github_plugin.gemspec @@ -20,6 +20,7 @@ Gem::Specification.new do |spec| spec.require_paths = ['lib'] spec.add_dependency 'errbit_plugin' + spec.add_dependency 'railties', ">= 6.1.0" spec.add_dependency 'octokit' spec.add_development_dependency 'rspec' From 65e5ae9dcd71369fc12b68f2f6fbdbdfc55f964f Mon Sep 17 00:00:00 2001 From: Igor Zubkov Date: Sun, 23 Mar 2025 14:27:23 +0100 Subject: [PATCH 04/16] Add .ruby-version --- .ruby-version | 1 + 1 file changed, 1 insertion(+) create mode 100644 .ruby-version diff --git a/.ruby-version b/.ruby-version new file mode 100644 index 0000000..9cec716 --- /dev/null +++ b/.ruby-version @@ -0,0 +1 @@ +3.1.6 From 123986043be90d23fbee53fcfa6e8848c58d5c86 Mon Sep 17 00:00:00 2001 From: Igor Zubkov Date: Sun, 23 Mar 2025 14:27:33 +0100 Subject: [PATCH 05/16] Add Gemfile.lock --- Gemfile | 1 + Gemfile.lock | 248 +++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 249 insertions(+) create mode 100644 Gemfile.lock diff --git a/Gemfile b/Gemfile index 851fabc..fa75df1 100644 --- a/Gemfile +++ b/Gemfile @@ -1,2 +1,3 @@ source 'https://rubygems.org' + gemspec diff --git a/Gemfile.lock b/Gemfile.lock new file mode 100644 index 0000000..894544d --- /dev/null +++ b/Gemfile.lock @@ -0,0 +1,248 @@ +PATH + remote: . + specs: + errbit_github_plugin (0.3.0) + errbit_plugin + octokit + railties (>= 6.1.0) + +GEM + remote: https://rubygems.org/ + specs: + actionpack (7.2.2.1) + actionview (= 7.2.2.1) + activesupport (= 7.2.2.1) + nokogiri (>= 1.8.5) + racc + rack (>= 2.2.4, < 3.2) + rack-session (>= 1.0.1) + rack-test (>= 0.6.3) + rails-dom-testing (~> 2.2) + rails-html-sanitizer (~> 1.6) + useragent (~> 0.16) + actionview (7.2.2.1) + activesupport (= 7.2.2.1) + builder (~> 3.1) + erubi (~> 1.11) + rails-dom-testing (~> 2.2) + rails-html-sanitizer (~> 1.6) + activesupport (7.2.2.1) + base64 + benchmark (>= 0.3) + bigdecimal + concurrent-ruby (~> 1.0, >= 1.3.1) + connection_pool (>= 2.2.5) + drb + i18n (>= 1.6, < 2) + logger (>= 1.4.2) + minitest (>= 5.1) + securerandom (>= 0.3) + tzinfo (~> 2.0, >= 2.0.5) + addressable (2.8.7) + public_suffix (>= 2.0.2, < 7.0) + base64 (0.2.0) + benchmark (0.4.0) + bigdecimal (3.1.9) + builder (3.3.0) + coderay (1.1.3) + concurrent-ruby (1.3.5) + connection_pool (2.5.0) + coveralls (0.8.23) + json (>= 1.8, < 3) + simplecov (~> 0.16.1) + term-ansicolor (~> 1.3) + thor (>= 0.19.4, < 2.0) + tins (~> 1.6) + crass (1.0.6) + date (3.4.1) + diff-lcs (1.6.0) + docile (1.4.1) + drb (2.2.1) + errbit_plugin (0.6.0) + erubi (1.13.1) + faraday (2.12.2) + faraday-net_http (>= 2.0, < 3.5) + json + logger + faraday-net_http (3.4.0) + net-http (>= 0.5.0) + ffi (1.17.1) + ffi (1.17.1-aarch64-linux-gnu) + ffi (1.17.1-aarch64-linux-musl) + ffi (1.17.1-arm-linux-gnu) + ffi (1.17.1-arm-linux-musl) + ffi (1.17.1-arm64-darwin) + ffi (1.17.1-x86-linux-gnu) + ffi (1.17.1-x86-linux-musl) + ffi (1.17.1-x86_64-darwin) + ffi (1.17.1-x86_64-linux-gnu) + ffi (1.17.1-x86_64-linux-musl) + formatador (1.1.0) + guard (2.19.1) + formatador (>= 0.2.4) + listen (>= 2.7, < 4.0) + logger (~> 1.6) + lumberjack (>= 1.0.12, < 2.0) + nenv (~> 0.1) + notiffany (~> 0.0) + ostruct (~> 0.6) + pry (>= 0.13.0) + shellany (~> 0.0) + thor (>= 0.18.1) + guard-compat (1.2.1) + guard-rspec (4.7.3) + guard (~> 2.1) + guard-compat (~> 1.1) + rspec (>= 2.99.0, < 4.0) + i18n (1.14.7) + concurrent-ruby (~> 1.0) + io-console (0.8.0) + irb (1.15.1) + pp (>= 0.6.0) + rdoc (>= 4.0.0) + reline (>= 0.4.2) + json (2.10.2) + listen (3.9.0) + rb-fsevent (~> 0.10, >= 0.10.3) + rb-inotify (~> 0.9, >= 0.9.10) + logger (1.6.6) + loofah (2.24.0) + crass (~> 1.0.2) + nokogiri (>= 1.12.0) + lumberjack (1.2.10) + method_source (1.1.0) + mini_portile2 (2.8.8) + minitest (5.25.5) + nenv (0.3.0) + net-http (0.6.0) + uri + nokogiri (1.18.5) + mini_portile2 (~> 2.8.2) + racc (~> 1.4) + nokogiri (1.18.5-aarch64-linux-gnu) + racc (~> 1.4) + nokogiri (1.18.5-aarch64-linux-musl) + racc (~> 1.4) + nokogiri (1.18.5-arm-linux-gnu) + racc (~> 1.4) + nokogiri (1.18.5-arm-linux-musl) + racc (~> 1.4) + nokogiri (1.18.5-arm64-darwin) + racc (~> 1.4) + nokogiri (1.18.5-x86_64-darwin) + racc (~> 1.4) + nokogiri (1.18.5-x86_64-linux-gnu) + racc (~> 1.4) + nokogiri (1.18.5-x86_64-linux-musl) + racc (~> 1.4) + notiffany (0.1.3) + nenv (~> 0.1) + shellany (~> 0.0) + octokit (9.2.0) + faraday (>= 1, < 3) + sawyer (~> 0.9) + ostruct (0.6.1) + pp (0.6.2) + prettyprint + prettyprint (0.2.0) + pry (0.15.2) + coderay (~> 1.1) + method_source (~> 1.0) + psych (5.2.3) + date + stringio + public_suffix (6.0.1) + racc (1.8.1) + rack (3.1.12) + rack-session (2.1.0) + base64 (>= 0.1.0) + rack (>= 3.0.0) + rack-test (2.2.0) + rack (>= 1.3) + rackup (2.2.1) + rack (>= 3) + rails-dom-testing (2.2.0) + activesupport (>= 5.0.0) + minitest + nokogiri (>= 1.6) + rails-html-sanitizer (1.6.2) + loofah (~> 2.21) + nokogiri (>= 1.15.7, != 1.16.7, != 1.16.6, != 1.16.5, != 1.16.4, != 1.16.3, != 1.16.2, != 1.16.1, != 1.16.0.rc1, != 1.16.0) + railties (7.2.2.1) + actionpack (= 7.2.2.1) + activesupport (= 7.2.2.1) + irb (~> 1.13) + rackup (>= 1.0.0) + rake (>= 12.2) + thor (~> 1.0, >= 1.2.2) + zeitwerk (~> 2.6) + rake (13.2.1) + rb-fsevent (0.11.2) + rb-inotify (0.11.1) + ffi (~> 1.0) + rdoc (6.12.0) + psych (>= 4.0.0) + reline (0.6.0) + io-console (~> 0.5) + rspec (3.13.0) + rspec-core (~> 3.13.0) + rspec-expectations (~> 3.13.0) + rspec-mocks (~> 3.13.0) + rspec-core (3.13.3) + rspec-support (~> 3.13.0) + rspec-expectations (3.13.3) + diff-lcs (>= 1.2.0, < 2.0) + rspec-support (~> 3.13.0) + rspec-mocks (3.13.2) + diff-lcs (>= 1.2.0, < 2.0) + rspec-support (~> 3.13.0) + rspec-support (3.13.2) + sawyer (0.9.2) + addressable (>= 2.3.5) + faraday (>= 0.17.3, < 3) + securerandom (0.4.1) + shellany (0.0.1) + simplecov (0.16.1) + docile (~> 1.1) + json (>= 1.8, < 3) + simplecov-html (~> 0.10.0) + simplecov-html (0.10.2) + stringio (3.1.5) + sync (0.5.0) + term-ansicolor (1.11.2) + tins (~> 1.0) + thor (1.3.2) + tins (1.38.0) + bigdecimal + sync + tzinfo (2.0.6) + concurrent-ruby (~> 1.0) + uri (1.0.3) + useragent (0.16.11) + zeitwerk (2.6.18) + +PLATFORMS + aarch64-linux-gnu + aarch64-linux-musl + arm-linux-gnu + arm-linux-musl + arm64-darwin + ruby + x86-linux-gnu + x86-linux-musl + x86_64-darwin + x86_64-linux-gnu + x86_64-linux-musl + +DEPENDENCIES + activesupport + bundler + coveralls + errbit_github_plugin! + guard + guard-rspec + rake + rspec + +BUNDLED WITH + 2.6.6 From 1f33dbe60e7b5cba2dbeae805fa49b2496df5944 Mon Sep 17 00:00:00 2001 From: Igor Zubkov Date: Sun, 23 Mar 2025 14:27:43 +0100 Subject: [PATCH 06/16] Update .gitignore --- .gitignore | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitignore b/.gitignore index f294155..2e679cf 100644 --- a/.gitignore +++ b/.gitignore @@ -3,7 +3,6 @@ .bundle .config .yardoc -Gemfile.lock InstalledFiles _yardoc coverage From 7ecc35da0663664fadddb90898cab7900b73b169 Mon Sep 17 00:00:00 2001 From: Igor Zubkov Date: Sun, 23 Mar 2025 14:31:17 +0100 Subject: [PATCH 07/16] Move images to app/assets/images/errbit_github_plugin --- .../errbit_github_plugin}/github_create.png | Bin .../images/errbit_github_plugin}/github_goto.png | Bin .../errbit_github_plugin}/github_inactive.png | Bin vendor/assets/images/github_create.png | Bin 2187 -> 0 bytes vendor/assets/images/github_inactive.png | Bin 1080 -> 0 bytes 5 files changed, 0 insertions(+), 0 deletions(-) rename {static => app/assets/images/errbit_github_plugin}/github_create.png (100%) rename {static => app/assets/images/errbit_github_plugin}/github_goto.png (100%) rename {static => app/assets/images/errbit_github_plugin}/github_inactive.png (100%) delete mode 100644 vendor/assets/images/github_create.png delete mode 100644 vendor/assets/images/github_inactive.png diff --git a/static/github_create.png b/app/assets/images/errbit_github_plugin/github_create.png similarity index 100% rename from static/github_create.png rename to app/assets/images/errbit_github_plugin/github_create.png diff --git a/static/github_goto.png b/app/assets/images/errbit_github_plugin/github_goto.png similarity index 100% rename from static/github_goto.png rename to app/assets/images/errbit_github_plugin/github_goto.png diff --git a/static/github_inactive.png b/app/assets/images/errbit_github_plugin/github_inactive.png similarity index 100% rename from static/github_inactive.png rename to app/assets/images/errbit_github_plugin/github_inactive.png diff --git a/vendor/assets/images/github_create.png b/vendor/assets/images/github_create.png deleted file mode 100644 index 8bc8e9dccb29e6e6d04cc558988acc5b2c5a53cd..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 2187 zcmV;62z2*}P)evpZ ziPpwuAP=h%6W+*c_ujpG_XWGaF7jF)3k%2s%TrcaYiXA6^!zp>>X>FG{FOU%=I-PE ze&0FY_nq^*-}_Epm6erq?)<(l?Tx6sygW@|VPR}hQBizxadCW6adB*6L80cYLvKgj z`K-ZUm@_L-o6S12Fz3Q&+LB8pNwO?w+U<75>2&&PYHETa91e%iZnG;!*_c^cTAK8E zUat1mI*Y|JJMb-=x6CamDM>b|s_d+Bh8r6jsiUKVy1Ton_sSLO?dhSe&Q5A=ZKccg z^;GR}gvGOEWo5|+5A2^iE70@j&g%?%LzctooN8@rBY&Tt1_t`c@9*RAN20HSiJLcXPLGa`pufK# zgM$GK1_J2w`=>cDHaR4FfcHHU@(X)T&>UN!@%Gm0-S(BGT`G+J_c6{Uso3d{Z5C2BuP>)T)3e7 zTFv!(edLGjuWp+wC=!+W`~5UHI2fM1ejT+nwe-w0iL_+N5;}C~5Kf*v3BFT$S~?v& zc8rc3IZ97G{WO*>TZU67PYL?LNreSC8<51FyLRo0XwC+`*Kj2zmy(?h=Tr~t#+5N` zy%4}|my6b|T}SuLyAL{@4smgDh>eYEbAcKWj7^EMB}ACr+G*uoM^yfIR@= zf!f;IsY{nGCI25?FKShGq{q`DC}wSY#X=ez8z=5ltX{pE9$2sd+6Nb5!9uOLQ}m)m zSg4H_-zl1ZkB*MU-o1NiczBquUAxBn_%Sjv5;2|CYL)+W_N?|EV9qFsX$kw-ootYZ zPNTf2o6WUz=S~uvFI*Un#c?_$#6OG&7sYTQT8e)tjviT>KykVl%)5U+9$&tkic5-V zGBinnz#!O|=;v;zbGgD|7Tg7zk&zK)G#WD-*ic`!NB49W1B+^#nwzlU`RDP2`SX$b z!n4SE_b|SAKLhWlZKdOTev40!rbEg32hJSdk2NcPito?6pAH;6h{;e$I6YECm#<6E zO_D*%eDB12wQ4h#l3mR%i-nrBG;rw~DbN3$HxN$?!3~nvB-EOL?sv?ugr06U3nmbHY63c)1 z+S=Phi|};vg0+U|VYj;;iHYm*QsQ!ihMO^=$QaE(3mSD1U2DPg%>b@S;f>gs9{VyF;%$j1(ky{&IaNj(1+u?G#ARex(tD`?1 zJWOj>K1z=K4?tJD8MFg5(Lxk(6Mg9?ni?be&p3*+GO<4KDf-~UY%;4V@$42=qS`S7 z9OS-^p8@6v;<@4=_niPGPm2eFV%CL$Yk3CO;GK7l(qGbdp`rXNMp{%{Z?{pXNyb=x zIsC3NvgDq@z8xtz{?|;Zt#gshW+V0uS*%u3fN-@)BFKGw8@Rl@JhsYi_c0i?w0Nko zsR=F3&FEph&CVJ+_eCx`I++P?7d|?38tL0pu=ll%l>XXA?D)+uuzO1~y}5rMKD(HU z#-?UIFfNM&BSJHK2Mo>(n8gV7NwRdC>iqoth`Bo2JH)i&{u@BQzaQ7R7l$UUQTD|g z`tZ|i@^T{OdI?Xgei9nZ1Eh<4DAH1|q@){5V!zm6A^e~qN1BqS{P2_AcVIez)8 z7qIw84`b8IFN38*GqZFH%wmoJf_0safGP^f+_FZ!KI)zU!bS>n--#nn%v!X1TB(_7 z7ojgJL-y%YNZYd;Pp({v^=lJp*S4)#wsa{rzL*5HycA6}PFT$}KQ!~Y*lSf<~1J}UiWRvje zRN8fgvWNbS)K7}A>XohddFl?@@OCDxNJ^$Pzk8kjD7*2|SO^7;9yXB?CdmMHFjp%J zcTaKLdq}Y0k)!JGr%%u2&sjpJ8m`>MuRE7*R+Kh&QpOa~&S}D{&H=ns;6;kmM%!K8 zw7Ikun@WAOtz!g#Ai`TAP@$t9){4@wB1^2TQ6!S3D5l7<$O+tiEOMohA4<#0bc)fa zM!=b3m(2pbs~LYA4k05~cB-9(4}OL%jN@NWME%4`l;^cAGY zk!n>Ao!Fc8{^pmzit_RVu|Twe-Dag~i-lB2Es8u|{Ihise|BBPVRsN24HMX3HGv}y zW619EPv_TrU@%$8#5xO#W!{77PWV>uT|88DyeLaCsZ(P7RVgyrc{8)3l94x;j2yB` z1`csoB$+Ig6=dd0g{HD%%HkH{N@sBu=I05`lX)ZAXi~$h6RE75MP}zp6@0%HmBeNe zfMH27$!yxq+M936i76ZC~eSb12fv`ym{~4dt6N0goLj2oYlQK-~GHYrJOxu9z{qE%=5xVc|k=*FZQJ_M3`ygR9%6crl(& z7f#jSnt9c3%lv^qGM<|ZheH$Knz@2A@`f7Mq$U6?2YT?h*3MuMY7 zlteSl^KUIb6MS)h&s1TkNJyx@wj@CitRkTzk+f(M&8?q(^T8&<1GsKrrmttJG}J?0 zn|hNuNyuWQjVFd*+p{#h^I(W$)I^*@194#HuC3 zIzP!H1fLvWB_kya5qG(d;Ndh&I9wP2@Zn<<4hBYWiU=*O5p$Fyc&w0W56|<68~nk2 zJ&G@prZ^J}es<+u>%+lvrr$?V5kRr*;ca%XMj4-wHD0EdPiP`IT_+~R^zSY6*aI)? zRSe*WX^~I>vfzPaq+3vwHmf)}C@s0mUJhYs3vyVB z+@ZuC`BPRTMiA(h4EStZiDL0l;JAiz2cKQ|SY5@+BkpmG1H^3;3fR2>Nss!ml^9l)Y%fDh;F*nHDw zj7UO)LwSiB52+JMSpyQ*32>WFR1_@puW!oJF09W!=5JXeB9cgU%SjI6Xk(=8)6GCf+`0ADq*Tuo;ZRMc5K za%9-eE1Y1E5j{o^dCK@WCjv4f)ecGkelV}uOMSt)V93X*M}aO`*9M`4G&CbS6`C|i z#Dh7`j4pp~M(k5Iba{U;WrjQe%>WUKN1KqG#uAA`U{24DJ$R-8UhXre&4dJ?09#7x zn4p))4ChCdx3%7{{rtF0$}mQ^3KYP~tWHxM-QIeyno$eYUT;7K>DP*M19g^Uk$GJh ytwCqjZJ0Mdl*`7HB})c0)<_zi-Ol0vQ~V2VPte?eu*?|%0000 Date: Sun, 23 Mar 2025 14:31:32 +0100 Subject: [PATCH 08/16] Update .gitignore --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 2e679cf..2e52f7d 100644 --- a/.gitignore +++ b/.gitignore @@ -17,3 +17,4 @@ tmp *.swp .rspec vendor/bundle +.idea/ From b1213e87836c6fa452702a0833a9c4c2709f19c5 Mon Sep 17 00:00:00 2001 From: Igor Zubkov Date: Sun, 23 Mar 2025 14:32:24 +0100 Subject: [PATCH 09/16] Add engine --- lib/errbit_github_plugin/engine.rb | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 lib/errbit_github_plugin/engine.rb diff --git a/lib/errbit_github_plugin/engine.rb b/lib/errbit_github_plugin/engine.rb new file mode 100644 index 0000000..b3fad14 --- /dev/null +++ b/lib/errbit_github_plugin/engine.rb @@ -0,0 +1,11 @@ +# frozen_string_literal: true + +require "rails/engine" + +module ErrbitGithubPlugin + class Engine < ::Rails::Engine + initializer :assets do + Rails.application.config.assets.paths << root.join("app", "assets", "images", "errbit_github_plugin") + end + end +end From d1cd013b0b185adc3a73de816b73ecf27314b82a Mon Sep 17 00:00:00 2001 From: Igor Zubkov Date: Sun, 23 Mar 2025 14:33:04 +0100 Subject: [PATCH 10/16] Require engine --- lib/errbit_github_plugin.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/errbit_github_plugin.rb b/lib/errbit_github_plugin.rb index fcddc1e..1815c19 100644 --- a/lib/errbit_github_plugin.rb +++ b/lib/errbit_github_plugin.rb @@ -1,6 +1,7 @@ require "errbit_github_plugin/version" -require 'errbit_github_plugin/error' -require 'errbit_github_plugin/issue_tracker' +require "errbit_github_plugin/engine" +require "errbit_github_plugin/error" +require "errbit_github_plugin/issue_tracker" module ErrbitGithubPlugin def self.root From 1ad651489cd6907c8ec449eb3b54d38c16d20cfa Mon Sep 17 00:00:00 2001 From: Igor Zubkov Date: Sun, 23 Mar 2025 14:33:47 +0100 Subject: [PATCH 11/16] Remove dead code --- lib/errbit_github_plugin.rb | 7 ------- 1 file changed, 7 deletions(-) diff --git a/lib/errbit_github_plugin.rb b/lib/errbit_github_plugin.rb index 1815c19..528ec84 100644 --- a/lib/errbit_github_plugin.rb +++ b/lib/errbit_github_plugin.rb @@ -4,13 +4,6 @@ require "errbit_github_plugin/issue_tracker" module ErrbitGithubPlugin - def self.root - File.expand_path '../..', __FILE__ - end - - def self.read_static_file(file) - File.read(File.join(self.root, 'static', file)) - end end ErrbitPlugin::Registry.add_issue_tracker(ErrbitGithubPlugin::IssueTracker) From 78542565bd52f596fdff7dfafa8fa1c3b7081242 Mon Sep 17 00:00:00 2001 From: Igor Zubkov Date: Sun, 23 Mar 2025 14:59:30 +0100 Subject: [PATCH 12/16] Cleanup --- lib/errbit_github_plugin/issue_tracker.rb | 8 ++++---- spec/issue_tracker_spec.rb | 18 ++++++------------ 2 files changed, 10 insertions(+), 16 deletions(-) diff --git a/lib/errbit_github_plugin/issue_tracker.rb b/lib/errbit_github_plugin/issue_tracker.rb index 3587972..5e974dd 100644 --- a/lib/errbit_github_plugin/issue_tracker.rb +++ b/lib/errbit_github_plugin/issue_tracker.rb @@ -33,15 +33,15 @@ def self.fields end def self.icons - @icons ||= { + { create: [ - 'image/png', ErrbitGithubPlugin.read_static_file('github_create.png') + 'image/png', 'errbit_github_plugin/github_create.png' ], goto: [ - 'image/png', ErrbitGithubPlugin.read_static_file('github_goto.png'), + 'image/png', 'errbit_github_plugin/github_goto.png' ], inactive: [ - 'image/png', ErrbitGithubPlugin.read_static_file('github_inactive.png'), + 'image/png', 'errbit_github_plugin/github_inactive.png' ] } end diff --git a/spec/issue_tracker_spec.rb b/spec/issue_tracker_spec.rb index 22dd275..6cac720 100644 --- a/spec/issue_tracker_spec.rb +++ b/spec/issue_tracker_spec.rb @@ -20,24 +20,18 @@ describe '.icons' do it 'puts create icon onto the icons' do - expect(described_class.icons[:create][0]).to eq 'image/png' - expect( - described_class.icons[:create][1] - ).to eq ErrbitGithubPlugin.read_static_file('github_create.png') + expect(described_class.icons[:create][0]).to eq('image/png') + expect(described_class.icons[:create][1]).to eq('errbit_github_plugin/github_create.png') end it 'puts goto icon onto the icons' do - expect(described_class.icons[:goto][0]).to eq 'image/png' - expect( - described_class.icons[:goto][1] - ).to eq ErrbitGithubPlugin.read_static_file('github_goto.png') + expect(described_class.icons[:goto][0]).to eq('image/png') + expect(described_class.icons[:goto][1]).to eq('errbit_github_plugin/github_goto.png') end it 'puts inactive icon onto the icons' do - expect(described_class.icons[:inactive][0]).to eq 'image/png' - expect( - described_class.icons[:inactive][1] - ).to eq ErrbitGithubPlugin.read_static_file('github_inactive.png') + expect(described_class.icons[:inactive][0]).to eq('image/png') + expect(described_class.icons[:inactive][1]).to eq('errbit_github_plugin/github_inactive.png') end end From d9e4e174d79cbc3d80eb420ce94e4e37afbafaa8 Mon Sep 17 00:00:00 2001 From: Igor Zubkov Date: Sun, 23 Mar 2025 22:17:22 +0100 Subject: [PATCH 13/16] frozen_string_literal: true --- Gemfile | 2 ++ Rakefile | 2 ++ errbit_github_plugin.gemspec | 3 ++- lib/errbit_github_plugin.rb | 2 ++ lib/errbit_github_plugin/error.rb | 5 ++++- lib/errbit_github_plugin/issue_tracker.rb | 22 +++++++++------------- lib/errbit_github_plugin/version.rb | 2 ++ spec/issue_tracker_spec.rb | 2 ++ spec/spec_helper.rb | 2 ++ 9 files changed, 27 insertions(+), 15 deletions(-) diff --git a/Gemfile b/Gemfile index fa75df1..7f4f5e9 100644 --- a/Gemfile +++ b/Gemfile @@ -1,3 +1,5 @@ +# frozen_string_literal: true + source 'https://rubygems.org' gemspec diff --git a/Rakefile b/Rakefile index 2995527..5263b58 100644 --- a/Rakefile +++ b/Rakefile @@ -1 +1,3 @@ +# frozen_string_literal: true + require "bundler/gem_tasks" diff --git a/errbit_github_plugin.gemspec b/errbit_github_plugin.gemspec index 8fb7f17..f7786bf 100644 --- a/errbit_github_plugin.gemspec +++ b/errbit_github_plugin.gemspec @@ -1,4 +1,5 @@ -# coding: utf-8 +# frozen_string_literal: true + lib = File.expand_path('../lib', __FILE__) $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib) require 'errbit_github_plugin/version' diff --git a/lib/errbit_github_plugin.rb b/lib/errbit_github_plugin.rb index 528ec84..8b752b6 100644 --- a/lib/errbit_github_plugin.rb +++ b/lib/errbit_github_plugin.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "errbit_github_plugin/version" require "errbit_github_plugin/engine" require "errbit_github_plugin/error" diff --git a/lib/errbit_github_plugin/error.rb b/lib/errbit_github_plugin/error.rb index dc8859f..0b1a1f1 100644 --- a/lib/errbit_github_plugin/error.rb +++ b/lib/errbit_github_plugin/error.rb @@ -1,3 +1,6 @@ +# frozen_string_literal: true + module ErrbitGithubPlugin - class AuthenticationError < Exception; end + class AuthenticationError < Exception + end end diff --git a/lib/errbit_github_plugin/issue_tracker.rb b/lib/errbit_github_plugin/issue_tracker.rb index 5e974dd..9de9280 100644 --- a/lib/errbit_github_plugin/issue_tracker.rb +++ b/lib/errbit_github_plugin/issue_tracker.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require 'octokit' module ErrbitGithubPlugin @@ -5,10 +7,10 @@ class IssueTracker < ErrbitPlugin::IssueTracker LABEL = 'github' - NOTE = 'Please configure your github repository in the GITHUB ' << - 'REPO field above.
Instead of providing your ' << - 'username & password, you can link your Github account to your ' << - 'user profile, and allow Errbit to create issues using your ' << + NOTE = 'Please configure your github repository in the GitHub ' + 'repo field above.
Instead of providing your ' + 'username & password, you can link your GitHub account to your ' + 'user profile, and allow Errbit to create issues using your ' 'OAuth token.' FIELDS = { @@ -34,15 +36,9 @@ def self.fields def self.icons { - create: [ - 'image/png', 'errbit_github_plugin/github_create.png' - ], - goto: [ - 'image/png', 'errbit_github_plugin/github_goto.png' - ], - inactive: [ - 'image/png', 'errbit_github_plugin/github_inactive.png' - ] + create: ['image/png', 'errbit_github_plugin/github_create.png'], + goto: ['image/png', 'errbit_github_plugin/github_goto.png'], + inactive: ['image/png', 'errbit_github_plugin/github_inactive.png'] } end diff --git a/lib/errbit_github_plugin/version.rb b/lib/errbit_github_plugin/version.rb index 05c5a27..8e3570d 100644 --- a/lib/errbit_github_plugin/version.rb +++ b/lib/errbit_github_plugin/version.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + module ErrbitGithubPlugin VERSION = '0.3.0' end diff --git a/spec/issue_tracker_spec.rb b/spec/issue_tracker_spec.rb index 6cac720..848b1ed 100644 --- a/spec/issue_tracker_spec.rb +++ b/spec/issue_tracker_spec.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + describe ErrbitGithubPlugin::IssueTracker do describe '.label' do it 'return LABEL' do diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index badea54..ea69401 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + if ENV['COVERAGE'] require 'simplecov' if ENV['CI'] From bbafea577bfa0fc3908e82b57d205993b43b68d0 Mon Sep 17 00:00:00 2001 From: Igor Zubkov Date: Sun, 23 Mar 2025 22:22:49 +0100 Subject: [PATCH 14/16] Bump version --- lib/errbit_github_plugin/version.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/errbit_github_plugin/version.rb b/lib/errbit_github_plugin/version.rb index 8e3570d..6045bea 100644 --- a/lib/errbit_github_plugin/version.rb +++ b/lib/errbit_github_plugin/version.rb @@ -1,5 +1,5 @@ # frozen_string_literal: true module ErrbitGithubPlugin - VERSION = '0.3.0' + VERSION = '0.4.0' end From 855677ff352d2181e313ce50da671f9ce1e46175 Mon Sep 17 00:00:00 2001 From: Igor Zubkov Date: Mon, 24 Mar 2025 00:19:07 +0100 Subject: [PATCH 15/16] Update --- Gemfile.lock | 2 +- app/assets/config/errbit_github_plugin.js | 1 + lib/errbit_github_plugin/issue_tracker.rb | 6 +++--- 3 files changed, 5 insertions(+), 4 deletions(-) create mode 100644 app/assets/config/errbit_github_plugin.js diff --git a/Gemfile.lock b/Gemfile.lock index 894544d..63cf554 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,7 +1,7 @@ PATH remote: . specs: - errbit_github_plugin (0.3.0) + errbit_github_plugin (0.4.0) errbit_plugin octokit railties (>= 6.1.0) diff --git a/app/assets/config/errbit_github_plugin.js b/app/assets/config/errbit_github_plugin.js new file mode 100644 index 0000000..ac907b3 --- /dev/null +++ b/app/assets/config/errbit_github_plugin.js @@ -0,0 +1 @@ +//= link_tree ../images diff --git a/lib/errbit_github_plugin/issue_tracker.rb b/lib/errbit_github_plugin/issue_tracker.rb index 9de9280..07cc18f 100644 --- a/lib/errbit_github_plugin/issue_tracker.rb +++ b/lib/errbit_github_plugin/issue_tracker.rb @@ -36,9 +36,9 @@ def self.fields def self.icons { - create: ['image/png', 'errbit_github_plugin/github_create.png'], - goto: ['image/png', 'errbit_github_plugin/github_goto.png'], - inactive: ['image/png', 'errbit_github_plugin/github_inactive.png'] + create: "github_create.png", + goto: "github_goto.png", + inactive: "github_inactive.png" } end From 65234952ca80f0c5df0cbf077a36eaba86fa7ba6 Mon Sep 17 00:00:00 2001 From: Igor Zubkov Date: Mon, 24 Mar 2025 00:20:13 +0100 Subject: [PATCH 16/16] Update --- spec/issue_tracker_spec.rb | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/spec/issue_tracker_spec.rb b/spec/issue_tracker_spec.rb index 848b1ed..1fb144b 100644 --- a/spec/issue_tracker_spec.rb +++ b/spec/issue_tracker_spec.rb @@ -22,18 +22,15 @@ describe '.icons' do it 'puts create icon onto the icons' do - expect(described_class.icons[:create][0]).to eq('image/png') - expect(described_class.icons[:create][1]).to eq('errbit_github_plugin/github_create.png') + expect(described_class.icons[:create]).to eq('github_create.png') end it 'puts goto icon onto the icons' do - expect(described_class.icons[:goto][0]).to eq('image/png') - expect(described_class.icons[:goto][1]).to eq('errbit_github_plugin/github_goto.png') + expect(described_class.icons[:goto]).to eq('github_goto.png') end it 'puts inactive icon onto the icons' do - expect(described_class.icons[:inactive][0]).to eq('image/png') - expect(described_class.icons[:inactive][1]).to eq('errbit_github_plugin/github_inactive.png') + expect(described_class.icons[:inactive]).to eq('github_inactive.png') end end