Remove +constraint method

Most constraints now require init values, so having `+constraint` is relatively useless.

Author: dmaclach

Source/OCMock/NSInvocation+OCMAdditions.m

@@ -20,7 +20,7 @@
 #import "NSInvocation+OCMAdditions.h"
 #import "OCMFunctionsPrivate.h"
 #import "NSMethodSignature+OCMAdditions.h"
-
+#import "OCMConstraint.h"
 
 #if (TARGET_OS_OSX && (!defined(__MAC_10_10) || __MAC_OS_X_VERSION_MIN_REQUIRED < __MAC_10_10)) || \
     (TARGET_OS_IPHONE && (!defined(__IPHONE_8_0) || __IPHONE_OS_VERSION_MIN_REQUIRED < __IPHONE_8_0))

Source/OCMock/OCMArg.m

@@ -25,7 +25,7 @@ @implementation OCMArg
 
 + (id)any
 {
-	return [OCMAnyConstraint constraint];
+	return [[[OCMAnyConstraint alloc] init] autorelease];
 }
 
 + (void *)anyPointer

Source/OCMock/OCMConstraint.h

@@ -19,7 +19,6 @@
 
 @interface OCMConstraint : NSObject 
 
-+ (instancetype)constraint;
 - (BOOL)evaluate:(id)value;
 
 // if you are looking for any, isNil, etc, they have moved to OCMArg

Source/OCMock/OCMConstraint.m

@@ -19,11 +19,6 @@
 
 @implementation OCMConstraint
 
-+ (instancetype)constraint
-{
-	return [[[self alloc] init] autorelease];
-}
-
 - (BOOL)evaluate:(id)value
 {
 	return NO;

Source/OCMockTests/OCMConstraintTests.m

@@ -47,7 +47,7 @@ - (void)setUp
 
 - (void)testAnyAcceptsAnything
 {
-	OCMConstraint *constraint = [OCMAnyConstraint constraint];
+	OCMConstraint *constraint = [[OCMAnyConstraint alloc] init];
 	XCTAssertTrue([constraint evaluate:@"foo"], @"Should have accepted a value.");
 	XCTAssertTrue([constraint evaluate:@"bar"], @"Should have accepted another value.");
 	XCTAssertTrue([constraint evaluate:nil], @"Should have accepted nil.");