Remove +constraint method

Most constraints now require init values, so having `+constraint` is relatively useless.

Author: dmaclach

Source/OCMock/NSInvocation+OCMAdditions.m

@@ -18,6 +18,7 @@
 #import "NSInvocation+OCMAdditions.h"
 #import "NSMethodSignature+OCMAdditions.h"
 #import "OCMArg.h"
+#import "OCMConstraint.h"
 #import "OCMFunctionsPrivate.h"
 
 #if(TARGET_OS_OSX && (!defined(__MAC_10_10) || __MAC_OS_X_VERSION_MIN_REQUIRED < __MAC_10_10)) ||                                  \

Source/OCMock/OCMArg.m

@@ -25,7 +25,7 @@ @implementation OCMArg
 
 + (id)any
 {
-    return [OCMAnyConstraint constraint];
+    return [[[OCMAnyConstraint alloc] init] autorelease];
 }
 
 + (void *)anyPointer
@@ -45,12 +45,12 @@ + (SEL)anySelector
 
 + (id)isNil
 {
-    return [OCMIsNilConstraint constraint];
+    return [[OCMIsNilConstraint alloc] init];
 }
 
 + (id)isNotNil
 {
-    return [OCMIsNotNilConstraint constraint];
+    return [[OCMIsNotNilConstraint alloc] init];
 }
 
 + (id)isEqual:(id)value

Source/OCMock/OCMConstraint.h

@@ -18,7 +18,6 @@
 
 @interface OCMConstraint : NSObject
 
-+ (instancetype)constraint;
 - (BOOL)evaluate:(id)value;
 
 // if you are looking for any, isNil, etc, they have moved to OCMArg

Source/OCMock/OCMConstraint.m

@@ -20,11 +20,6 @@
 
 @implementation OCMConstraint
 
-+ (instancetype)constraint
-{
-    return [[[self alloc] init] autorelease];
-}
-
 - (BOOL)evaluate:(id)value
 {
     return NO;

Source/OCMockTests/OCMConstraintTests.m

@@ -47,23 +47,23 @@ - (void)setUp
 
 - (void)testAnyAcceptsAnything
 {
-    OCMConstraint *constraint = [OCMAnyConstraint constraint];
+    OCMConstraint *constraint = [[OCMAnyConstraint alloc] init];
     XCTAssertTrue([constraint evaluate:@"foo"], @"Should have accepted a value.");
     XCTAssertTrue([constraint evaluate:@"bar"], @"Should have accepted another value.");
     XCTAssertTrue([constraint evaluate:nil], @"Should have accepted nil.");
 }
 
 - (void)testIsNilAcceptsOnlyNil
 {
-    OCMConstraint *constraint = [OCMIsNilConstraint constraint];
+    OCMConstraint *constraint = [[OCMIsNilConstraint alloc] init];
 
     XCTAssertFalse([constraint evaluate:@"foo"], @"Should not have accepted a value.");
     XCTAssertTrue([constraint evaluate:nil], @"Should have accepted nil.");
 }
 
 - (void)testIsNotNilAcceptsAnythingButNil
 {
-    OCMConstraint *constraint = [OCMIsNotNilConstraint constraint];
+    OCMConstraint *constraint = [[OCMIsNotNilConstraint alloc] init];
 
     XCTAssertTrue([constraint evaluate:@"foo"], @"Should have accepted a value.");
     XCTAssertFalse([constraint evaluate:nil], @"Should not have accepted nil.");