Issue 65: replace lodash with native/sublibs (#73)

* use alternatives to lodash

* prettier

* remove lodash

* use reduce

* slice and pop

* lint, reduce and format

Author: mikeguta

__tests__/decorators.test.ts

@@ -1,4 +1,3 @@
-import * as _ from 'lodash'
 import {
   ContentType,
   Controller,
@@ -19,8 +18,12 @@ import {
 } from '../src'
 import { ModelDto } from './fixtures/models'
 
+type IndexedRoutes = {
+  [method: string]: IRoute
+}
+
 describe('decorators', () => {
-  let routes: { [method: string]: IRoute }
+  let routes: IndexedRoutes
 
   beforeEach(() => {
     getMetadataArgsStorage().reset()
@@ -219,7 +222,10 @@ describe('decorators', () => {
       }
     }
 
-    routes = _.keyBy(parseRoutes(getMetadataArgsStorage()), 'action.method')
+    routes = parseRoutes(getMetadataArgsStorage()).reduce((acc, route) => {
+      acc[route.action.method] = route
+      return acc
+    }, {} as IndexedRoutes)
   })
 
   it('merges keywords defined in @OpenAPI decorator into operation', () => {
@@ -591,7 +597,7 @@ describe('decorators', () => {
 })
 
 describe('@OpenAPI-decorated class', () => {
-  let routes: { [method: string]: IRoute }
+  let routes: IndexedRoutes
 
   beforeEach(() => {
     getMetadataArgsStorage().reset()
@@ -622,7 +628,10 @@ describe('@OpenAPI-decorated class', () => {
       }
     }
 
-    routes = _.keyBy(parseRoutes(getMetadataArgsStorage()), 'action.method')
+    routes = parseRoutes(getMetadataArgsStorage()).reduce((acc, route) => {
+      acc[route.action.method] = route
+      return acc
+    }, {} as IndexedRoutes)
   })
 
   it('applies controller OpenAPI props to each method with method-specific props taking precedence', () => {

__tests__/index.test.ts

@@ -1,7 +1,7 @@
 // tslint:disable:no-implicit-dependencies no-submodule-imports
 const { defaultMetadataStorage } = require('class-transformer/cjs/storage')
 import { validationMetadatasToSchemas } from 'class-validator-jsonschema'
-import * as _ from 'lodash'
+import _merge from 'lodash.merge'
 import { getMetadataArgsStorage } from 'routing-controllers'
 
 import {
@@ -144,7 +144,7 @@ describe('index', () => {
   })
 
   it('gets full OpenAPI-formatted paths', () => {
-    const route = _.cloneDeep(routes[0])
+    const route = _merge({}, routes[0])
     expect(getFullPath(route)).toEqual('/api/users/')
 
     route.options.routePrefix = undefined
@@ -178,7 +178,7 @@ describe('index', () => {
   })
 
   it('gets OpenAPI Operation IDs', () => {
-    const route = _.cloneDeep(routes[0])
+    const route = _merge({}, routes[0])
     expect(getOperationId(route)).toEqual('UsersController.listUsers')
 
     route.action.target = class AnotherController {}

__tests__/parameters.test.ts

@@ -1,4 +1,3 @@
-import * as _ from 'lodash'
 import {
   Get,
   getMetadataArgsStorage,
@@ -150,7 +149,7 @@ describe('parameters', () => {
   })
 
   it('ignores @Param if corresponding name is not found in path string', () => {
-    expect(_.filter(getPathParams(route), { name: 'invalid' })).toEqual([])
+    expect(getPathParams(route).filter((r) => r.name === 'invalid')).toEqual([])
   })
 
   it('parses query param from @QueryParam decorator', () => {

package-lock.json

@@ -29,7 +29,9 @@
     "singleQuote": true
   },
   "dependencies": {
-    "lodash": "^4.17.15",
+    "lodash.merge": "^4.6.2",
+    "lodash.capitalize": "^4.2.1",
+    "lodash.startcase": "^4.4.0",
     "openapi3-ts": "^2.0.1",
     "path-to-regexp": "^2.2.1",
     "reflect-metadata": "^0.1.13",
@@ -38,7 +40,9 @@
   "devDependencies": {
     "@team-griffin/install-self-peers": "^1.1.1",
     "@types/jest": "^26.0.20",
-    "@types/lodash": "^4.14.168",
+    "@types/lodash.merge": "^4.6.6",
+    "@types/lodash.capitalize": "^4.2.6",
+    "@types/lodash.startcase": "^4.4.6",
     "@types/node": "^13.13.46",
     "@types/prettier": "^2.2.2",
     "@types/reflect-metadata": "^0.1.0",

package.json

@@ -1,4 +1,4 @@
-import * as _ from 'lodash'
+import _merge from 'lodash.merge'
 import {
   OperationObject,
   ReferenceObject,
@@ -53,9 +53,9 @@ export function applyOpenAPIDecorator(
   ]
 
   return openAPIParams.reduce((acc: OperationObject, oaParam: OpenAPIParam) => {
-    return _.isFunction(oaParam)
+    return typeof oaParam === 'function'
       ? oaParam(acc, route)
-      : _.merge({}, acc, oaParam)
+      : _merge({}, acc, oaParam)
   }, originalOperation) as OperationObject
 }
 
@@ -134,7 +134,7 @@ export function ResponseSchema(
 
       if (oldSchema?.$ref || oldSchema?.items || oldSchema?.oneOf) {
         // case where we're adding multiple schemas under single statuscode/contentType
-        const newStatusCodeResponse = _.merge(
+        const newStatusCodeResponse = _merge(
           {},
           source.responses[statusCode],
           responses[statusCode]
@@ -150,7 +150,7 @@ export function ResponseSchema(
         return source
       }
 
-      return _.merge({}, source, { responses })
+      return _merge({}, source, { responses })
     }
 
     return source