Skip to content

Commit 3fd81ed

Browse files
authored
[web] Don't add webparagraph suite to CI (flutter#177681)
Fix `generate-builder-json` to only include test bundles that are needed by enabled test suites. ## Before this PR The script was unconditionally including all test bundles in CI. The result is that the `dart2js-canvaskit-experimental-webparagraph` bundle was being generated, even though it was only required by the `chrome-dart2js-experimental-webparagraph-ui` suite, which had `enable-ci: false`. ## After this PR The script starts by finding all test suites with `enable-ci: true`, then only adds the bundles required by those suites.
1 parent 1444c28 commit 3fd81ed

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

engine/src/flutter/lib/web_ui/dev/generate_builder_json.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,12 @@ class GenerateBuilderJsonCommand extends Command<bool> {
2828
final FeltConfig config = FeltConfig.fromFile(
2929
path.join(environment.webUiTestDir.path, 'felt_config.yaml'),
3030
);
31+
final List<TestSuite> testSuites = config.testSuites.where((suite) => suite.enableCi).toList();
32+
final Iterable<TestBundle> testBundles = testSuites.map((suite) => suite.testBundle).toSet();
3133
_writeBuilderJson(
3234
_generateBuilderJson(
33-
config.testBundles.map((TestBundle bundle) => _getBundleBuildStep(bundle)).toList(),
34-
_getAllTestSteps(config.testSuites, packageLock),
35+
testBundles.map((TestBundle bundle) => _getBundleBuildStep(bundle)).toList(),
36+
_getAllTestSteps(testSuites, packageLock),
3537
),
3638
'linux_web_engine_test.json',
3739
);
@@ -114,9 +116,7 @@ class GenerateBuilderJsonCommand extends Command<bool> {
114116
String? specificOS,
115117
String? cpu,
116118
}) {
117-
final filteredSuites = suites.where(
118-
(suite) => suite.enableCi && suite.runConfig.browser == browser,
119-
);
119+
final filteredSuites = suites.where((suite) => suite.runConfig.browser == browser);
120120
final bundles = filteredSuites.map((suite) => suite.testBundle).toSet();
121121
return <String, dynamic>{
122122
'name': '$platform run ${browser.name} suites',

0 commit comments

Comments
 (0)