Changed form-group to mb-3

smithdc1 · smithdc1 · commit 06732f600eac · 2020-07-11T21:12:19.000+01:00
* form-group is deprecated in bootstrap 5 and is replaced by utility classes.
diff --git a/rest_framework/templates/rest_framework/filters/search.html b/rest_framework/templates/rest_framework/filters/search.html
@@ -1,7 +1,7 @@
 {% load i18n %}
 <h2>{% trans "Search" %}</h2>
 <form class="form-inline">
-  <div class="form-group">
+  <div class="mb-3">
     <div class="input-group">
       <input type="text" class="form-control" style="width: 350px" name="{{ param }}" value="{{ term }}">
       <span class="input-group-btn">
diff --git a/rest_framework/templates/rest_framework/horizontal/checkbox.html b/rest_framework/templates/rest_framework/horizontal/checkbox.html
@@ -1,4 +1,4 @@
-<div class="form-group horizontal-checkbox {% if field.errors %}has-error{% endif %}">
+<div class="mb-3 horizontal-checkbox {% if field.errors %}has-error{% endif %}">
   {% if field.label %}
     <label class="col-sm-2 control-label {% if style.hide_label %}sr-only{% endif %}">
       {{ field.label }}
diff --git a/rest_framework/templates/rest_framework/horizontal/checkbox_multiple.html b/rest_framework/templates/rest_framework/horizontal/checkbox_multiple.html
@@ -1,6 +1,6 @@
 {% load rest_framework %}
 
-<div class="form-group">
+<div class="mb-3">
   {% if field.label %}
     <label class="col-sm-2 control-label {% if style.hide_label %}sr-only{% endif %}">
       {{ field.label }}
diff --git a/rest_framework/templates/rest_framework/horizontal/dict_field.html b/rest_framework/templates/rest_framework/horizontal/dict_field.html
@@ -1,4 +1,4 @@
-<div class="form-group">
+<div class="mb-3">
   {% if field.label %}
     <label class="col-sm-2 control-label {% if style.hide_label %}sr-only{% endif %}">
       {{ field.label }}
diff --git a/rest_framework/templates/rest_framework/horizontal/fieldset.html b/rest_framework/templates/rest_framework/horizontal/fieldset.html
@@ -1,7 +1,7 @@
 {% load rest_framework %}
 <fieldset>
   {% if field.label %}
-    <div class="form-group" style="border-bottom: 1px solid #e5e5e5">
+    <div class="mb-3" style="border-bottom: 1px solid #e5e5e5">
       <legend class="control-label col-sm-2 {% if style.hide_label %}sr-only{% endif %}" style="border-bottom: 0">
         {{ field.label }}
       </legend>
diff --git a/rest_framework/templates/rest_framework/horizontal/input.html b/rest_framework/templates/rest_framework/horizontal/input.html
@@ -1,4 +1,4 @@
-<div class="form-group {% if field.errors %}has-error{% endif %}">
+<div class="mb-3 {% if field.errors %}has-error{% endif %}">
   {% if field.label %}
     <label class="col-sm-2 control-label {% if style.hide_label %}sr-only{% endif %}">
       {{ field.label }}
diff --git a/rest_framework/templates/rest_framework/horizontal/list_field.html b/rest_framework/templates/rest_framework/horizontal/list_field.html
@@ -1,4 +1,4 @@
-<div class="form-group">
+<div class="mb-3">
   {% if field.label %}
     <label class="col-sm-2 control-label {% if style.hide_label %}sr-only{% endif %}">
       {{ field.label }}
diff --git a/rest_framework/templates/rest_framework/horizontal/list_fieldset.html b/rest_framework/templates/rest_framework/horizontal/list_fieldset.html
@@ -2,7 +2,7 @@
 
 <fieldset>
   {% if field.label %}
-    <div class="form-group" style="border-bottom: 1px solid #e5e5e5">
+    <div class="mb-3" style="border-bottom: 1px solid #e5e5e5">
       <legend class="control-label col-sm-2 {% if style.hide_label %}sr-only{% endif %}" style="border-bottom: 0">
         {{ field.label }}
       </legend>
diff --git a/rest_framework/templates/rest_framework/horizontal/radio.html b/rest_framework/templates/rest_framework/horizontal/radio.html
@@ -3,7 +3,7 @@
 
 {% trans "None" as none_choice %}
 
-<div class="form-group">
+<div class="mb-3">
   {% if field.label %}
     <label class="col-sm-2 control-label {% if style.hide_label %}sr-only{% endif %}">
       {{ field.label }}
diff --git a/rest_framework/templates/rest_framework/horizontal/select.html b/rest_framework/templates/rest_framework/horizontal/select.html
@@ -1,6 +1,6 @@
 {% load rest_framework %}
 
-<div class="form-group">
+<div class="mb-3">
   {% if field.label %}
     <label class="col-sm-2 control-label {% if style.hide_label %}sr-only{% endif %}">
       {{ field.label }}
diff --git a/rest_framework/templates/rest_framework/horizontal/select_multiple.html b/rest_framework/templates/rest_framework/horizontal/select_multiple.html
@@ -3,7 +3,7 @@
 
 {% trans "No items to select." as no_items %}
 
-<div class="form-group">
+<div class="mb-3">
   {% if field.label %}
     <label class="col-sm-2 control-label {% if style.hide_label %}sr-only{% endif %}">
       {{ field.label }}
diff --git a/rest_framework/templates/rest_framework/horizontal/textarea.html b/rest_framework/templates/rest_framework/horizontal/textarea.html
@@ -1,4 +1,4 @@
-<div class="form-group {% if field.errors %}has-error{% endif %}">
+<div class="mb-3 {% if field.errors %}has-error{% endif %}">
   {% if field.label %}
     <label class="col-sm-2 control-label {% if style.hide_label %}sr-only{% endif %}">
       {{ field.label }}
diff --git a/rest_framework/templates/rest_framework/inline/checkbox.html b/rest_framework/templates/rest_framework/inline/checkbox.html
@@ -1,4 +1,4 @@
-<div class="form-group {% if field.errors %}has-error{% endif %}">
+<div class="mb-3 {% if field.errors %}has-error{% endif %}">
   <div class="checkbox">
     <label>
       <input type="checkbox" name="{{ field.name }}" value="true" {% if field.value %}checked{% endif %}>
diff --git a/rest_framework/templates/rest_framework/inline/checkbox_multiple.html b/rest_framework/templates/rest_framework/inline/checkbox_multiple.html
@@ -1,6 +1,6 @@
 {% load rest_framework %}
 
-<div class="form-group {% if field.errors %}has-error{% endif %}">
+<div class="mb-3 {% if field.errors %}has-error{% endif %}">
   {% if field.label %}
     <label class="sr-only">{{ field.label }}</label>
   {% endif %}
diff --git a/rest_framework/templates/rest_framework/inline/dict_field.html b/rest_framework/templates/rest_framework/inline/dict_field.html
@@ -1,4 +1,4 @@
-<div class="form-group">
+<div class="mb-3">
   {% if field.label %}
     <label class="sr-only">
       {{ field.label }}
diff --git a/rest_framework/templates/rest_framework/inline/input.html b/rest_framework/templates/rest_framework/inline/input.html
@@ -1,4 +1,4 @@
-<div class="form-group {% if field.errors %}has-error{% endif %}">
+<div class="mb-3 {% if field.errors %}has-error{% endif %}">
   {% if field.label %}
     <label class="sr-only">
       {{ field.label }}
diff --git a/rest_framework/templates/rest_framework/inline/list_field.html b/rest_framework/templates/rest_framework/inline/list_field.html
@@ -1,4 +1,4 @@
-<div class="form-group">
+<div class="mb-3">
   {% if field.label %}
     <label class="sr-only">
       {{ field.label }}
diff --git a/rest_framework/templates/rest_framework/inline/radio.html b/rest_framework/templates/rest_framework/inline/radio.html
@@ -2,7 +2,7 @@
 {% load rest_framework %}
 {% trans "None" as none_choice %}
 
-<div class="form-group {% if field.errors %}has-error{% endif %}">
+<div class="mb-3 {% if field.errors %}has-error{% endif %}">
   {% if field.label %}
     <label class="sr-only">
       {{ field.label }}
diff --git a/rest_framework/templates/rest_framework/inline/select.html b/rest_framework/templates/rest_framework/inline/select.html
@@ -1,6 +1,6 @@
 {% load rest_framework %}
 
-<div class="form-group {% if field.errors %}has-error{% endif %}">
+<div class="mb-3 {% if field.errors %}has-error{% endif %}">
   {% if field.label %}
     <label class="sr-only">
       {{ field.label }}
diff --git a/rest_framework/templates/rest_framework/inline/select_multiple.html b/rest_framework/templates/rest_framework/inline/select_multiple.html
@@ -2,7 +2,7 @@
 {% load rest_framework %}
 {% trans "No items to select." as no_items %}
 
-<div class="form-group {% if field.errors %}has-error{% endif %}">
+<div class="mb-3 {% if field.errors %}has-error{% endif %}">
   {% if field.label %}
     <label class="sr-only">
       {{ field.label }}
diff --git a/rest_framework/templates/rest_framework/inline/textarea.html b/rest_framework/templates/rest_framework/inline/textarea.html
@@ -1,4 +1,4 @@
-<div class="form-group {% if field.errors %}has-error{% endif %}">
+<div class="mb-3 {% if field.errors %}has-error{% endif %}">
   {% if field.label %}
     <label class="sr-only">
       {{ field.label }}
diff --git a/rest_framework/templates/rest_framework/login_base.html b/rest_framework/templates/rest_framework/login_base.html
@@ -19,7 +19,7 @@
               <input type="hidden" name="next" value="{{ next }}" />
 
               <div id="div_id_username" class="clearfix control-group {% if form.username.errors %}error{% endif %}">
-                <div class="form-group">
+                <div class="mb-3">
                   <label for="id_username">{{ form.username.label }}:</label>
                   <input type="text" name="username" maxlength="100"
                       autocapitalize="off"
@@ -35,7 +35,7 @@
               </div>
 
               <div id="div_id_password" class="clearfix control-group {% if form.password.errors %}error{% endif %}">
-                <div class="form-group">
+                <div class="mb-3">
                   <label for="id_password">{{ form.password.label }}:</label>
                   <input type="password" name="password" maxlength="100" autocapitalize="off" autocorrect="off" class="form-control textinput textInput" id="id_password" required>
                   {% if form.password.errors %}
diff --git a/rest_framework/templates/rest_framework/vertical/checkbox.html b/rest_framework/templates/rest_framework/vertical/checkbox.html
@@ -1,4 +1,4 @@
-<div class="form-group {% if field.errors %}has-error{% endif %}">
+<div class="mb-3 {% if field.errors %}has-error{% endif %}">
   <div class="checkbox">
     <label>
       <input type="checkbox" name="{{ field.name }}" value="true" {% if field.value %}checked{% endif %}>
diff --git a/rest_framework/templates/rest_framework/vertical/checkbox_multiple.html b/rest_framework/templates/rest_framework/vertical/checkbox_multiple.html
@@ -1,6 +1,6 @@
 {% load rest_framework %}
 
-<div class="form-group {% if field.errors %}has-error{% endif %}">
+<div class="mb-3 {% if field.errors %}has-error{% endif %}">
   {% if field.label %}
     <label {% if style.hide_label %}class="sr-only"{% endif %}>{{ field.label }}</label>
   {% endif %}
diff --git a/rest_framework/templates/rest_framework/vertical/dict_field.html b/rest_framework/templates/rest_framework/vertical/dict_field.html
@@ -1,4 +1,4 @@
-<div class="form-group">
+<div class="mb-3">
   {% if field.label %}
     <label {% if style.hide_label %}class="sr-only"{% endif %}>{{ field.label }}</label>
   {% endif %}
diff --git a/rest_framework/templates/rest_framework/vertical/input.html b/rest_framework/templates/rest_framework/vertical/input.html
@@ -1,4 +1,4 @@
-<div class="form-group {% if field.errors %}has-error{% endif %}">
+<div class="mb-3 {% if field.errors %}has-error{% endif %}">
   {% if field.label %}
     <label {% if style.hide_label %}class="sr-only"{% endif %}>{{ field.label }}</label>
   {% endif %}
diff --git a/rest_framework/templates/rest_framework/vertical/list_field.html b/rest_framework/templates/rest_framework/vertical/list_field.html
@@ -1,4 +1,4 @@
-<div class="form-group">
+<div class="mb-3">
   {% if field.label %}
     <label {% if style.hide_label %}class="sr-only"{% endif %}>{{ field.label }}</label>
   {% endif %}
diff --git a/rest_framework/templates/rest_framework/vertical/radio.html b/rest_framework/templates/rest_framework/vertical/radio.html
@@ -2,7 +2,7 @@
 {% load rest_framework %}
 {% trans "None" as none_choice %}
 
-<div class="form-group {% if field.errors %}has-error{% endif %}">
+<div class="mb-3 {% if field.errors %}has-error{% endif %}">
   {% if field.label %}
     <label {% if style.hide_label %}class="sr-only"{% endif %}>
       {{ field.label }}
diff --git a/rest_framework/templates/rest_framework/vertical/select.html b/rest_framework/templates/rest_framework/vertical/select.html
@@ -1,6 +1,6 @@
 {% load rest_framework %}
 
-<div class="form-group {% if field.errors %}has-error{% endif %}">
+<div class="mb-3 {% if field.errors %}has-error{% endif %}">
   {% if field.label %}
     <label {% if style.hide_label %}class="sr-only"{% endif %}>
       {{ field.label }}
diff --git a/rest_framework/templates/rest_framework/vertical/select_multiple.html b/rest_framework/templates/rest_framework/vertical/select_multiple.html
@@ -2,7 +2,7 @@
 {% load rest_framework %}
 {% trans "No items to select." as no_items %}
 
-<div class="form-group {% if field.errors %}has-error{% endif %}">
+<div class="mb-3 {% if field.errors %}has-error{% endif %}">
   {% if field.label %}
     <label {% if style.hide_label %}class="sr-only"{% endif %}>
       {{ field.label }}
diff --git a/rest_framework/templates/rest_framework/vertical/textarea.html b/rest_framework/templates/rest_framework/vertical/textarea.html
@@ -1,4 +1,4 @@
-<div class="form-group {% if field.errors %}has-error{% endif %}">
+<div class="mb-3 {% if field.errors %}has-error{% endif %}">
   {% if field.label %}
     <label {% if style.hide_label %}class="sr-only"{% endif %}>
       {{ field.label }}
diff --git a/tests/test_bound_fields.py b/tests/test_bound_fields.py
@@ -78,7 +78,7 @@ class ExampleSerializer(serializers.Serializer):
         renderer = HTMLFormRenderer()
         rendered = renderer.render_field(serializer['bool_field'], {})
         expected_packed = (
-            '<divclass="form-group">'
+            '<divclass="mb-3">'
             '<divclass="checkbox">'
             '<label>'
             '<inputtype="checkbox"name="bool_field"value="true"checked>'
@@ -149,12 +149,12 @@ class ExampleSerializer(serializers.Serializer):
                 '<legend>Nested2</legend>'
                 '<fieldset>'
                 '<legend>Nested1</legend>'
-                '<divclass="form-group">'
+                '<divclass="mb-3">'
                 '<label>Textfield</label>'
                 '<inputname="nested2.nested1.text_field"class="form-control"type="text"value="">'
                 '</div>'
                 '</fieldset>'
-                '<divclass="form-group">'
+                '<divclass="mb-3">'
                 '<label>Textfield</label>'
                 '<inputname="nested2.text_field"class="form-control"type="text"value="test">'
                 '</div>'

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<div class="form-group horizontal-checkbox {% if field.errors %}has-error{% endif %}">`
	`1`	`+<div class="mb-3 horizontal-checkbox {% if field.errors %}has-error{% endif %}">`
`2`	`2`	`{% if field.label %}`
`3`	`3`	`<label class="col-sm-2 control-label {% if style.hide_label %}sr-only{% endif %}">`
`4`	`4`	`{{ field.label }}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<div class="form-group">`
	`1`	`+<div class="mb-3">`
`2`	`2`	`{% if field.label %}`
`3`	`3`	`<label class="col-sm-2 control-label {% if style.hide_label %}sr-only{% endif %}">`
`4`	`4`	`{{ field.label }}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<div class="form-group {% if field.errors %}has-error{% endif %}">`
	`1`	`+<div class="mb-3 {% if field.errors %}has-error{% endif %}">`
`2`	`2`	`{% if field.label %}`
`3`	`3`	`<label class="col-sm-2 control-label {% if style.hide_label %}sr-only{% endif %}">`
`4`	`4`	`{{ field.label }}`