Skip to content

Commit de3e4e7

Browse files
authored
Skip sanity tests on Windows that are hardcoded to be Linux/Unix-specific. (#25758)
Cleans up some of the `sanity` failures on Windows: http://clbri.com:8010/api/v2/logs/189941/raw_inline
1 parent 36d6f60 commit de3e4e7

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

test/test_sanity.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
path_from_root,
2424
test_file,
2525
)
26-
from decorators import crossplatform, parameterized, with_env_modify
26+
from decorators import crossplatform, no_windows, parameterized, with_env_modify
2727

2828
from tools import cache, ports, response_file, shared, utils
2929
from tools.config import EM_CONFIG
@@ -238,6 +238,7 @@ def make_new_executable(name):
238238
finally:
239239
delete_file(default_config)
240240

241+
@no_windows('Test relies on Unix-specific make_fake_tool')
241242
def test_llvm(self):
242243
LLVM_WARNING = 'LLVM version for clang executable'
243244

@@ -423,6 +424,7 @@ def test_cache_clearing_manual(self):
423424
self.assertIn(SANITY_MESSAGE, output)
424425
self.assertCacheEmpty()
425426

427+
@no_windows('Test relies on Unix-specific make_fake_tool')
426428
def test_cache_clearing_auto(self):
427429
# Changing LLVM_ROOT, even without altering .emscripten, clears the cache
428430
restore_and_set_up()
@@ -640,6 +642,7 @@ def test():
640642
build()
641643
test()
642644

645+
@no_windows('Test relies on Unix-specific make_fake_tool')
643646
def test_vanilla(self):
644647
restore_and_set_up()
645648
self.clear_cache()
@@ -664,6 +667,7 @@ def test_with_fake(report, expected):
664667
test_with_fake('got js backend! JavaScript (asm.js, emscripten) backend', 'LLVM has not been built with the WebAssembly backend')
665668
delete_dir(shared.CANONICAL_TEMP_DIR)
666669

670+
@no_windows('Test relies on Unix-specific make_fake_tool')
667671
def test_llvm_add_version(self):
668672
restore_and_set_up()
669673

@@ -690,6 +694,7 @@ def test_required_config_settings(self):
690694
open(EM_CONFIG, 'a').write('\ndel BINARYEN_ROOT\n')
691695
self.check_working([EMCC, test_file('hello_world.c')], 'BINARYEN_ROOT not set in config (%s), and `wasm-opt` not found in PATH' % EM_CONFIG)
692696

697+
@no_windows('Test relies on Unix-specific make_fake_tool')
693698
def test_empty_config(self):
694699
restore_and_set_up()
695700
make_fake_tool(self.in_dir('fake', 'wasm-opt'), 'foo')
@@ -700,6 +705,7 @@ def test_empty_config(self):
700705
with env_modify({'PATH': self.in_dir('fake') + os.pathsep + os.environ['PATH']}):
701706
self.check_working([EMCC])
702707

708+
@no_windows('Test relies on Unix-specific make_fake_tool')
703709
def test_missing_config(self):
704710
restore_and_set_up()
705711
make_fake_tool(self.in_dir('fake', 'wasm-opt'), 'foo')
@@ -787,6 +793,7 @@ def test_embuilder_transitive_pic(self):
787793
self.run_process([EMBUILDER, '--pic', 'clear', 'sdl2*'])
788794
self.run_process([EMCC, '-sMAIN_MODULE=2', '-sUSE_SDL=2', '-sUSE_SDL_GFX=2', test_file('hello_world.c')])
789795

796+
@no_windows('Test relies on Unix-specific make_fake_tool')
790797
def test_binaryen_version(self):
791798
restore_and_set_up()
792799
with open(EM_CONFIG, 'a') as f:

0 commit comments

Comments
 (0)