Add error handling for stderrno when errno is invalid

Author: google-yfyang

system/lib/libc/musl/src/errno/__strerror.h

@@ -3,7 +3,9 @@
  * with these messages, and then to define a lookup table translating
  * error codes to offsets of corresponding fields in the structure. */
 #if defined(__EMSCRIPTEN__)
-// This is intended to match the errno in llvm-libc.
+/* Error handling is introduced to match the behavior in llvm-libc.
+ * When invalid errno is specified, Unknown error: errno_code is emitted.
+ */
 E(0,            "Success")
 #else
 E(0,            "No error information")

system/lib/libc/musl/src/errno/strerror.c

@@ -34,15 +34,21 @@ char *__strerror_l(int e, locale_t loc)
 	if (e==EDQUOT) e=0;
 	else if (e==EDQUOT_ORIG) e=EDQUOT;
 #endif
-	if (e >= sizeof errmsgidx / sizeof *errmsgidx) e = 0;
-	s = (char *)&errmsgstr + errmsgidx[e];
 #ifdef __EMSCRIPTEN__
+	if (e < 0 || e >= sizeof errmsgidx / sizeof *errmsgidx || (e != 0 && !errmsgidx[e])) {
+		static char buf[32];
+		snprintf(buf, sizeof buf, "Unknown error %d", e);
+		return buf;
+	}
+	s = (char *)&errmsgstr + errmsgidx[e];
 	// strerror is a (debug) dependency of many emscripten syscalls which mean it
 	// must be excluded from LTO, along with all of its dependencies.
 	// In order to limit the transitive dependencies we disable localization of
 	// rrno messages here.
 	return (char *)s;
 #else
+	if (e >= sizeof errmsgidx / sizeof *errmsgidx) e = 0;
+	s = (char *)&errmsgstr + errmsgidx[e];
 	return (char *)LCTRANS(s, LC_MESSAGES, loc);
 #endif
 }

test/test_core.py

@@ -6169,6 +6169,10 @@ def test_unistd_curdir(self):
   def test_unistd_close(self):
     self.do_run_in_out_file_test('unistd/close.c')
 
+  @also_with_noderawfs
+  def test_unistd_errno(self):
+    self.do_run_in_out_file_test('unistd/errno.c')
+
   def test_unistd_fsync_stdout(self):
     self.do_run_in_out_file_test('unistd/fsync_stdout.c')
 

test/unistd/errno.c

@@ -0,0 +1,17 @@
+/*
+ * Copyright 2011 The Emscripten Authors.  All rights reserved.
+ * Emscripten is available under two separate licenses, the MIT license and the
+ * University of Illinois/NCSA Open Source License.  Both these licenses can be
+ * found in the LICENSE file.
+ */
+
+#include <stdio.h>
+#include <string.h>
+#include <errno.h>
+#include <unistd.h>
+#include <emscripten.h>
+
+int main() {
+    int error = -1;
+    printf("errno: %s\n", strerror(error));
+}

test/unistd/errno.out

@@ -0,0 +1 @@
+errno: Unknown error -1