Skip to content

Commit 8fc4d1f

Browse files
authored
Add EMTEST_LACKS_MICROPHONE_ACCESS (#25526)
Add EMTEST_LACKS_MICROPHONE_ACCESS to allow skipping test browser.test_openal_capture_sanity that requires microphone access. In e.g. Firefox the microphone access prompt does not seem to cause issues, but in Safari this seems to prompt up a modal dialog.
1 parent 18fa2a3 commit 8fc4d1f

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

test/test_browser.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,7 @@ def webgpu_disabled():
196196
requires_webgl2 = unittest.skipIf(webgl2_disabled(), "This test requires WebGL2 to be available")
197197
requires_webgpu = unittest.skipIf(webgpu_disabled(), "This test requires WebGPU to be available")
198198
requires_sound_hardware = skipExecIf(os.getenv('EMTEST_LACKS_SOUND_HARDWARE'), 'This test requires sound hardware')
199+
requires_microphone_access = skipExecIf(os.getenv('EMTEST_LACKS_MICROPHONE_ACCESS'), 'This test accesses microphone, which may need accepting a user prompt to enable it.')
199200
requires_offscreen_canvas = unittest.skipIf(os.getenv('EMTEST_LACKS_OFFSCREEN_CANVAS'), 'This test requires a browser with OffscreenCanvas')
200201
requires_es6_workers = unittest.skipIf(os.getenv('EMTEST_LACKS_ES6_WORKERS'), 'This test requires a browser with ES6 Module Workers support')
201202
requires_growable_arraybuffers = unittest.skipIf(os.getenv('EMTEST_LACKS_GROWABLE_ARRAYBUFFERS'), 'This test requires a browser that supports growable ArrayBuffers')
@@ -2283,6 +2284,7 @@ def test_glerror(self):
22832284
def test_openal_error(self, args):
22842285
self.btest_exit('openal/test_openal_error.c', cflags=args)
22852286

2287+
@requires_microphone_access
22862288
def test_openal_capture_sanity(self):
22872289
self.btest_exit('openal/test_openal_capture_sanity.c')
22882290

0 commit comments

Comments
 (0)