Skip to content

Commit 6ec477e

Browse files
authored
[ci] Split wasm64 misc tests into their own runner. NFC (#25536)
Prior to this we were tacking on the extra misc tests on the end of wasm64-4gb runner.
1 parent ac45ded commit 6ec477e

File tree

1 file changed

+29
-3
lines changed

1 file changed

+29
-3
lines changed

.circleci/config.yml

Lines changed: 29 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -820,7 +820,31 @@ jobs:
820820
command: echo "NODE_JS = NODE_JS_TEST" >> ~/emsdk/.emscripten
821821
- run-tests:
822822
title: "wasm64_4gb"
823-
test_targets: "wasm64_4gb
823+
test_targets: "wasm64_4gb"
824+
- upload-test-results
825+
test-wasm64-misc:
826+
environment:
827+
LANG: "C.UTF-8"
828+
# We don't use `bionic` here since its too old to run recent node versions:
829+
# `/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found`
830+
executor: linux-python
831+
steps:
832+
- prepare-for-tests
833+
# The linux-python image uses /home/circleci rather than /root and jsvu
834+
# hardcodes /root into its launcher scripts so we need to reinstall v8.
835+
- run: rm -rf $HOME/.jsvu
836+
- install-v8
837+
- install-node-canary
838+
# When running wasm64 tests we need to make sure we use the testing
839+
# version of node (node canary) when running the compiler output (e.g.
840+
# in configure tests.
841+
- run:
842+
name: configure node canary
843+
command: echo "NODE_JS = NODE_JS_TEST" >> ~/emsdk/.emscripten
844+
- run-tests:
845+
title: "wasm64"
846+
test_targets: "
847+
other.*_wasm64
824848
core_2gb.test_*em_asm*
825849
core_2gb.test_*embind*
826850
core_2gb.test_fs_js_api_wasmfs
@@ -829,8 +853,7 @@ jobs:
829853
wasm64l.test_bigswitch
830854
wasm64l.test_module_wasm_memory
831855
wasm64l.test_longjmp2_emscripten
832-
wasm64l.test_embind_val_basics_legacy
833-
other.*_wasm64"
856+
wasm64l.test_embind_val_basics_legacy"
834857
- upload-test-results
835858
test-jsc:
836859
executor: linux-python
@@ -1280,6 +1303,9 @@ workflows:
12801303
- test-core3:
12811304
requires:
12821305
- build-linux
1306+
- test-wasm64-misc:
1307+
requires:
1308+
- build-linux
12831309
- test-wasm64-4gb:
12841310
requires:
12851311
- build-linux

0 commit comments

Comments
 (0)