Merge branch 'main' into issue-20983

Author: ypujante

.circleci/config.yml

@@ -106,11 +106,22 @@ commands:
             echo "if os.path.exists(V8_ENGINE[0]): JS_ENGINES.append(V8_ENGINE)" >> ~/emsdk/.emscripten
             cat ~/emsdk/.emscripten
             echo "export PATH=\"$HOME/node-v${version}-linux-x64/bin:\$PATH\"" >> $BASH_ENV
-  install-node-latest:
-    description: "install latest version of node"
+  install-node-oldest:
+    description: "install node (oldest)"
     steps:
       - install-node-version:
-         node_version: "19.0.0"
+          # Keep this in sync with `OLDEST_SUPPORTED_NODE` in `feature_matrix.py`
+          node_version: "12.22.9"
+  install-node-lts:
+    description: "install node (current LTS)"
+    steps:
+      - install-node-version:
+         node_version: "22.21.0"
+  install-node-newest:
+    description: "install node (newest)"
+    steps:
+      - install-node-version:
+         node_version: "24.10.0"
   install-node-canary:
     description: "install canary version of node"
     steps:
@@ -253,9 +264,6 @@ commands:
           # Must be absolute path or relative path from working_directory
           at: ~/
       - checkout
-      - run:
-          name: submodule update
-          command: git submodule update --init
       - emsdk-env
       - bootstrap
       - pip-install
@@ -376,9 +384,6 @@ commands:
           at: ~/
       - checkout
       - remove-linux-binaries
-      - run:
-          name: submodule update
-          command: git submodule update --init
   run-tests-firefox:
     description: "Runs emscripten tests under firefox"
     parameters:
@@ -866,9 +871,6 @@ jobs:
     executor: linux-python
     steps:
       - checkout
-      - run:
-          name: submodule update
-          command: git submodule update --init
       - pip-install
       - install-emsdk
       - run:
@@ -891,9 +893,6 @@ jobs:
     executor: linux-python
     steps:
       - checkout
-      - run:
-          name: submodule update
-          command: git submodule update --init
       - pip-install
       - install-emsdk
       - run:
@@ -921,9 +920,6 @@ jobs:
       EMTEST_SKIP_V8: "1"
     steps:
       - checkout
-      - run:
-          name: submodule update
-          command: git submodule update --init
       - pip-install
       - install-emsdk
       # `install-node-version` only changes the NODE_JS_TEST (the version of
@@ -957,9 +953,7 @@ jobs:
             "
       # Run some basic tests with the minimum version of node that we currently
       # support in the generated code.
-      # Keep this in sync with `OLDEST_SUPPORTED_NODE` in `feature_matrix.py`
-      - install-node-version:
-          node_version: "12.22.9"
+      - install-node-oldest
       - run-tests:
           title: "node (oldest / 12.22.9)"
           extra-cflags: "-sMIN_NODE_VERSION=122209"
@@ -1023,10 +1017,28 @@ jobs:
             core2.test_unistd_unlink_rawfs
             core2.test_unistd_write_broken_link_rawfs
             "
+      # Run a few test with the most recent LTS version of node
+      - install-node-lts
+      - run-tests:
+          # Run tests that on older versions of node would require flags, but
+          # those flags should not be injected on newer versions.
+          title: "node (lts)"
+          test_targets: "-v
+            other.test_gen_struct_info
+            other.test_native_call_before_init
+            other.test_node_unhandled_rejection
+            other.test_js_optimizer_verbose
+            other.test_min_node_version
+            other.test_node_emscripten_num_logical_cores
+            core2.test_pthread_create
+            core2.test_i64_invoke_bigint
+            core2.test_sse2
+            core2.test_source_map
+            core2.test_exceptions_wasm_legacy
+            core2.test_pthread_unhandledrejection
+            "
       # Run a few test with the most recent version of node
-      # In particular we have some tests that require node flags on older
-      # versions of node but not with the most recent version.
-      - install-node-latest
+      - install-node-newest
       - run-tests:
           # Run tests that on older versions of node would require flags, but
           # those flags should not be injected on newer versions.
@@ -1043,7 +1055,8 @@ jobs:
             core2.test_sse2
             core2.test_source_map
             core2.test_exceptions_wasm_legacy
-            core2.test_pthread_unhandledrejection"
+            core2.test_pthread_unhandledrejection
+            "
       - upload-test-results
   test-other:
     executor: focal
@@ -1065,9 +1078,6 @@ jobs:
       EMTEST_LACKS_WEBGPU: "1"
     steps:
       - checkout
-      - run:
-          name: submodule update
-          command: git submodule update --init
       - pip-install
       - install-emsdk
       - run-tests-chrome:
@@ -1152,9 +1162,6 @@ jobs:
     executor: focal
     steps:
       - checkout
-      - run:
-          name: submodule update
-          command: git submodule update --init
       - pip-install
       - install-emsdk
       - run-tests-firefox:
@@ -1278,9 +1285,9 @@ jobs:
     steps:
       - setup-macos
       - install-emsdk
+      - pip-install:
+          python: "$EMSDK_PYTHON"
       - freeze-cache
-      # TODO: We can't currently do pip install here since numpy and other packages
-      # are currently missing arm64 macos binaries.
       - run-tests:
           title: "crossplatform tests"
           test_targets: "--crossplatform-only"

.github/ISSUE_TEMPLATE/feature_depreaction.md

@@ -0,0 +1,23 @@
+---
+name: Feature deprecation
+about: Use this template for removal of features from emscripten.
+title: 'Deprecation proposal for <FEATURE>'
+labels: 'deprecation'
+assignees: ''
+
+---
+
+Tracking issue for the deprecation and removal of <FEATURE>.
+
+The process for deprecating and removing features from emscripten is laid out out in https://github.com/emscripten-core/emscripten/blob/main/docs/process.md#deprecating-settings-and-features.
+
+At any point in the process we may decide to delay or abort the deprecation and close this issue.
+
+Deprecation checklist:
+
+- [ ] Open an issue (this)
+- [ ] Perform global search for usage in public repos
+- [ ] Send message to emscripten-discuss
+- [ ] Add "deprecation" warning to emcc
+- [ ] Wait at least 4 releases or 2 months
+- [ ] Remove feature from codebase

.github/workflows/ci.yml

@@ -71,10 +71,15 @@ jobs:
             echo ""
             echo "Test expectations are out-of-date on the target branch."
             echo "Please run the 'Rebaseline Tests' github action on the target"
-            echo "branch (normally 'main') before proceeding."
+            echo "branch (normally 'main') before proceeding.  You can do this"
+            echo "from the web UI or from the command line:"
             echo ""
-            echo "You can also run './tools/maint/rebaseline_tests.py --new-branch'"
-            echo "and use it to create a seperate PR."
+            echo "  gh workflow run rebaseline-tests.yml"
+            echo ""
+            echo "You can also run the following command locally and upload"
+            echo "your own PR:"
+            echo ""
+            echo "  ./tools/maint/rebaseline_tests.py --new-branch'"
             exit 1
           fi
       - name: Check test expectations on PR branch

ChangeLog.md

@@ -18,13 +18,35 @@ to browse the changes between the tags.
 
 See docs/process.md for more on how version tagging works.
 
-4.0.18 (in development)
+4.0.20 (in development)
 -----------------------
+
+4.0.19 - 11/04/25
+-----------------
+- The `RETAIN_COMPILER_SETTINGS` setting and the corresponding
+  `emscripten_get_compiler_setting` API no longer store or report internal
+  compiler settings (those listed in `setttings_internal.js`).  We made an
+  exception here for `EMSCRIPTEN_VERSION` which is the only internal setting
+  where we could find usage of `emscripten_get_compiler_setting` (in a global
+  GitHub search). (#25667)
+- When using dynamic linking the main module is no longer built as a relocatable
+  binary.  This will significantly reduce the overhead of dynamic linking for
+  the main program, for example, eliminating all internal relocations. If you
+  encounter any issues with new default it is possible to revert to the old
+  behaviour by adding `-sRELOCATABLE` when linking the main module. (#25522)
+
+4.0.18 - 10/24/25
+-----------------
 - The `emrun.py` script no longer support running on python2. (#25597)
 - `-sUSE_WEBGPU` was removed in favor of the external port Emdawnwebgpu which
   are used via `--use-port=emdawnwebgpu`. See 4.0.10 release notes for details.
 - A new `CROSS_ORIGIN` setting was added in order to work around issues hosting
   emscripten programs across different origins (#25581)
+- The binary data encoding for `SINGLE_FILE` mode was changed from base64 to
+  directly embed binary data into UTF-8 string. Users who use the `SINGLE_FILE`
+  mode along with a custom HTML file should declare the files to have UTF-8
+  encoding. See `src/settings.js` docs on `SINGLE_FILE`. Use the option
+  `-sSINGLE_FILE_BINARY_ENCODE=0` to fall back to base64 encoding. (#25599)
 
 4.0.17 - 10/17/25
 -----------------

docs/process.md

@@ -314,9 +314,9 @@ decide collectively to abandon the deprecation, or to delay it.
    warning when the feature is used.  For settings this is normally as simple
    as adding it to `DEPRECATED_SETTINGS` in `settings.py`.
 
-4. Perform a global search of public github repositories for usage of the
-   feature.   If you work for a company with a large internal codebase (e.g.
-   Google) please also search globally there.
+4. Perform a [global search][global_github_search] of public GitHub repositories
+   for usage of the feature.  If you work for a company with a large internal
+   codebase (e.g. Google) please also search globally there.
 
 5. Feedback from steps (2), (3) and (4) should be summarized in the bug where
    discussions about the impact of deprecation can then proceed.
@@ -356,3 +356,4 @@ decide collectively to abandon the deprecation, or to delay it.
 [update_libcxxabi_emscripten]: https://github.com/emscripten-core/emscripten/blob/main/system/lib/update_libcxxabi.py
 [update_libunwind_emscripten]: https://github.com/emscripten-core/emscripten/blob/main/system/lib/update_libunwind.py
 [update_musl_emscripten]: https://github.com/emscripten-core/emscripten/blob/main/system/lib/update_musl.py
+[global_github_search]: https://github.com/search?q=%2F%28%3F-i%29%5CbMY_SETTING%5Cb%2F+-org%3Aemscripten-core+-path%3Aemcc.*+-path%3Asettings.*+-path%3Asettings_reference.*&type=code

embuilder.py

@@ -120,6 +120,7 @@
     'crtbegin',
     'libsanitizer_common_rt',
     'libubsan_rt',
+    'libwasm_workers-debug',
     'libwasm_workers-debug-stub',
     'libfetch',
     'libfetch-mt',
@@ -215,10 +216,10 @@ def main():
   args = parser.parse_args()
 
   if args.operation != 'rebuild' and len(args.targets) == 0:
-    shared.exit_with_error('no build targets specified')
+    utils.exit_with_error('no build targets specified')
 
   if args.operation == 'rebuild' and not USE_NINJA:
-    shared.exit_with_error('"rebuild" operation is only valid when using Ninja')
+    utils.exit_with_error('"rebuild" operation is only valid when using Ninja')
 
   # process flags