Skip to content

Commit 55a50f3

Browse files
authored
[ci] Avoiding syncing git submodules unless needed. NFC (#25730)
Also remove outdated comment regarding apple arm64.
1 parent 0a2059a commit 55a50f3

File tree

1 file changed

+2
-23
lines changed

1 file changed

+2
-23
lines changed

.circleci/config.yml

Lines changed: 2 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -264,9 +264,6 @@ commands:
264264
# Must be absolute path or relative path from working_directory
265265
at: ~/
266266
- checkout
267-
- run:
268-
name: submodule update
269-
command: git submodule update --init
270267
- emsdk-env
271268
- bootstrap
272269
- pip-install
@@ -387,9 +384,6 @@ commands:
387384
at: ~/
388385
- checkout
389386
- remove-linux-binaries
390-
- run:
391-
name: submodule update
392-
command: git submodule update --init
393387
run-tests-firefox:
394388
description: "Runs emscripten tests under firefox"
395389
parameters:
@@ -877,9 +871,6 @@ jobs:
877871
executor: linux-python
878872
steps:
879873
- checkout
880-
- run:
881-
name: submodule update
882-
command: git submodule update --init
883874
- pip-install
884875
- install-emsdk
885876
- run:
@@ -902,9 +893,6 @@ jobs:
902893
executor: linux-python
903894
steps:
904895
- checkout
905-
- run:
906-
name: submodule update
907-
command: git submodule update --init
908896
- pip-install
909897
- install-emsdk
910898
- run:
@@ -932,9 +920,6 @@ jobs:
932920
EMTEST_SKIP_V8: "1"
933921
steps:
934922
- checkout
935-
- run:
936-
name: submodule update
937-
command: git submodule update --init
938923
- pip-install
939924
- install-emsdk
940925
# `install-node-version` only changes the NODE_JS_TEST (the version of
@@ -1093,9 +1078,6 @@ jobs:
10931078
EMTEST_LACKS_WEBGPU: "1"
10941079
steps:
10951080
- checkout
1096-
- run:
1097-
name: submodule update
1098-
command: git submodule update --init
10991081
- pip-install
11001082
- install-emsdk
11011083
- run-tests-chrome:
@@ -1180,9 +1162,6 @@ jobs:
11801162
executor: focal
11811163
steps:
11821164
- checkout
1183-
- run:
1184-
name: submodule update
1185-
command: git submodule update --init
11861165
- pip-install
11871166
- install-emsdk
11881167
- run-tests-firefox:
@@ -1306,9 +1285,9 @@ jobs:
13061285
steps:
13071286
- setup-macos
13081287
- install-emsdk
1288+
- pip-install:
1289+
python: "$EMSDK_PYTHON"
13091290
- freeze-cache
1310-
# TODO: We can't currently do pip install here since numpy and other packages
1311-
# are currently missing arm64 macos binaries.
13121291
- run-tests:
13131292
title: "crossplatform tests"
13141293
test_targets: "--crossplatform-only"

0 commit comments

Comments
 (0)