Make EXPORTED_RUNTIME_METHODS into a Set within the JS compiler. NFC (#21880)

Author: sbc100

src/compiler.mjs

@@ -55,6 +55,7 @@ WASM_EXPORTS = new Set(WASM_EXPORTS);
 SIDE_MODULE_EXPORTS = new Set(SIDE_MODULE_EXPORTS);
 INCOMING_MODULE_JS_API = new Set(INCOMING_MODULE_JS_API);
 ALL_INCOMING_MODULE_JS_API = new Set(ALL_INCOMING_MODULE_JS_API);
+EXPORTED_RUNTIME_METHODS = new Set(EXPORTED_RUNTIME_METHODS);
 WEAK_IMPORTS = new Set(WEAK_IMPORTS);
 if (symbolsOnly) {
   INCLUDE_FULL_LIBRARY = 1;

src/modules.mjs

@@ -368,13 +368,11 @@ function addMissingLibraryStubs(unusedLibSymbols) {
 
 // export parts of the JS runtime that the user asked for
 function exportRuntime() {
-  const EXPORTED_RUNTIME_METHODS_SET = new Set(EXPORTED_RUNTIME_METHODS);
-
   // optionally export something.
   function maybeExport(name) {
     // If requested to be exported, export it.  HEAP objects are exported
     // separately in updateMemoryViews
-    if (EXPORTED_RUNTIME_METHODS_SET.has(name) && !name.startsWith('HEAP')) {
+    if (EXPORTED_RUNTIME_METHODS.has(name) && !name.startsWith('HEAP')) {
       return `Module['${name}'] = ${name};`;
     }
   }
@@ -449,7 +447,7 @@ function exportRuntime() {
   // dynCall_* methods are not hardcoded here, as they
   // depend on the file being compiled. check for them
   // and add them.
-  for (const name of EXPORTED_RUNTIME_METHODS_SET) {
+  for (const name of EXPORTED_RUNTIME_METHODS) {
     if (/^dynCall_/.test(name)) {
       // a specific dynCall; add to the list
       runtimeElements.push(name);
@@ -472,7 +470,7 @@ function exportRuntime() {
 
   // check all exported things exist, warn about typos
   runtimeElementsSet = new Set(runtimeElements);
-  for (const name of EXPORTED_RUNTIME_METHODS_SET) {
+  for (const name of EXPORTED_RUNTIME_METHODS) {
     if (!runtimeElementsSet.has(name)) {
       warn(`invalid item in EXPORTED_RUNTIME_METHODS: ${name}`);
     }
@@ -491,7 +489,7 @@ function exportRuntime() {
 
     const unexported = [];
     for (const name of runtimeElements) {
-      if (!EXPORTED_RUNTIME_METHODS_SET.has(name) && !unusedLibSymbols.has(name)) {
+      if (!EXPORTED_RUNTIME_METHODS.has(name) && !unusedLibSymbols.has(name)) {
         unexported.push(name);
       }
     }

src/parseTools.mjs

@@ -808,7 +808,7 @@ function isSymbolNeeded(symName) {
   if (DEFAULT_LIBRARY_FUNCS_TO_INCLUDE.includes(symName)) {
     return true;
   }
-  if (symName.startsWith('$') && symName.slice(1) in EXPORTED_RUNTIME_METHODS) {
+  if (symName.startsWith('$') && EXPORTED_RUNTIME_METHODS.has(symName.slice(1))) {
     return true;
   }
   return false;
@@ -913,7 +913,7 @@ function hasExportedSymbol(sym) {
 // wasmTable are set. In this case we maybe need to re-export them on the
 // Module object.
 function receivedSymbol(sym) {
-  if (EXPORTED_RUNTIME_METHODS.includes(sym)) {
+  if (EXPORTED_RUNTIME_METHODS.has(sym)) {
     return `Module['${sym}'] = ${sym};`;
   }
   return '';