Skip to content

Commit 1aa0b0e

Browse files
authored
Skip other.test_pthread_growth test on Windows on ARM (#25628)
Skip other.test_pthread_growth test on Windows on ARM if Node.js is 22.16.0. See #25627 In the future, after #25533 lands, we can move towards a direction of auto-detecting and auto-detecting skipping per Node version.
1 parent 4315e62 commit 1aa0b0e

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

test/test_other.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import json
1212
import locale
1313
import os
14+
import platform
1415
import random
1516
import re
1617
import select
@@ -12987,6 +12988,11 @@ def test_growable_arraybuffers(self):
1298712988
'minimal': (['-sMINIMAL_RUNTIME', '-sMODULARIZE', '-sEXPORT_NAME=MyModule'],),
1298812989
})
1298912990
def test_pthread_growth(self, cflags, pthread_pool_size = 1):
12991+
if WINDOWS and platform.machine() == 'ARM64':
12992+
# https://github.com/emscripten-core/emscripten/issues/25627
12993+
# TODO: Switch this to a "require Node.js 24" check
12994+
self.require_node_canary()
12995+
1299012996
self.set_setting('PTHREAD_POOL_SIZE', pthread_pool_size)
1299112997
if '-sGROWABLE_ARRAYBUFFERS' in cflags:
1299212998
self.node_args.append('--experimental-wasm-rab-integration')

0 commit comments

Comments
 (0)