[rebaseline_tests] Return non-zero when tests are up-to-date

Author: sbc100

.github/workflows/ci.yml

@@ -62,7 +62,7 @@ jobs:
           # Hack to honor changes to rebaseline_tests.py in the current PR
           git checkout - ./tools/maint/rebaseline_tests.py
           ./bootstrap
-          if ! ./tools/maint/rebaseline_tests.py --check-only; then
+          if ./tools/maint/rebaseline_tests.py --check-only; then
             echo "Test expectations are out-of-date on the target branch."
             echo "You can run './tools/maint/rebaseline_tests.py --new-branch'"
             echo "and use it to create a seperate PR."
@@ -77,7 +77,7 @@ jobs:
           git checkout ${{ github.sha }}
           git rev-parse HEAD
           ./bootstrap
-          if ! ./tools/maint/rebaseline_tests.py --check-only --clear-cache; then
+          if ./tools/maint/rebaseline_tests.py --check-only --clear-cache; then
             echo "Test expectations are out-of-date on the PR branch."
             echo "You can run './tools/maint/rebaseline_tests.py' to"
             echo "create a commit updating the expectations."

tools/maint/rebaseline_tests.py

@@ -89,7 +89,7 @@ def main():
 
   if not filenames:
     print('test expectations are up-to-date')
-    return 0
+    return 1
 
   if args.check_only:
     message = f'''Test expectations are out-of-date
@@ -120,7 +120,7 @@ def main():
 
   print(message)
   if args.check_only:
-    return 1
+    return 0
 
   if args.new_branch:
     run(['git', 'checkout', '-b', 'rebaseline_tests'])