Move keyword check to resolver

Author: gitKrystan

transforms/no-implicit-this/helpers/known-helpers.ts renamed to transforms/no-implicit-this/helpers/keywords.ts

@@ -1,4 +1,18 @@
-const KNOWN_HELPERS = [
+import Debug from 'debug';
+
+const debug = Debug('ember-no-implicit-this-codemod:keywords');
+
+// FIXME: Check keywords based on type. E.g. some can only be used in component vs helper position.
+export function isKeyword(_type: 'component' | 'helper' | 'ambiguous', name: string): boolean {
+  if (KNOWN_KEYWORDS.includes(name)) {
+    debug(`Skipping \`%s\` because it is a known helper`, name);
+    return true;
+  } else {
+    return false;
+  }
+}
+
+const KNOWN_KEYWORDS = [
   // Ember.js
   'action',
   'array',
@@ -39,5 +53,3 @@ const KNOWN_HELPERS = [
   'render-inverse', // glimmer blocks
   '-get-dynamic-var', // glimmer internal helper
 ];
-
-export default KNOWN_HELPERS;

transforms/no-implicit-this/helpers/plugin.ts

@@ -1,6 +1,5 @@
 import Debug from 'debug';
 import { AST, builders as b, traverse } from 'ember-template-recast';
-import KNOWN_HELPERS from './known-helpers';
 import { Options } from './options';
 
 const debug = Debug('ember-no-implicit-this-codemod:plugin');
@@ -75,15 +74,7 @@ export default function transform(root: AST.Node, { customHelpers, resolver }: O
     Object.assign(node, b.path(`this.${node.original}`));
   }
 
-  // app/components/foo.js
-  // <div class={{foo}} />
-
   function isHelper(name: string) {
-    if (KNOWN_HELPERS.includes(name)) {
-      debug(`Skipping \`%s\` because it is a known helper`, name);
-      return true;
-    }
-
     if (customHelpers.includes(name)) {
       debug(`Skipping \`%s\` because it is a custom configured helper`, name);
       return true;

transforms/no-implicit-this/helpers/resolver.ts

@@ -3,9 +3,13 @@ import { Telemetry, getTelemetry } from './telemetry';
 import { Resolver as _EmbroiderResolver } from '@embroider/core';
 import { readFileSync } from 'node:fs';
 import { resolve } from 'node:path';
+import { isKeyword } from './keywords';
 
 export default abstract class Resolver {
   has(type: 'component' | 'helper' | 'ambiguous', name: string): boolean {
+    if (isKeyword(type, name)) {
+      return true;
+    }
     switch (type) {
       case 'component':
         return this.hasComponent(name);
@@ -16,10 +20,10 @@ export default abstract class Resolver {
     }
   }
 
-  abstract hasComponent(name: string): boolean;
-  abstract hasHelper(name: string): boolean;
+  protected abstract hasComponent(name: string): boolean;
+  protected abstract hasHelper(name: string): boolean;
 
-  hasAmbiguous(name: string): boolean {
+  protected hasAmbiguous(name: string): boolean {
     return this.hasComponent(name) || this.hasHelper(name);
   }
 }