Add custom gatherFn for telemetry

Author: gitKrystan

test/fixtures/3.28/input/app/components/gherkyn.hbs

@@ -1,6 +1,6 @@
 {{! template-lint-disable no-implicit-this }}
 {{! template-lint-disable no-curly-component-invocation }}
-<h1>[{{property}}]</h1>
+<h1>[{{this.property}}]</h1>
 
 <h1>[{{this.property}}]</h1>
 

transforms/no-implicit-this/helpers/options.ts

@@ -1,17 +1,14 @@
 import { getOptions as getCodemodOptions, runTransform } from 'codemod-cli';
 import Debug from 'debug';
-import {
-  analyzeEmberObject,
-  gatherTelemetryForUrl,
-  getTelemetry,
-} from 'ember-codemods-telemetry-helpers';
+import { gatherTelemetryForUrl, getTelemetry } from 'ember-codemods-telemetry-helpers';
 import fs from 'node:fs';
 import http from 'node:http';
 import path from 'node:path';
 import yargs from 'yargs';
 import { ZodError, ZodType, z } from 'zod';
 import { assert } from '../../../helpers/types';
 import Resolver, { EmbroiderResolver, MockResolver, RuntimeResolver } from './resolver';
+import { RuntimeData } from './telemetry';
 
 const debug = Debug('ember-no-implicit-this-codemod');
 
@@ -128,7 +125,17 @@ export class Runner {
 
     if (telemetryType === 'runtime') {
       debug('Gathering telemetry data from %s ...', this.options.url);
-      await gatherTelemetryForUrl(this.options.url, analyzeEmberObject);
+      await gatherTelemetryForUrl(
+        this.options.url,
+        (_module: unknown, modulePath: string): RuntimeData | void => {
+          // FIXME: Don't hardcode app name
+          if (modulePath.startsWith('pyckle/helpers/')) {
+            return { type: 'Helper' };
+          } else if (modulePath.startsWith('pyckle/components/')) {
+            return { type: 'Component' };
+          }
+        }
+      );
 
       const telemetry = getTelemetry() as Record<string, unknown>; // FIXME
       debug('Gathered telemetry on %d modules', Object.keys(telemetry).length);

transforms/no-implicit-this/helpers/telemetry.ts

@@ -2,15 +2,10 @@ import { getTelemetry as getRawTelemetry } from 'ember-codemods-telemetry-helper
 import { z } from 'zod';
 
 const RuntimeData = z.object({
-  type: z.string().optional(),
-  computedProperties: z.array(z.string()).default([]),
-  offProperties: z.record(z.array(z.string())).default({}),
-  overriddenActions: z.array(z.string()).default([]),
-  overriddenProperties: z.array(z.string()).default([]),
-  unobservedProperties: z.record(z.array(z.string())).default({}),
+  type: z.union([z.literal('Component'), z.literal('Helper')]),
 });
 
-type RuntimeData = z.infer<typeof RuntimeData>;
+export type RuntimeData = z.infer<typeof RuntimeData>;
 
 export const Telemetry = z.record(RuntimeData);
 

types/ember-codemods-telemetry-helpers.d.ts

@@ -2,6 +2,9 @@ declare module 'ember-codemods-telemetry-helpers' {
   export function getTelemetry(): unknown;
   export function getTelemetryFor(filePath: string): unknown;
   export function setTelemetry(telemetry: unknown): void;
-  export function gatherTelemetryForUrl(url: string, gatherFn: () => unknown): Promise<unknown>;
-  export function analyzeEmberObject(): unknown;
+  export function gatherTelemetryForUrl<T extends unknown[]>(
+    url: string,
+    gatherFn: (module: unknown, path: string, ...args: T) => unknown,
+    ...args: T
+  ): Promise<unknown>;
 }