-
Notifications
You must be signed in to change notification settings - Fork 2
Implement mechanism for subgraph replacement #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NeiroYT
wants to merge
29
commits into
main
Choose a base branch
from
neiroyt/subgraph_transforms
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 16 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
9890df6
First
3f854c6
New changes
883a9ef
Clangs
4b1db15
Err
bb4d7a3
Fixes
d844ff9
Fix
30b2a5e
Tests
0ad75bd
Fix
0739ca5
Merge...
4f1d1b0
Graph changes
2608208
Graph changes
41f381f
Clang tidy
63f0d88
any of
5e7b39c
any of
ff306cc
Additional changes
24f81c2
Additional changes
0f3ac42
Updates are coming
10e19cf
Merge
2dd056b
Revert "Merge"
81ec6bf
Merge
cc0b8f5
Merge
1b68c52
Merge try
ecedd29
Revert "Additional changes"
06554b3
Reapply "Additional changes"
5716258
Revert "Merge try"
7badfe1
Final
38bd6ce
Merging
a44732d
Temp changes
a871c5d
Changes
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removeSingleLayer удаляет сам узел и его ребра, но не удаляет id из in_edges_ всех соседей и не сдвигает хранящиеся там индексы после пере‑индексации. Уже после первого удаления граф остаётся с «висячими» id, поэтому areLayerNext, обход и трансформации начинают работать с мусорными индексами. Нужно чистить in_edges_ у всех вершин и декрементировать значения >id.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
тот же removeSingleLayer не корректирует start_/end_. При удалении вершины с id меньше входа/выхода вы оставляете указатели на неверный слой; при удалении самого входа/ выхода они вообще становятся висячими. Нужно обновлять start_/end_ (или запрещать удаление этих вершин) после смещения индексов.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removeConnection вычищает все связи с другими вершинами, так что там все представление графа чинится на каждом шаге, чтобы избежать замусоривания в процессе.
start_ и end_ действительно скорректирую