Rename only happens in post-command and recursion is prevented

Author: aaronjensen

auto-rename-tag.el

@@ -47,6 +47,9 @@
 (defvar-local auto-rename-tag--pre-command-actived nil
   "Check if `pre-command-hook' called.")
 
+(defvar-local auto-rename-tag--after-action-active nil
+  "Check if `after-action' is currently called.")
+
 (defvar-local auto-rename-tag--record-prev-word ""
   "Record down the word in `pre-command-hook'.")
 
@@ -344,30 +347,33 @@ DIRECT can be either only 'backward and 'forward."
 
 (defun auto-rename-tag--before-action ()
   "Before rename core action."
-  (setq auto-rename-tag--record-prev-word "")  ; Reset record.
-  (setq auto-rename-tag--pre-command-actived nil)  ; Reset flag.
+  (unless auto-rename-tag--after-action-active
+    (setq auto-rename-tag--record-prev-word "")     ; Reset record.
+    (setq auto-rename-tag--pre-command-actived nil) ; Reset flag.
 
-  (when (and (not undo-in-progress)
-             (auto-rename-tag--inside-tag-p)
-             (not (auto-rename-tag--self-tag-p)))
-    (save-excursion
-      ;; Set active flag.
-      (setq auto-rename-tag--pre-command-actived t)
+    (when (and (not undo-in-progress)
+               (auto-rename-tag--inside-tag-p)
+               (not (auto-rename-tag--self-tag-p)))
+      (save-excursion
+        ;; Set active flag.
+        (setq auto-rename-tag--pre-command-actived t)
 
-      (setq auto-rename-tag--record-prev-word (auto-rename-tag--get-tag-name-at-point))
+        (setq auto-rename-tag--record-prev-word (auto-rename-tag--get-tag-name-at-point))
 
-      (when (string= auto-rename-tag--record-prev-word "/")
-        (setq auto-rename-tag--record-prev-word ""))
+        (when (string= auto-rename-tag--record-prev-word "/")
+          (setq auto-rename-tag--record-prev-word ""))
 
-      ;; Ensure `auto-rename-tag--record-prev-word' is something other than nil.
-      (unless auto-rename-tag--record-prev-word
-        (setq auto-rename-tag--record-prev-word "")))))
+        ;; Ensure `auto-rename-tag--record-prev-word' is something other than nil.
+        (unless auto-rename-tag--record-prev-word
+          (setq auto-rename-tag--record-prev-word ""))))))
 
 (defun auto-rename-tag--after-action ()
   "After rename core action."
-  (when auto-rename-tag--pre-command-actived
+  (when (and auto-rename-tag--pre-command-actived
+             (not auto-rename-tag--after-action-active))
     (save-excursion
-      (let ((is-end-tag nil)
+      (let ((auto-rename-tag--after-action-active t)
+            (is-end-tag nil)
             (current-word "") (pair-tag-word ""))
         ;; Goto the first character inside the tag.
         (auto-rename-tag--goto-the-start-of-tag-name)
@@ -416,25 +422,18 @@ DIRECT can be either only 'backward and 'forward."
   "Do stuff before buffer is changed."
   (auto-rename-tag--before-action))
 
-(defun auto-rename-tag--after-change (&rest _args)
-  "Do stuff after buffer is changed."
-  (auto-rename-tag--after-action))
-
 (defun auto-rename-tag--post-command ()
-  "Do stuff after buffer is changed.
-NOTE: Having this function is for `lsp` display issue with flycheck."
+  "Do stuff after buffer is changed."
   (auto-rename-tag--after-action))
 
 (defun auto-rename-tag--enable ()
   "Enable `auto-rename-tag' in current buffer."
   (add-hook 'before-change-functions #'auto-rename-tag--before-change nil t)
-  (add-hook 'after-change-functions #'auto-rename-tag--after-change nil t)
   (add-hook 'post-command-hook #'auto-rename-tag--post-command nil t))
 
 (defun auto-rename-tag--disable ()
   "Disable `auto-rename-tag' in current buffer."
   (remove-hook 'before-change-functions #'auto-rename-tag--before-change t)
-  (remove-hook 'after-change-functions #'auto-rename-tag--after-change t)
   (remove-hook 'post-command-hook #'auto-rename-tag--post-command t))
 
 ;;;###autoload