Skip to content

Commit faf853c

Browse files
alypengkermorgant
authored andcommitted
Support extract_method, extract_expression and change_visibility (#125)
Thanks @alypeng for the work on this commit * Add support for extract_method and extract_expression * Add support for change_visibility
1 parent e6c80a3 commit faf853c

File tree

1 file changed

+25
-2
lines changed

1 file changed

+25
-2
lines changed

phpactor.el

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -315,6 +315,8 @@ of GitHub.")
315315
(:path (phpactor--expand-local-file-name buffer-file-name))
316316
(:source_path (phpactor--expand-local-file-name buffer-file-name))
317317
(:offset (1- (position-bytes (point))))
318+
(:offset_start (1- (position-bytes (region-beginning))))
319+
(:offset_end (1- (position-bytes (region-end))))
318320
(:current_path (phpactor--expand-local-file-name buffer-file-name))
319321
(t (error "`%s' is unknown argument" key))))
320322

@@ -787,9 +789,9 @@ function."
787789

788790
;;;###autoload
789791
(defun phpactor-extract-constant ()
790-
"Execute Phpactor RPC extract-constant action."
792+
"Execute Phpactor RPC extract_constant action."
791793
(interactive)
792-
(let ((arguments (phpactor--command-argments :source :offset :path)))
794+
(let ((arguments (phpactor--command-argments :source :path :offset)))
793795
(apply #'phpactor-action-dispatch (phpactor--rpc "extract_constant" arguments))))
794796

795797
;;;###autoload
@@ -799,5 +801,26 @@ function."
799801
(let ((arguments (phpactor--command-argments :source :offset)))
800802
(apply #'phpactor-action-dispatch (phpactor--rpc "hover" arguments))))
801803

804+
;;;###autoload
805+
(defun phpactor-extract-method ()
806+
"Execute Phpactor RPC extract_method action."
807+
(interactive)
808+
(let ((arguments (phpactor--command-argments :source :path :offset_start :offset_end)))
809+
(apply #'phpactor-action-dispatch (phpactor--rpc "extract_method" arguments))))
810+
811+
;;;###autoload
812+
(defun phpactor-extract-expression ()
813+
"Execute Phpactor RPC extract_expression action."
814+
(interactive)
815+
(let ((arguments (phpactor--command-argments :source :path :offset_start :offset_end)))
816+
(apply #'phpactor-action-dispatch (phpactor--rpc "extract_expression" arguments))))
817+
818+
;;;###autoload
819+
(defun phpactor-change-visibility ()
820+
"Execute Phpactor RPC change_visibility action."
821+
(interactive)
822+
(let ((arguments (phpactor--command-argments :source :path :offset)))
823+
(apply #'phpactor-action-dispatch (phpactor--rpc "change_visibility" arguments))))
824+
802825
(provide 'phpactor)
803826
;;; phpactor.el ends here

0 commit comments

Comments
 (0)