Skip to content

Commit 9229263

Browse files
committed
Fix (let default-directory) instead of setq it
The default-directory must be set locally. People setting up Phpactor while editing will feel that behavior suspiciously. Since let binds variables only within that block, do not need to kill the buffer.
1 parent aa99ad4 commit 9229263

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

phpactor.el

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,8 @@
9999
(let ((package-folder (phpactor--get-package-directory))
100100
(composer-executable (car (composer--find-executable))))
101101
(unless composer-executable (error "`composer' not found"))
102-
(setq default-directory package-folder)
103-
(call-process composer-executable nil (get-buffer-create phpactor--buffer-name) nil "install" "--no-dev")))
102+
(let ((default-directory package-folder))
103+
(call-process composer-executable nil (get-buffer-create phpactor--buffer-name) nil "install" "--no-dev"))))
104104

105105
(defun phpactor--get-package-directory ()
106106
"Return the folder where phpactor.el is installed."

0 commit comments

Comments
 (0)