Skip to content

Commit 7499c22

Browse files
committed
Fix failing test
1 parent 5fc947b commit 7499c22

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

test/jupyter-test.el

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1901,8 +1901,14 @@ next(x"))))))
19011901

19021902
(ert-deftest jupyter-run-repl-issue-371 ()
19031903
:tags '(repl)
1904-
(jupyter-test-with-some-kernelspecs '("foo_qux" "qux" "bar_qux")
1905-
(let ((client (jupyter-run-repl "qux")))
1904+
(jupyter-test-with-some-kernelspecs
1905+
'("foo_qux" "qux" "bar_qux")
1906+
;; FIXME Should remove the usage of `jupyter-use-zmq', the
1907+
;; kernelspec is searched for in the kernelspecs of the notebook
1908+
;; server without this, but since the notebook server is already up
1909+
;; by the time this test runs, it won't find the kernelspec.
1910+
(let* ((jupyter-use-zmq t)
1911+
(client (jupyter-run-repl "qux")))
19061912
(unwind-protect
19071913
(should (equal (jupyter-kernelspec-name
19081914
(jupyter-kernel-action client

test/test-helper.el

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -365,14 +365,14 @@ variable."
365365
366366
The only difference between them will be their names."
367367
(let ((argv (vector "python" "-m" "ipykernel_launcher" "-f" "{connection_file}"))
368-
(save-silently t))
368+
(save-silently t))
369369
(dolist (name kernel-names)
370370
(let ((kernel-dir (format "%s/kernels/%s" data-dir name)))
371-
(make-directory kernel-dir t)
372-
(append-to-file (json-encode
373-
`(:argv ,argv :display_name ,name :language "python"))
374-
nil
375-
(format "%s/kernel.json" kernel-dir))))))
371+
(make-directory kernel-dir t)
372+
(append-to-file (json-encode
373+
`(:argv ,argv :display_name ,name :language "python"))
374+
nil
375+
(format "%s/kernel.json" kernel-dir))))))
376376

377377
(defun jupyter-test-ipython-kernel-version (spec)
378378
"Return the IPython kernel version string corresponding to SPEC.

0 commit comments

Comments
 (0)